From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: Peter Oh <peter.oh@bowerswilkins.com>,
"kvalo@qca.qualcomm.com" <kvalo@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "yiboz@codeaurora.org" <yiboz@codeaurora.org>
Subject: Re: [PATCH] ath10k: remove iteration in wake_tx_queue
Date: Fri, 29 Mar 2019 08:47:33 +0100 [thread overview]
Message-ID: <fd76296d-e88e-1dbd-b3d2-e9e7edc7f49d@gmail.com> (raw)
In-Reply-To: <ba7a88e5-10ff-2ec2-feee-6d4adf472833@bowerswilkins.com>
On 3/27/19 6:49 PM, Peter Oh wrote:
>
>
> On 03/27/2019 09:29 AM, Erik Stromdahl wrote:
>> Iterating the TX queue and thereby dequeuing all available packets in the
>> queue could result in performance penalties on some SMP systems.
>>
> Please share the test results and numbers you've run to help others
> thoughts.
>
I haven't run any tests with ath10k PCIe, but Yibo Zhao had noticed a 10%
degradation without this patch.
Yibo:
Can you provide iperf results etc. that shows the performance gain?
--
Erik
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: Peter Oh <peter.oh@bowerswilkins.com>,
"kvalo@qca.qualcomm.com" <kvalo@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "yiboz@codeaurora.org" <yiboz@codeaurora.org>
Subject: Re: [PATCH] ath10k: remove iteration in wake_tx_queue
Date: Fri, 29 Mar 2019 08:47:33 +0100 [thread overview]
Message-ID: <fd76296d-e88e-1dbd-b3d2-e9e7edc7f49d@gmail.com> (raw)
In-Reply-To: <ba7a88e5-10ff-2ec2-feee-6d4adf472833@bowerswilkins.com>
On 3/27/19 6:49 PM, Peter Oh wrote:
>
>
> On 03/27/2019 09:29 AM, Erik Stromdahl wrote:
>> Iterating the TX queue and thereby dequeuing all available packets in the
>> queue could result in performance penalties on some SMP systems.
>>
> Please share the test results and numbers you've run to help others
> thoughts.
>
I haven't run any tests with ath10k PCIe, but Yibo Zhao had noticed a 10%
degradation without this patch.
Yibo:
Can you provide iperf results etc. that shows the performance gain?
--
Erik
next prev parent reply other threads:[~2019-03-29 7:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 16:29 [PATCH] ath10k: remove iteration in wake_tx_queue Erik Stromdahl
2019-03-27 16:29 ` Erik Stromdahl
2019-03-27 17:49 ` Peter Oh
2019-03-27 17:49 ` Peter Oh
2019-03-29 7:47 ` Erik Stromdahl [this message]
2019-03-29 7:47 ` Erik Stromdahl
2019-04-01 12:17 ` Yibo Zhao
2019-04-01 12:17 ` Yibo Zhao
2019-04-01 11:05 ` Toke Høiland-Jørgensen
2019-04-01 11:05 ` Toke Høiland-Jørgensen
2019-04-16 18:54 ` Erik Stromdahl
2019-04-16 18:54 ` Erik Stromdahl
2019-04-16 19:07 ` Toke Høiland-Jørgensen
2019-04-16 19:07 ` Toke Høiland-Jørgensen
2019-04-17 13:29 ` Erik Stromdahl
2019-04-17 13:29 ` Erik Stromdahl
2019-04-26 7:07 ` Kalle Valo
2019-04-26 7:07 ` Kalle Valo
2019-09-25 5:41 ` Kalle Valo
2019-09-25 5:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd76296d-e88e-1dbd-b3d2-e9e7edc7f49d@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=peter.oh@bowerswilkins.com \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.