* [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path
@ 2023-11-14 9:48 Andrzej Hajda
2023-11-14 16:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Andrzej Hajda @ 2023-11-14 9:48 UTC (permalink / raw)
To: intel-gfx; +Cc: Andrzej Hajda, Tvrtko Ursulin, Matthew Auld
The only task of intel_gt_release_all is to zero gt table. Calling
it on error path prevents intel_gt_driver_late_release_all (called from
i915_driver_late_release) to cleanup GTs, causing leakage.
After i915_driver_late_release GT array is not used anymore so
it does not need cleaning at all.
Sample leak report:
BUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()
...
Object 0xffff888113420040 @offset=64
Allocated in __i915_request_create+0x75/0x610 [i915] age=18339 cpu=1 pid=1454
kmem_cache_alloc+0x25b/0x270
__i915_request_create+0x75/0x610 [i915]
i915_request_create+0x109/0x290 [i915]
__engines_record_defaults+0xca/0x440 [i915]
intel_gt_init+0x275/0x430 [i915]
i915_gem_init+0x135/0x2c0 [i915]
i915_driver_probe+0x8d1/0xdc0 [i915]
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8489
Fixes: bec68cc9ea42d8 ("drm/i915: Prepare for multiple GTs")
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/i915_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 80e85cadb9a262..428ace0bebaac9 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -782,7 +782,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
ret = i915_driver_mmio_probe(i915);
if (ret < 0)
- goto out_tiles_cleanup;
+ goto out_runtime_pm_put;
ret = i915_driver_hw_probe(i915);
if (ret < 0)
@@ -842,8 +842,6 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
i915_ggtt_driver_late_release(i915);
out_cleanup_mmio:
i915_driver_mmio_release(i915);
-out_tiles_cleanup:
- intel_gt_release_all(i915);
out_runtime_pm_put:
enable_rpm_wakeref_asserts(&i915->runtime_pm);
i915_driver_late_release(i915);
---
base-commit: c6f47b4817ee55a02359c3347a298876cfa93b0e
change-id: 20231114-dont_clean_gt_on_error_path-91cd9c3caa0a
Best regards,
--
Andrzej Hajda <andrzej.hajda@intel.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: do not clean GT table on error path
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
@ 2023-11-14 16:11 ` Patchwork
2023-11-14 16:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2023-11-14 16:11 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: do not clean GT table on error path
URL : https://patchwork.freedesktop.org/series/126385/
State : warning
== Summary ==
Error: dim checkpatch failed
272a68a547e9 drm/i915: do not clean GT table on error path
-:14: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14:
BUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()
-:27: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: bec68cc9ea42 ("drm/i915: Prepare for multiple GTs")'
#27:
Fixes: bec68cc9ea42d8 ("drm/i915: Prepare for multiple GTs")
total: 0 errors, 2 warnings, 0 checks, 16 lines checked
^ permalink raw reply [flat|nested] 7+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: do not clean GT table on error path
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
2023-11-14 16:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-11-14 16:30 ` Patchwork
2023-11-14 18:11 ` Andrzej Hajda
2023-11-15 1:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: do not clean GT table on error path (rev2) Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2023-11-14 16:30 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 15382 bytes --]
== Series Details ==
Series: drm/i915: do not clean GT table on error path
URL : https://patchwork.freedesktop.org/series/126385/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13873 -> Patchwork_126385v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_126385v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_126385v1, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/index.html
Participating hosts (37 -> 39)
------------------------------
Additional (4): fi-kbl-soraka bat-rpls-1 bat-kbl-2 bat-dg2-9
Missing (2): fi-snb-2520m fi-pnv-d510
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_126385v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@workarounds:
- bat-adlp-9: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-adlp-9/igt@i915_selftest@live@workarounds.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-adlp-9/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-atsm-1: [PASS][3] -> [WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-atsm-1/igt@i915_suspend@basic-s2idle-without-i915.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-atsm-1/igt@i915_suspend@basic-s2idle-without-i915.html
Known issues
------------
Here are the changes found in Patchwork_126385v1 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- bat-jsl-1: [PASS][5] -> [FAIL][6] ([i915#8293])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-jsl-1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-jsl-1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-1: NOTRUN -> [SKIP][7] ([i915#9318])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@info:
- bat-rpls-1: NOTRUN -> [SKIP][8] ([i915#1849] / [i915#2582])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@fbdev@info.html
- bat-kbl-2: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1849])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@fbdev@info.html
* igt@fbdev@write:
- bat-rpls-1: NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@fbdev@write.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +3 other tests skip
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-kbl-2: NOTRUN -> [SKIP][13] ([fdo#109271]) +24 other tests skip
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- bat-rpls-1: NOTRUN -> [SKIP][14] ([i915#4613]) +3 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@gem_lmem_swapping@random-engines.html
* igt@gem_mmap@basic:
- bat-dg2-9: NOTRUN -> [SKIP][15] ([i915#4083])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg2-9: NOTRUN -> [SKIP][16] ([i915#4077]) +2 other tests skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_mmap_gtt@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-dg2-9: NOTRUN -> [SKIP][17] ([i915#4079]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-rpls-1: NOTRUN -> [SKIP][18] ([i915#3282])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@gem_tiled_pread_basic.html
* igt@i915_pm_rps@basic-api:
- bat-dg2-9: NOTRUN -> [SKIP][19] ([i915#6621])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@i915_pm_rps@basic-api.html
- bat-rpls-1: NOTRUN -> [SKIP][20] ([i915#6621])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][21] ([i915#1886])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][22] ([i915#9527])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@mman:
- bat-rpls-1: NOTRUN -> [TIMEOUT][23] ([i915#6794] / [i915#7392])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-1: NOTRUN -> [WARN][24] ([i915#8747])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][25] ([i915#5190])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][26] ([i915#4215] / [i915#5190])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@framebuffer-vs-set-tiling:
- bat-dg2-9: NOTRUN -> [SKIP][27] ([i915#4212]) +6 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg2-9: NOTRUN -> [SKIP][28] ([i915#4212] / [i915#5608])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-dg2-9: NOTRUN -> [SKIP][29] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- bat-rpls-1: NOTRUN -> [SKIP][30] ([i915#1845]) +17 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_dsc@dsc-basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][31] ([fdo#109271]) +9 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html
* igt@kms_flip@basic-flip-vs-modeset:
- bat-rpls-1: NOTRUN -> [SKIP][32] ([i915#3637]) +3 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_flip@basic-flip-vs-modeset.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg2-9: NOTRUN -> [SKIP][33] ([fdo#109285])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
- bat-rpls-1: NOTRUN -> [SKIP][34] ([fdo#109285])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-9: NOTRUN -> [SKIP][35] ([i915#5274])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-1: NOTRUN -> [SKIP][36] ([i915#1849])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-kbl-2: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#1845]) +14 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][38] -> [ABORT][39] ([i915#8668])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
* igt@kms_psr@cursor_plane_move:
- bat-rpls-1: NOTRUN -> [SKIP][40] ([i915#1072]) +3 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg2-9: NOTRUN -> [SKIP][41] ([i915#1072]) +3 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg2-9: NOTRUN -> [SKIP][42] ([i915#3555] / [i915#4098])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
- bat-rpls-1: NOTRUN -> [SKIP][43] ([i915#3555])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg2-9: NOTRUN -> [SKIP][44] ([i915#3708])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
- bat-rpls-1: NOTRUN -> [SKIP][45] ([fdo#109295] / [i915#1845] / [i915#3708])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg2-9: NOTRUN -> [SKIP][46] ([i915#3708] / [i915#4077]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-write:
- bat-dg2-9: NOTRUN -> [SKIP][47] ([i915#3291] / [i915#3708]) +2 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-write.html
- bat-rpls-1: NOTRUN -> [SKIP][48] ([fdo#109295] / [i915#3708]) +2 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@kms_psr@sprite_plane_onoff:
- bat-jsl-3: [SKIP][49] ([i915#9648]) -> [PASS][50] +3 other tests pass
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8747]: https://gitlab.freedesktop.org/drm/intel/issues/8747
[i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
[i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
[i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
Build changes
-------------
* Linux: CI_DRM_13873 -> Patchwork_126385v1
CI-20190529: 20190529
CI_DRM_13873: 2b0a5e9915c131825481a9cc2aecb89088f51c00 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7587: bec435c24d23524d55f419a02af375e84c9be9d3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_126385v1: 2b0a5e9915c131825481a9cc2aecb89088f51c00 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
6b271f2baa33 drm/i915: do not clean GT table on error path
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/index.html
[-- Attachment #2: Type: text/html, Size: 18643 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: do not clean GT table on error path
2023-11-14 16:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-11-14 18:11 ` Andrzej Hajda
0 siblings, 0 replies; 7+ messages in thread
From: Andrzej Hajda @ 2023-11-14 18:11 UTC (permalink / raw)
To: intel-gfx, LGCI Bug Filing
[-- Attachment #1: Type: text/plain, Size: 17704 bytes --]
On 14.11.2023 17:30, Patchwork wrote:
> Project List - Patchwork *Patch Details*
> *Series:* drm/i915: do not clean GT table on error path
> *URL:* https://patchwork.freedesktop.org/series/126385/
> *State:* failure
> *Details:*
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/index.html
>
>
> CI Bug Log - changes from CI_DRM_13873 -> Patchwork_126385v1
>
>
> Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_126385v1 absolutely need
> to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_126385v1, please notify your bug team
> (lgci.bug.filing@intel.com) to allow them
> to document this new failure mode, which will reduce false positives
> in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/index.html
>
>
> Participating hosts (37 -> 39)
>
> Additional (4): fi-kbl-soraka bat-rpls-1 bat-kbl-2 bat-dg2-9
> Missing (2): fi-snb-2520m fi-pnv-d510
>
>
> Possible new issues
>
> Here are the unknown changes that may have been introduced in
> Patchwork_126385v1:
>
>
> IGT changes
>
>
> Possible regressions
>
> *
>
> igt@i915_selftest@live@workarounds:
>
> o bat-adlp-9: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-adlp-9/igt@i915_selftest@live@workarounds.html>
> -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-adlp-9/igt@i915_selftest@live@workarounds.html>
>
Known error [1].
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13844/bat-rpls-1/igt@i915_selftest@live@workarounds.html
> *
> *
>
> igt@i915_suspend@basic-s2idle-without-i915:
>
> o bat-atsm-1: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-atsm-1/igt@i915_suspend@basic-s2idle-without-i915.html>
> -> WARN
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-atsm-1/igt@i915_suspend@basic-s2idle-without-i915.html>
>
Known issue [2].
@BUG filing, please update the filters.
[2]: https://gitlab.freedesktop.org/drm/intel/-/issues/8715
Regards
Andrzej
> *
>
>
> Known issues
>
> Here are the changes found in Patchwork_126385v1 that come from known
> issues:
>
>
> CI changes
>
>
> Issues hit
>
> * boot:
> o bat-jsl-1: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-jsl-1/boot.html>
> -> FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-jsl-1/boot.html>
> (i915#8293 <https://gitlab.freedesktop.org/drm/intel/issues/8293>)
>
>
> IGT changes
>
>
> Issues hit
>
> *
>
> igt@debugfs_test@basic-hwmon:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@debugfs_test@basic-hwmon.html>
> (i915#9318 <https://gitlab.freedesktop.org/drm/intel/issues/9318>)
> *
>
> igt@fbdev@info:
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@fbdev@info.html>
> (i915#1849
> <https://gitlab.freedesktop.org/drm/intel/issues/1849> /
> i915#2582 <https://gitlab.freedesktop.org/drm/intel/issues/2582>)
>
> o
>
> bat-kbl-2: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@fbdev@info.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#1849 <https://gitlab.freedesktop.org/drm/intel/issues/1849>)
>
> *
>
> igt@fbdev@write:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@fbdev@write.html>
> (i915#2582
> <https://gitlab.freedesktop.org/drm/intel/issues/2582>) +3
> other tests skip
> *
>
> igt@gem_huc_copy@huc-copy:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>)
> *
>
> igt@gem_lmem_swapping@basic:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#4613
> <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3
> other tests skip
> *
>
> igt@gem_lmem_swapping@parallel-random-engines:
>
> o bat-kbl-2: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +24
> other tests skip
> *
>
> igt@gem_lmem_swapping@random-engines:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@gem_lmem_swapping@random-engines.html>
> (i915#4613
> <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3
> other tests skip
> *
>
> igt@gem_mmap@basic:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_mmap@basic.html>
> (i915#4083 <https://gitlab.freedesktop.org/drm/intel/issues/4083>)
> *
>
> igt@gem_mmap_gtt@basic:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_mmap_gtt@basic.html>
> (i915#4077
> <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2
> other tests skip
> *
>
> igt@gem_render_tiled_blits@basic:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@gem_render_tiled_blits@basic.html>
> (i915#4079
> <https://gitlab.freedesktop.org/drm/intel/issues/4079>) +1
> other test skip
> *
>
> igt@gem_tiled_pread_basic:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@gem_tiled_pread_basic.html>
> (i915#3282 <https://gitlab.freedesktop.org/drm/intel/issues/3282>)
> *
>
> igt@i915_pm_rps@basic-api:
>
> o
>
> bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@i915_pm_rps@basic-api.html>
> (i915#6621 <https://gitlab.freedesktop.org/drm/intel/issues/6621>)
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_pm_rps@basic-api.html>
> (i915#6621 <https://gitlab.freedesktop.org/drm/intel/issues/6621>)
>
> *
>
> igt@i915_selftest@live@gt_pm:
>
> o fi-kbl-soraka: NOTRUN -> DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html>
> (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>)
> *
>
> igt@i915_selftest@live@hangcheck:
>
> o fi-kbl-soraka: NOTRUN -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@i915_selftest@live@hangcheck.html>
> (i915#9527 <https://gitlab.freedesktop.org/drm/intel/issues/9527>)
> *
>
> igt@i915_selftest@live@mman:
>
> o bat-rpls-1: NOTRUN -> TIMEOUT
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_selftest@live@mman.html>
> (i915#6794
> <https://gitlab.freedesktop.org/drm/intel/issues/6794> /
> i915#7392 <https://gitlab.freedesktop.org/drm/intel/issues/7392>)
> *
>
> igt@i915_suspend@basic-s2idle-without-i915:
>
> o bat-rpls-1: NOTRUN -> WARN
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html>
> (i915#8747 <https://gitlab.freedesktop.org/drm/intel/issues/8747>)
> *
>
> igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html>
> (i915#5190 <https://gitlab.freedesktop.org/drm/intel/issues/5190>)
> *
>
> igt@kms_addfb_basic@basic-y-tiled-legacy:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html>
> (i915#4215
> <https://gitlab.freedesktop.org/drm/intel/issues/4215> /
> i915#5190 <https://gitlab.freedesktop.org/drm/intel/issues/5190>)
> *
>
> igt@kms_addfb_basic@framebuffer-vs-set-tiling:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html>
> (i915#4212
> <https://gitlab.freedesktop.org/drm/intel/issues/4212>) +6
> other tests skip
> *
>
> igt@kms_addfb_basic@tile-pitch-mismatch:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html>
> (i915#4212
> <https://gitlab.freedesktop.org/drm/intel/issues/4212> /
> i915#5608 <https://gitlab.freedesktop.org/drm/intel/issues/5608>)
> *
>
> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html>
> (i915#4103
> <https://gitlab.freedesktop.org/drm/intel/issues/4103> /
> i915#4213
> <https://gitlab.freedesktop.org/drm/intel/issues/4213> /
> i915#5608
> <https://gitlab.freedesktop.org/drm/intel/issues/5608>) +1
> other test skip
> *
>
> igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html>
> (i915#1845
> <https://gitlab.freedesktop.org/drm/intel/issues/1845>) +17
> other tests skip
> *
>
> igt@kms_dsc@dsc-basic:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +9
> other tests skip
> *
>
> igt@kms_flip@basic-flip-vs-modeset:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_flip@basic-flip-vs-modeset.html>
> (i915#3637
> <https://gitlab.freedesktop.org/drm/intel/issues/3637>) +3
> other tests skip
> *
>
> igt@kms_force_connector_basic@force-load-detect:
>
> o
>
> bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html>
> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_force_connector_basic@force-load-detect.html>
> (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>)
>
> *
>
> igt@kms_force_connector_basic@prune-stale-modes:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html>
> (i915#5274 <https://gitlab.freedesktop.org/drm/intel/issues/5274>)
> *
>
> igt@kms_frontbuffer_tracking@basic:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html>
> (i915#1849 <https://gitlab.freedesktop.org/drm/intel/issues/1849>)
> *
>
> igt@kms_pipe_crc_basic@read-crc-frame-sequence:
>
> o bat-kbl-2: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-kbl-2/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#1845
> <https://gitlab.freedesktop.org/drm/intel/issues/1845>) +14
> other tests skip
> *
>
> igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
>
> o bat-rplp-1: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html>
> -> ABORT
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html>
> (i915#8668 <https://gitlab.freedesktop.org/drm/intel/issues/8668>)
> *
>
> igt@kms_psr@cursor_plane_move:
>
> o bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_psr@cursor_plane_move.html>
> (i915#1072
> <https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3
> other tests skip
> *
>
> igt@kms_psr@sprite_plane_onoff:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_psr@sprite_plane_onoff.html>
> (i915#1072
> <https://gitlab.freedesktop.org/drm/intel/issues/1072>) +3
> other tests skip
> *
>
> igt@kms_setmode@basic-clone-single-crtc:
>
> o
>
> bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html>
> (i915#3555
> <https://gitlab.freedesktop.org/drm/intel/issues/3555> /
> i915#4098 <https://gitlab.freedesktop.org/drm/intel/issues/4098>)
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@kms_setmode@basic-clone-single-crtc.html>
> (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>)
>
> *
>
> igt@prime_vgem@basic-fence-flip:
>
> o
>
> bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html>
> (i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708>)
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@prime_vgem@basic-fence-flip.html>
> (fdo#109295
> <https://bugs.freedesktop.org/show_bug.cgi?id=109295> /
> i915#1845
> <https://gitlab.freedesktop.org/drm/intel/issues/1845> /
> i915#3708 <https://gitlab.freedesktop.org/drm/intel/issues/3708>)
>
> *
>
> igt@prime_vgem@basic-fence-mmap:
>
> o bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html>
> (i915#3708
> <https://gitlab.freedesktop.org/drm/intel/issues/3708> /
> i915#4077
> <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1
> other test skip
> *
>
> igt@prime_vgem@basic-write:
>
> o
>
> bat-dg2-9: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-dg2-9/igt@prime_vgem@basic-write.html>
> (i915#3291
> <https://gitlab.freedesktop.org/drm/intel/issues/3291> /
> i915#3708
> <https://gitlab.freedesktop.org/drm/intel/issues/3708>) +2
> other tests skip
>
> o
>
> bat-rpls-1: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-rpls-1/igt@prime_vgem@basic-write.html>
> (fdo#109295
> <https://bugs.freedesktop.org/show_bug.cgi?id=109295> /
> i915#3708
> <https://gitlab.freedesktop.org/drm/intel/issues/3708>) +2
> other tests skip
>
>
> Possible fixes
>
> * igt@kms_psr@sprite_plane_onoff:
> o bat-jsl-3: SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13873/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html>
> (i915#9648
> <https://gitlab.freedesktop.org/drm/intel/issues/9648>) ->
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v1/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html>
> +3 other tests pass
>
> {name}: This element is suppressed. This means it is ignored when
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
> Build changes
>
> * Linux: CI_DRM_13873 -> Patchwork_126385v1
>
> CI-20190529: 20190529
> CI_DRM_13873: 2b0a5e9915c131825481a9cc2aecb89088f51c00 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7587: bec435c24d23524d55f419a02af375e84c9be9d3 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_126385v1: 2b0a5e9915c131825481a9cc2aecb89088f51c00 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> Linux commits
>
> 6b271f2baa33 drm/i915: do not clean GT table on error path
>
[-- Attachment #2: Type: text/html, Size: 27745 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: do not clean GT table on error path (rev2)
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
2023-11-14 16:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-11-14 16:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-11-15 1:05 ` Patchwork
2023-11-15 1:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-15 9:04 ` [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Tvrtko Ursulin
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2023-11-15 1:05 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: do not clean GT table on error path (rev2)
URL : https://patchwork.freedesktop.org/series/126385/
State : warning
== Summary ==
Error: dim checkpatch failed
0e75a4af93e7 drm/i915: do not clean GT table on error path
-:14: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#14:
BUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()
-:27: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: bec68cc9ea42 ("drm/i915: Prepare for multiple GTs")'
#27:
Fixes: bec68cc9ea42d8 ("drm/i915: Prepare for multiple GTs")
total: 0 errors, 2 warnings, 0 checks, 16 lines checked
^ permalink raw reply [flat|nested] 7+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: do not clean GT table on error path (rev2)
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
` (2 preceding siblings ...)
2023-11-15 1:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: do not clean GT table on error path (rev2) Patchwork
@ 2023-11-15 1:25 ` Patchwork
2023-11-15 9:04 ` [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Tvrtko Ursulin
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2023-11-15 1:25 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8542 bytes --]
== Series Details ==
Series: drm/i915: do not clean GT table on error path (rev2)
URL : https://patchwork.freedesktop.org/series/126385/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13875 -> Patchwork_126385v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/index.html
Participating hosts (39 -> 40)
------------------------------
Additional (2): fi-kbl-soraka fi-pnv-d510
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_126385v2 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-bsw-n3050: [PASS][1] -> [FAIL][2] ([i915#8293])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/fi-bsw-n3050/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-bsw-n3050/boot.html
#### Possible fixes ####
* boot:
- fi-hsw-4770: [FAIL][3] ([i915#8293]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/fi-hsw-4770/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-hsw-4770/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg2-9: [PASS][5] -> [INCOMPLETE][6] ([i915#9275])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][10] ([i915#9527])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-soraka/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][11] ([i915#9527])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-hsw-4770/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-atsm-1: NOTRUN -> [SKIP][12] ([i915#6645])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-atsm-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-hsw-4770: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#5190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_dsc@dsc-basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271]) +9 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
- fi-hsw-4770: NOTRUN -> [SKIP][15] ([fdo#109271]) +12 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-atsm-1: NOTRUN -> [SKIP][16] ([i915#1836])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-atsm-1/igt@kms_pipe_crc_basic@suspend-read-crc.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][17] ([fdo#109271]) +29 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-jsl-3: [PASS][18] -> [SKIP][19] ([i915#9648]) +3 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-jsl-3/igt@kms_psr@sprite_plane_onoff.html
- fi-hsw-4770: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#1072]) +3 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
#### Possible fixes ####
* igt@i915_selftest@live@gem_contexts:
- bat-atsm-1: [INCOMPLETE][21] ([i915#9174]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/bat-atsm-1/igt@i915_selftest@live@gem_contexts.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-atsm-1/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][23] ([i915#5334]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_flip@basic-flip-vs-modeset@d-dp5:
- bat-adlp-11: [DMESG-FAIL][25] ([i915#6868]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@d-dp5.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-adlp-11/igt@kms_flip@basic-flip-vs-modeset@d-dp5.html
* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [FAIL][27] ([IGT#3]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_psr@primary_mmap_gtt:
- bat-jsl-1: [SKIP][29] ([i915#9648]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13875/bat-jsl-1/igt@kms_psr@primary_mmap_gtt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/bat-jsl-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
[i915#9174]: https://gitlab.freedesktop.org/drm/intel/issues/9174
[i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
[i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
[i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
Build changes
-------------
* Linux: CI_DRM_13875 -> Patchwork_126385v2
CI-20190529: 20190529
CI_DRM_13875: 00536be456cfe5f687c0e782f8dfba7db666d89b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7588: 328c5873b8f061267fdf86ed32cb5ecc611ba081 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_126385v2: 00536be456cfe5f687c0e782f8dfba7db666d89b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f76c7aed2e7a drm/i915: do not clean GT table on error path
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_126385v2/index.html
[-- Attachment #2: Type: text/html, Size: 10142 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
` (3 preceding siblings ...)
2023-11-15 1:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-11-15 9:04 ` Tvrtko Ursulin
4 siblings, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2023-11-15 9:04 UTC (permalink / raw)
To: Andrzej Hajda, intel-gfx; +Cc: Matthew Auld, Tvrtko Ursulin
On 14/11/2023 09:48, Andrzej Hajda wrote:
> The only task of intel_gt_release_all is to zero gt table. Calling
> it on error path prevents intel_gt_driver_late_release_all (called from
> i915_driver_late_release) to cleanup GTs, causing leakage.
> After i915_driver_late_release GT array is not used anymore so
> it does not need cleaning at all.
>
> Sample leak report:
>
> BUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()
> ...
> Object 0xffff888113420040 @offset=64
> Allocated in __i915_request_create+0x75/0x610 [i915] age=18339 cpu=1 pid=1454
> kmem_cache_alloc+0x25b/0x270
> __i915_request_create+0x75/0x610 [i915]
> i915_request_create+0x109/0x290 [i915]
> __engines_record_defaults+0xca/0x440 [i915]
> intel_gt_init+0x275/0x430 [i915]
> i915_gem_init+0x135/0x2c0 [i915]
> i915_driver_probe+0x8d1/0xdc0 [i915]
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8489
> Fixes: bec68cc9ea42d8 ("drm/i915: Prepare for multiple GTs")
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index 80e85cadb9a262..428ace0bebaac9 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -782,7 +782,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> ret = i915_driver_mmio_probe(i915);
> if (ret < 0)
> - goto out_tiles_cleanup;
> + goto out_runtime_pm_put;
>
> ret = i915_driver_hw_probe(i915);
> if (ret < 0)
> @@ -842,8 +842,6 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> i915_ggtt_driver_late_release(i915);
> out_cleanup_mmio:
> i915_driver_mmio_release(i915);
> -out_tiles_cleanup:
> - intel_gt_release_all(i915);
There is also a call on error path from intel_gt_probe_all. Shouldn't
that also go?
At which points intel_gt_release_all will have no callers. Fold it into
intel_gt_driver_late_release_all or don't bother zeroing?
Regards,
Tvrtko
> out_runtime_pm_put:
> enable_rpm_wakeref_asserts(&i915->runtime_pm);
> i915_driver_late_release(i915);
>
> ---
> base-commit: c6f47b4817ee55a02359c3347a298876cfa93b0e
> change-id: 20231114-dont_clean_gt_on_error_path-91cd9c3caa0a
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-11-15 9:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-14 9:48 [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Andrzej Hajda
2023-11-14 16:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-11-14 16:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-14 18:11 ` Andrzej Hajda
2023-11-15 1:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: do not clean GT table on error path (rev2) Patchwork
2023-11-15 1:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-15 9:04 ` [Intel-gfx] [PATCH] drm/i915: do not clean GT table on error path Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.