* Neil, where are your Patches !
@ 2006-03-15 13:10 Francois Barre
2006-03-16 23:11 ` Neil Brown
0 siblings, 1 reply; 6+ messages in thread
From: Francois Barre @ 2006-03-15 13:10 UTC (permalink / raw)
To: linux-raid
Hi All,
I digged the net over and over, but no way. I could not find any place
where current patches to md are stored, like the raid5 resize stuff...
Yes, I know, I could copy/paste them from the mail archives, but it's
crappy (especially with gmail), and it's sure I'll skip some...
So, where are they hidding ? I can't believe that an efficient
organization such as http://cgi.cse.unsw.edu.au/~neilb/patches/ is not
available anymore...
Or maybe there's a git tree somewhere ?
Best regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Neil, where are your Patches !
2006-03-15 13:10 Neil, where are your Patches ! Francois Barre
@ 2006-03-16 23:11 ` Neil Brown
2006-03-17 11:10 ` Neil Brown
0 siblings, 1 reply; 6+ messages in thread
From: Neil Brown @ 2006-03-16 23:11 UTC (permalink / raw)
To: Francois Barre; +Cc: linux-raid
On Wednesday March 15, francois.barre@gmail.com wrote:
> Hi All,
>
> I digged the net over and over, but no way. I could not find any place
> where current patches to md are stored, like the raid5 resize stuff...
> Yes, I know, I could copy/paste them from the mail archives, but it's
> crappy (especially with gmail), and it's sure I'll skip some...
>
> So, where are they hidding ? I can't believe that an efficient
> organization such as http://cgi.cse.unsw.edu.au/~neilb/patches/ is not
> available anymore...
Hmmm.... I thought the appeared somewhere automatically, but they
don't seem to, do they.... I'll try to sort something out later today.
>
> Or maybe there's a git tree somewhere ?
No, I'm not a git convert yet. I have a little script for managing
patches which works quite nicely and does all that I need (Except
export them...)
NeilBrown
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Neil, where are your Patches !
2006-03-16 23:11 ` Neil Brown
@ 2006-03-17 11:10 ` Neil Brown
2006-03-17 12:30 ` Francois Barre
0 siblings, 1 reply; 6+ messages in thread
From: Neil Brown @ 2006-03-17 11:10 UTC (permalink / raw)
To: Francois Barre, linux-raid
On Friday March 17, neilb@suse.de wrote:
> >
> > So, where are they hidding ? I can't believe that an efficient
> > organization such as http://cgi.cse.unsw.edu.au/~neilb/patches/ is not
> > available anymore...
>
> Hmmm.... I thought the appeared somewhere automatically, but they
> don't seem to, do they.... I'll try to sort something out later today.
>
Ok, look again, under
http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/
NeilBrown
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Neil, where are your Patches !
2006-03-17 11:10 ` Neil Brown
@ 2006-03-17 12:30 ` Francois Barre
2006-03-18 9:31 ` Francois Barre
0 siblings, 1 reply; 6+ messages in thread
From: Francois Barre @ 2006-03-17 12:30 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
2006/3/17, Neil Brown <neilb@suse.de>:
> On Friday March 17, neilb@suse.de wrote:
> > >
> > > So, where are they hidding ? I can't believe that an efficient
> > > organization such as http://cgi.cse.unsw.edu.au/~neilb/patches/ is not
> > > available anymore...
> >
> > Hmmm.... I thought the appeared somewhere automatically, but they
> > don't seem to, do they.... I'll try to sort something out later today.
> >
>
> Ok, look again, under
> http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/
>
> NeilBrown
>
Oh thanks !
I'll try to (heavy?)-test the raid5 resize patch this week-end, as I
certainly have to use it on a production platfrom by the end of next
week.
If ever you have some special aspects to investigate, please let me
know about it.
Thanks for your work,
Best regards,
F.-E.B.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Neil, where are your Patches !
2006-03-17 12:30 ` Francois Barre
@ 2006-03-18 9:31 ` Francois Barre
2006-03-20 3:54 ` Neil Brown
0 siblings, 1 reply; 6+ messages in thread
From: Francois Barre @ 2006-03-18 9:31 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid
> > Ok, look again, under
> > http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/
> >
Early comments :
I tested with patch-all-2006-03-17-10 on top of 2.6.16-rc6-mm1.
I had two compilation issues :
* in include/linux/raid/md_k.h, external is not defined in mddev_s. I
supposed it was an int.
* in drivers/raid/md.c and include/linux/raid/md.h, md_do_sync is
confused, being declared static, but used in other places, like
raid5.c. I supposed it shall be declared non-static.
With these 2 modifications, compilation is ok.
Raid5 resize testing :
I tried using it with 4 loop devices, creating a 3 10Mb raid5 and adding a 4th.
- mdadm -C -n 3 -l 5 /dev/md1 /dev/loop[123] : no problem
- mdadm -a /dev/md1 /dev/loop4 : loop4 is a spare
- mdadm -G -n 4 /dev/md1 returns error, but nothing happens : the 4th
is not added, and stays as a spare. md1 is still accessible, no
problem about that.
I'll try of course to investigate more...
Regards,
F.-E.B.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Neil, where are your Patches !
2006-03-18 9:31 ` Francois Barre
@ 2006-03-20 3:54 ` Neil Brown
0 siblings, 0 replies; 6+ messages in thread
From: Neil Brown @ 2006-03-20 3:54 UTC (permalink / raw)
To: Francois Barre; +Cc: linux-raid
On Saturday March 18, francois.barre@gmail.com wrote:
> > > Ok, look again, under
> > > http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/
> > >
>
> Early comments :
> I tested with patch-all-2006-03-17-10 on top of 2.6.16-rc6-mm1.
> I had two compilation issues :
> * in include/linux/raid/md_k.h, external is not defined in mddev_s. I
> supposed it was an int.
>
> * in drivers/raid/md.c and include/linux/raid/md.h, md_do_sync is
> confused, being declared static, but used in other places, like
> raid5.c. I supposed it shall be declared non-static.
>
> With these 2 modifications, compilation is ok.
Yes... If you grabbed all the patches, it would have included some
that I haven't worked on for a while, and haven't tested recently
either...
I'll do another patch set in a day or so with these fixed up.
>
> Raid5 resize testing :
> I tried using it with 4 loop devices, creating a 3 10Mb raid5 and adding a 4th.
> - mdadm -C -n 3 -l 5 /dev/md1 /dev/loop[123] : no problem
> - mdadm -a /dev/md1 /dev/loop4 : loop4 is a spare
> - mdadm -G -n 4 /dev/md1 returns error, but nothing happens : the 4th
> is not added, and stays as a spare. md1 is still accessible, no
> problem about that.
That is deliberate. You need a new version of mdadm to use
raid5-reshape safely. A pre-release will be out soon.
NeilBrown
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-03-20 3:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-15 13:10 Neil, where are your Patches ! Francois Barre
2006-03-16 23:11 ` Neil Brown
2006-03-17 11:10 ` Neil Brown
2006-03-17 12:30 ` Francois Barre
2006-03-18 9:31 ` Francois Barre
2006-03-20 3:54 ` Neil Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.