From: Emrah Demir <ed@abdsec.com>
To: Kees Cook <keescook@chromium.org>
Cc: Pavel Machek <pavel@denx.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ingo Molnar <mingo@kernel.org>, James Morse <james.morse@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Redfearn <matt.redfearn@imgtec.com>,
Yves-Alexis Perez <corsac@debian.org>,
Jonathan Corbet <corbet@lwn.net>,
x86@kernel.org, Len Brown <len.brown@intel.com>,
Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
linux-doc@vger.kernel.org,
Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com, keescook@google.com
Subject: [kernel-hardening] Re: [PATCH v2] kaslr: allow kASLR to be default over Hibernation
Date: Fri, 15 Apr 2016 12:25:19 -0400 [thread overview]
Message-ID: <fd9b0950f40aaffbdaa30e9cf75a9e5b@abdsec.com> (raw)
In-Reply-To: <CAGXu5j+cTYF_OGG=u4BKU5X3f6TF0FdAcES9e_8S0ajMyjhn6Q@mail.gmail.com>
On 2016-04-14 18:42, Kees Cook wrote:
> On Thu, Apr 14, 2016 at 1:34 PM, Pavel Machek <pavel@denx.de> wrote:
>> On Thu 2016-04-14 13:14:07, Kees Cook wrote:
>>> On Thu, Apr 14, 2016 at 1:01 PM, Pavel Machek <pavel@denx.de> wrote:
>>> > Hi!
>>> >
>>> >> Since kASLR and Hibernation can not currently coexist at runtime
>>> >> on x86, the default behavior was to disable kASLR by default when
>>> >> CONFIG_HIBERNATION was present (to retain original behavior).
>>> >>
>>> >> The behavior of kASLR on arm64 (and soon MIPS) is to be enabled by
>>> >> default when selected at build time. Since arm64 Hibernation does not
>>> >> conflict with kASLR, this fixes the hibernation argument parsing to be
>>> >> x86-specific. Additionally, since end users want to be able to select
>>> >> kASLR on x86 by default at build time, create CONFIG_RANDOMIZE_BASE_ON
>>> >> that is present only on x86.
>>> >
>>> > I believe this is bad idea. arm64 shows that kaslr and hibernation can
>>> > coexist, and hibernation is still useful when your battery runs out.
>>>
>>> What? I'm confused -- this patch leaves the x86 behavior as-is by
>>> default but allows hibernation to work with arm64. (For example,
>>> right
>>> now, if you boot arm64 with "kaslr" kernel argument, hibernation will
>>> get needlessly disabled.)
>>
So what about making new kernel parameters. "hibernate" and
"nohibernate"
This way before decompression it will look at the parameters and depend
on parameters it will act differently
"kaslr" "nohibernate" --> kASLR will enable, no hibernate
"nokaslr" "nohibernate" --> Neither of them will work
"kaslr" "hiberante" ---> Owner has to face consequences(ARM has
advantages)
"nokaslr" "hibernate" ---> kASLR disabled and hibernate will works.
Before writing something I want to know your ideas.
-Emrah
WARNING: multiple messages have this Message-ID (diff)
From: Emrah Demir <ed@abdsec.com>
To: Kees Cook <keescook@chromium.org>
Cc: Pavel Machek <pavel@denx.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ingo Molnar <mingo@kernel.org>, James Morse <james.morse@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Matt Redfearn <matt.redfearn@imgtec.com>,
Yves-Alexis Perez <corsac@debian.org>,
Jonathan Corbet <corbet@lwn.net>,
x86@kernel.org, Len Brown <len.brown@intel.com>,
Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
linux-doc@vger.kernel.org,
Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com, keescook@google.com
Subject: Re: [PATCH v2] kaslr: allow kASLR to be default over Hibernation
Date: Fri, 15 Apr 2016 12:25:19 -0400 [thread overview]
Message-ID: <fd9b0950f40aaffbdaa30e9cf75a9e5b@abdsec.com> (raw)
In-Reply-To: <CAGXu5j+cTYF_OGG=u4BKU5X3f6TF0FdAcES9e_8S0ajMyjhn6Q@mail.gmail.com>
On 2016-04-14 18:42, Kees Cook wrote:
> On Thu, Apr 14, 2016 at 1:34 PM, Pavel Machek <pavel@denx.de> wrote:
>> On Thu 2016-04-14 13:14:07, Kees Cook wrote:
>>> On Thu, Apr 14, 2016 at 1:01 PM, Pavel Machek <pavel@denx.de> wrote:
>>> > Hi!
>>> >
>>> >> Since kASLR and Hibernation can not currently coexist at runtime
>>> >> on x86, the default behavior was to disable kASLR by default when
>>> >> CONFIG_HIBERNATION was present (to retain original behavior).
>>> >>
>>> >> The behavior of kASLR on arm64 (and soon MIPS) is to be enabled by
>>> >> default when selected at build time. Since arm64 Hibernation does not
>>> >> conflict with kASLR, this fixes the hibernation argument parsing to be
>>> >> x86-specific. Additionally, since end users want to be able to select
>>> >> kASLR on x86 by default at build time, create CONFIG_RANDOMIZE_BASE_ON
>>> >> that is present only on x86.
>>> >
>>> > I believe this is bad idea. arm64 shows that kaslr and hibernation can
>>> > coexist, and hibernation is still useful when your battery runs out.
>>>
>>> What? I'm confused -- this patch leaves the x86 behavior as-is by
>>> default but allows hibernation to work with arm64. (For example,
>>> right
>>> now, if you boot arm64 with "kaslr" kernel argument, hibernation will
>>> get needlessly disabled.)
>>
So what about making new kernel parameters. "hibernate" and
"nohibernate"
This way before decompression it will look at the parameters and depend
on parameters it will act differently
"kaslr" "nohibernate" --> kASLR will enable, no hibernate
"nokaslr" "nohibernate" --> Neither of them will work
"kaslr" "hiberante" ---> Owner has to face consequences(ARM has
advantages)
"nokaslr" "hibernate" ---> kASLR disabled and hibernate will works.
Before writing something I want to know your ideas.
-Emrah
next prev parent reply other threads:[~2016-04-15 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 22:16 [kernel-hardening] [PATCH v2] kaslr: allow kASLR to be default over Hibernation Kees Cook
2016-04-12 22:16 ` Kees Cook
2016-04-14 20:01 ` [kernel-hardening] " Pavel Machek
2016-04-14 20:01 ` Pavel Machek
2016-04-14 20:14 ` [kernel-hardening] " Kees Cook
2016-04-14 20:14 ` Kees Cook
2016-04-14 20:34 ` [kernel-hardening] " Pavel Machek
2016-04-14 20:34 ` Pavel Machek
2016-04-14 22:42 ` [kernel-hardening] " Kees Cook
2016-04-14 22:42 ` Kees Cook
2016-04-15 9:20 ` [kernel-hardening] " Ingo Molnar
2016-04-15 9:20 ` Ingo Molnar
2016-04-15 13:06 ` [kernel-hardening] " Pavel Machek
2016-04-15 13:06 ` Pavel Machek
2016-04-15 16:25 ` Emrah Demir [this message]
2016-04-15 16:25 ` Emrah Demir
2016-04-16 19:58 ` [kernel-hardening] " Pavel Machek
2016-04-16 19:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9b0950f40aaffbdaa30e9cf75a9e5b@abdsec.com \
--to=ed@abdsec.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=corsac@debian.org \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=keescook@google.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt.redfearn@imgtec.com \
--cc=mingo@kernel.org \
--cc=pavel@denx.de \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.