From: "Tan Nayır" <tannayir@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: ops: Fix the bounds checking in snd_soc_put_volsw_sx and snd_soc_put_xr_sx
Date: Tue, 17 May 2022 22:58:40 +0300 [thread overview]
Message-ID: <fde0dc8a-a861-3c8e-1316-cfa81affc19e@gmail.com> (raw)
In-Reply-To: <YoPnhDRMwoT42vS7@sirena.org.uk>
I've debugged the kernel again after applying the fix in
698813ba8c58 ("ASoC: ops: Fix bounds check for _sx controls")
but it didn't fix the problem.
The commit message in your fix states this:
> For _sx controls the semantics of the max field is not the usual one, max
> is the number of steps rather than the maximum value. This means that our
> check in snd_soc_put_volsw_sx() needs to just check against the maximum
> value.
For some reason, this is not the case on my end.
Both the $platform_max and $max fields are set to the maximum value
of the range that is specified inside the codec code which is -84 to 40
and not the number of steps.
This was also the reason behind my patch to the bounds check.
WARNING: multiple messages have this Message-ID (diff)
From: "Tan Nayır" <tannayir@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org,
Marek Vasut <marex@denx.de>
Subject: Re: [PATCH] ASoC: ops: Fix the bounds checking in snd_soc_put_volsw_sx and snd_soc_put_xr_sx
Date: Tue, 17 May 2022 22:58:40 +0300 [thread overview]
Message-ID: <fde0dc8a-a861-3c8e-1316-cfa81affc19e@gmail.com> (raw)
In-Reply-To: <YoPnhDRMwoT42vS7@sirena.org.uk>
I've debugged the kernel again after applying the fix in
698813ba8c58 ("ASoC: ops: Fix bounds check for _sx controls")
but it didn't fix the problem.
The commit message in your fix states this:
> For _sx controls the semantics of the max field is not the usual one, max
> is the number of steps rather than the maximum value. This means that our
> check in snd_soc_put_volsw_sx() needs to just check against the maximum
> value.
For some reason, this is not the case on my end.
Both the $platform_max and $max fields are set to the maximum value
of the range that is specified inside the codec code which is -84 to 40
and not the number of steps.
This was also the reason behind my patch to the bounds check.
next prev parent reply other threads:[~2022-05-17 19:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 13:06 [PATCH] ASoC: ops: Shift tested values in snd_soc_put_volsw() by +min Marek Vasut
2022-02-16 18:01 ` Mark Brown
2022-02-23 14:55 ` Takashi Iwai
2022-02-23 16:32 ` Mark Brown
2022-02-23 16:44 ` Takashi Iwai
2022-02-23 16:52 ` Marek Vasut
2022-02-23 16:52 ` Marek Vasut
2022-05-16 23:53 ` Tan N.
2022-05-16 23:53 ` Tan N.
2022-05-17 1:12 ` [PATCH] ASoC: ops: Fix the bounds checking in snd_soc_put_volsw_sx and snd_soc_put_xr_sx Tan Nayir
2022-05-17 1:12 ` Tan Nayir
2022-05-17 13:04 ` Mark Brown
2022-05-17 13:04 ` Mark Brown
2022-05-17 14:25 ` Tan Nayır
2022-05-17 14:25 ` Tan Nayır
2022-05-17 18:20 ` Mark Brown
2022-05-17 18:20 ` Mark Brown
2022-05-17 19:58 ` Tan Nayır [this message]
2022-05-17 19:58 ` Tan Nayır
2022-05-18 12:07 ` Mark Brown
2022-05-18 12:07 ` Mark Brown
2022-05-18 23:56 ` Tan Nayır
2022-05-18 23:56 ` Tan Nayır
2022-05-19 15:47 ` Mark Brown
2022-05-19 15:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde0dc8a-a861-3c8e-1316-cfa81affc19e@gmail.com \
--to=tannayir@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=marex@denx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.