All of lore.kernel.org
 help / color / mirror / Atom feed
* extending blkif_request_t
@ 2005-03-19  5:22 Deepak Manohar
  2005-03-19  7:04 ` Xin Zhao
  0 siblings, 1 reply; 3+ messages in thread
From: Deepak Manohar @ 2005-03-19  5:22 UTC (permalink / raw)
  To: xen-devel

Hi,

 I am sorry if this was asked earlier, but I couldnt find it. 

 If I want to pass another field in the structure blkif_request_t do I
simply add it to xen/include/public/io/blkif.h ?

 After doing this will the backend and the frontend be able to access
this field. Thanks.

Deepak


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: extending blkif_request_t
  2005-03-19  5:22 extending blkif_request_t Deepak Manohar
@ 2005-03-19  7:04 ` Xin Zhao
  2005-03-19 16:48   ` Mark Williamson
  0 siblings, 1 reply; 3+ messages in thread
From: Xin Zhao @ 2005-03-19  7:04 UTC (permalink / raw)
  To: Deepak Manohar; +Cc: xen-devel

If you need to add a new field to blkif_request_t, you might have to be
very careful, because the size of blkif_request_t and the blkif_ring_t are
carefully calibrated. If you add a new field, make it sure that the size
of blkif_ring_t will not exceed PAGE_SIZE. You may also change
blkif_ring_t to hold more request. That may take some more work.

Good luck,
Xin

On Sat, 19 Mar 2005, Deepak Manohar wrote:

> Hi,
>
>  I am sorry if this was asked earlier, but I couldnt find it.
>
>  If I want to pass another field in the structure blkif_request_t do I
> simply add it to xen/include/public/io/blkif.h ?
>
>  After doing this will the backend and the frontend be able to access
> this field. Thanks.
>
> Deepak
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel
>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: extending blkif_request_t
  2005-03-19  7:04 ` Xin Zhao
@ 2005-03-19 16:48   ` Mark Williamson
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Williamson @ 2005-03-19 16:48 UTC (permalink / raw)
  To: xen-devel; +Cc: Xin Zhao, Deepak Manohar

> If you need to add a new field to blkif_request_t, you might have to be
> very careful, because the size of blkif_request_t and the blkif_ring_t are
> carefully calibrated. If you add a new field, make it sure that the size
> of blkif_ring_t will not exceed PAGE_SIZE. You may also change
> blkif_ring_t to hold more request. That may take some more work.

Under the unstable tree it'll automatically sort itself out, since the blkif 
drivers use the magic ring macros in xen/include/public/io/ring.h - in that 
tree, the netif drivers are the only ones that don't use these ring macros at 
the moment.

Under the 2.0.x tree, you'll still have to sort out ring sizing issues 
manually.

When playing with these structures, don't forget to recompile both front and 
backend kernels, or things will get very confused!

Cheers,
Mark

> Good luck,
> Xin
>
> On Sat, 19 Mar 2005, Deepak Manohar wrote:
> > Hi,
> >
> >  I am sorry if this was asked earlier, but I couldnt find it.
> >
> >  If I want to pass another field in the structure blkif_request_t do I
> > simply add it to xen/include/public/io/blkif.h ?
> >
> >  After doing this will the backend and the frontend be able to access
> > this field. Thanks.
> >
> > Deepak
> >
> >
> > -------------------------------------------------------
> > SF email is sponsored by - The IT Product Guide
> > Read honest & candid reviews on hundreds of IT Products from real users.
> > Discover which products truly live up to the hype. Start reading now.
> > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/xen-devel
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xen-devel


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-03-19 16:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-19  5:22 extending blkif_request_t Deepak Manohar
2005-03-19  7:04 ` Xin Zhao
2005-03-19 16:48   ` Mark Williamson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.