All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: "Noralf Trønnes" <noralf@tronnes.org>, linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion
Date: Thu, 24 Feb 2022 15:13:31 +0100	[thread overview]
Message-ID: <fe202ad8-3035-6ff0-e298-8228c6aa61bb@redhat.com> (raw)
In-Reply-To: <af865ac6-0353-0004-dec2-f227ee8bb01d@tronnes.org>

Hello Noralf,

On 2/24/22 15:04, Noralf Trønnes wrote:
> 
> 
> Den 23.02.2022 20.37, skrev Javier Martinez Canillas:
>> There is now a drm_fb_xrgb8888_to_mono_reversed() helper function to do
>> format conversion from XRGB8888 to reversed monochrome.
>>
>> Use that helper and remove the open coded version in the repaper driver.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
> 
> Tested-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
>

Thanks a lot for testing and for your review.
 
> Do you have commit rights and will apply this patch?
>

Yes, I do. Can apply this later today.

Best regards, -- 
Javier Martinez Canillas
Linux Engineering
Red Hat


WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: "Noralf Trønnes" <noralf@tronnes.org>, linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion
Date: Thu, 24 Feb 2022 15:13:31 +0100	[thread overview]
Message-ID: <fe202ad8-3035-6ff0-e298-8228c6aa61bb@redhat.com> (raw)
In-Reply-To: <af865ac6-0353-0004-dec2-f227ee8bb01d@tronnes.org>

Hello Noralf,

On 2/24/22 15:04, Noralf Trønnes wrote:
> 
> 
> Den 23.02.2022 20.37, skrev Javier Martinez Canillas:
>> There is now a drm_fb_xrgb8888_to_mono_reversed() helper function to do
>> format conversion from XRGB8888 to reversed monochrome.
>>
>> Use that helper and remove the open coded version in the repaper driver.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
> 
> Tested-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
>

Thanks a lot for testing and for your review.
 
> Do you have commit rights and will apply this patch?
>

Yes, I do. Can apply this later today.

Best regards, -- 
Javier Martinez Canillas
Linux Engineering
Red Hat


  reply	other threads:[~2022-02-24 14:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 19:37 [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion Javier Martinez Canillas
2022-02-23 19:37 ` Javier Martinez Canillas
2022-02-23 19:40 ` Thomas Zimmermann
2022-02-23 19:40   ` Thomas Zimmermann
2022-02-24 14:04 ` Noralf Trønnes
2022-02-24 14:04   ` Noralf Trønnes
2022-02-24 14:13   ` Javier Martinez Canillas [this message]
2022-02-24 14:13     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe202ad8-3035-6ff0-e298-8228c6aa61bb@redhat.com \
    --to=javierm@redhat.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.