From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mark Yao" <markyao0591@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@collabora.com, Alexandre ARNOUD <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v2 2/3] drm/rockchip: Explicitly include bits header
Date: Thu, 1 Aug 2024 16:45:36 +0200 [thread overview]
Message-ID: <fe49a89e-324c-4755-8350-cb6f7b3323d9@kernel.org> (raw)
In-Reply-To: <20240801-b4-rk3588-bridge-upstream-v2-2-9fa657a4e15b@collabora.com>
On 01/08/2024 04:25, Cristian Ciocaltea wrote:
> Driver makes use of the BIT() macro, but relies on the bits header being
> implicitly included.
>
> Explicitly pull the header in to avoid potential build failures in some
> configurations.
>
> While at it, reorder include directives alphabetically.
>
> Fixes: 8c8546546f25 ("drm/rockchip: move output interface related definition to rockchip_drm_drv.h")
There is no bug here to be fixed. Drop. Especially bugfixes should not
be combined with cleanups.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Mark Yao" <markyao0591@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@collabora.com, Alexandre ARNOUD <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v2 2/3] drm/rockchip: Explicitly include bits header
Date: Thu, 1 Aug 2024 16:45:36 +0200 [thread overview]
Message-ID: <fe49a89e-324c-4755-8350-cb6f7b3323d9@kernel.org> (raw)
In-Reply-To: <20240801-b4-rk3588-bridge-upstream-v2-2-9fa657a4e15b@collabora.com>
On 01/08/2024 04:25, Cristian Ciocaltea wrote:
> Driver makes use of the BIT() macro, but relies on the bits header being
> implicitly included.
>
> Explicitly pull the header in to avoid potential build failures in some
> configurations.
>
> While at it, reorder include directives alphabetically.
>
> Fixes: 8c8546546f25 ("drm/rockchip: move output interface related definition to rockchip_drm_drv.h")
There is no bug here to be fixed. Drop. Especially bugfixes should not
be combined with cleanups.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-01 14:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 2:25 [PATCH v2 0/3] Add initial support for the Rockchip RK3588 HDMI TX Controller Cristian Ciocaltea
2024-08-01 2:25 ` Cristian Ciocaltea
2024-08-01 2:25 ` [PATCH v2 1/3] dt-bindings: display: rockchip: Add schema for " Cristian Ciocaltea
2024-08-01 2:25 ` Cristian Ciocaltea
2024-08-01 3:37 ` Rob Herring (Arm)
2024-08-01 3:37 ` Rob Herring (Arm)
2024-08-01 3:37 ` Rob Herring (Arm)
2024-08-01 9:50 ` Cristian Ciocaltea
2024-08-01 9:50 ` Cristian Ciocaltea
2024-08-01 14:44 ` Krzysztof Kozlowski
2024-08-01 14:44 ` Krzysztof Kozlowski
2024-08-01 2:25 ` [PATCH v2 2/3] drm/rockchip: Explicitly include bits header Cristian Ciocaltea
2024-08-01 2:25 ` Cristian Ciocaltea
2024-08-01 14:45 ` Krzysztof Kozlowski [this message]
2024-08-01 14:45 ` Krzysztof Kozlowski
2024-08-01 2:25 ` [PATCH v2 3/3] drm/rockchip: Add basic RK3588 HDMI output support Cristian Ciocaltea
2024-08-01 2:25 ` Cristian Ciocaltea
2024-08-09 20:48 ` kernel test robot
2024-08-09 20:48 ` kernel test robot
2024-08-09 21:09 ` kernel test robot
2024-08-09 21:09 ` kernel test robot
2024-08-03 13:24 ` [PATCH v2 0/3] Add initial support for the Rockchip RK3588 HDMI TX Controller Piotr Oniszczuk
2024-08-03 13:24 ` Piotr Oniszczuk
2024-08-05 16:20 ` Chris Morgan
2024-08-05 16:20 ` Chris Morgan
2024-08-05 16:31 ` Piotr Oniszczuk
2024-08-05 16:31 ` Piotr Oniszczuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe49a89e-324c-4755-8350-cb6f7b3323d9@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aarnoud@me.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=ldearquer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.