From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
David Rhodes <david.rhodes@cirrus.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
Vlad Karpovich <vkarpovi@opensource.cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: cs4265: sort the register default table
Date: Wed, 5 Aug 2026 12:31:16 +0100 [thread overview]
Message-ID: <fe70c982-5608-4e72-84af-92fe585fec0a@opensource.cirrus.com> (raw)
In-Reply-To: <20260805082413.26174-4-peter.ujfalusi@linux.intel.com>
On 05/08/2026 9:24 am, Peter Ujfalusi wrote:
> reg_defaults must be sorted by ascending register address, as
> regcache_lookup_reg() locates entries in it with bsearch(). See commit
> fd80df352ba1 ("regcache: Add support for sorting defaults arrays").
>
> cs4265_reg_defaults[] lists CS4265_INT_MASK (0x0e),
> CS4265_STATUS_MODE_MSB (0x0f) and CS4265_STATUS_MODE_LSB (0x10) after
> CS4265_SPDIF_CTL1 (0x11) and CS4265_SPDIF_CTL2 (0x12), so the binary search
> does not find those three entries. regcache_reg_needs_sync() then cannot
> compare them against their default and reports that a sync is needed, so
> they are written to the device on every regcache_sync() even when they were
> never touched.
>
> Sort the table by register address.
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
next prev parent reply other threads:[~2026-08-05 11:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 8:24 [PATCH 0/3] ASoC: cs35l41/cs35l45/cs4265: sort the reg_defaults tables Peter Ujfalusi
2026-08-05 8:24 ` [PATCH 1/3] ASoC: cs35l41: sort the register default table Peter Ujfalusi
2026-08-05 9:58 ` Richard Fitzgerald
2026-08-05 8:24 ` [PATCH 2/3] ASoC: cs35l45: " Peter Ujfalusi
2026-08-05 11:35 ` Richard Fitzgerald
2026-08-05 8:24 ` [PATCH 3/3] ASoC: cs4265: " Peter Ujfalusi
2026-08-05 11:31 ` Richard Fitzgerald [this message]
2026-08-05 8:40 ` [PATCH 0/3] ASoC: cs35l41/cs35l45/cs4265: sort the reg_defaults tables Pierre-Louis Bossart
2026-08-05 8:52 ` Péter Ujfalusi
2026-08-05 8:59 ` Pierre-Louis Bossart
2026-08-05 9:00 ` Richard Fitzgerald
2026-08-05 9:10 ` Péter Ujfalusi
2026-08-05 9:25 ` Charles Keepax
2026-08-05 9:38 ` Richard Fitzgerald
2026-08-05 9:52 ` Charles Keepax
2026-08-05 9:52 ` Péter Ujfalusi
2026-08-05 9:56 ` Richard Fitzgerald
2026-08-05 9:59 ` Péter Ujfalusi
2026-08-05 10:10 ` Charles Keepax
2026-08-05 10:17 ` Péter Ujfalusi
2026-08-05 10:36 ` Richard Fitzgerald
2026-08-05 11:25 ` Péter Ujfalusi
2026-08-05 11:31 ` Charles Keepax
2026-08-05 11:38 ` Richard Fitzgerald
2026-08-05 11:38 ` Péter Ujfalusi
2026-08-05 9:25 ` Péter Ujfalusi
2026-08-05 10:38 ` Mark Brown
2026-08-05 8:59 ` Charles Keepax
2026-08-05 12:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe70c982-5608-4e72-84af-92fe585fec0a@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=vkarpovi@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.