From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH v3] nvmet-rdma: fix null dereference under heavy load
Date: Mon, 21 Jan 2019 15:07:09 +0200 [thread overview]
Message-ID: <fe7da170-9eea-360d-0ab7-84838b6debac@mellanox.com> (raw)
In-Reply-To: <ed249f9f-44f8-de1f-ba7e-1179317803d8@grimberg.me>
On 1/21/2019 11:10 AM, Sagi Grimberg wrote:
>> This looks ok to me:
>>
>> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> Applied to nvme-5.0
>
>> In the long run I wonder if we should get rid of the ?tatic
>> preallocation entirely and just use a free pool to avoid constant
>> reallocations..
>
> you mean a kmem_cache? very possible, we can also make the command
> struct to contain the rsp behind it to avoid the extra allocation...
yes, the container idea sounds good..
WARNING: multiple messages have this Message-ID (diff)
From: Max Gurtovoy <maxg@mellanox.com>
To: Sagi Grimberg <sagi@grimberg.me>,
Christoph Hellwig <hch@infradead.org>,
Raju Rangoju <rajur@chelsio.com>
Cc: <stable@vger.kernel.org>, <swise@opengridcomputing.com>,
<linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v3] nvmet-rdma: fix null dereference under heavy load
Date: Mon, 21 Jan 2019 15:07:09 +0200 [thread overview]
Message-ID: <fe7da170-9eea-360d-0ab7-84838b6debac@mellanox.com> (raw)
In-Reply-To: <ed249f9f-44f8-de1f-ba7e-1179317803d8@grimberg.me>
On 1/21/2019 11:10 AM, Sagi Grimberg wrote:
>> This looks ok to me:
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Applied to nvme-5.0
>
>> In the long run I wonder if we should get rid of the ѕtatic
>> preallocation entirely and just use a free pool to avoid constant
>> reallocations..
>
> you mean a kmem_cache? very possible, we can also make the command
> struct to contain the rsp behind it to avoid the extra allocation...
yes, the container idea sounds good..
next prev parent reply other threads:[~2019-01-21 13:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 17:35 [PATCH v3] nvmet-rdma: fix null dereference under heavy load Raju Rangoju
2019-01-03 17:35 ` Raju Rangoju
2019-01-03 23:13 ` Sagi Grimberg
2019-01-03 23:13 ` Sagi Grimberg
2019-01-07 15:59 ` Steve Wise
2019-01-07 15:59 ` Steve Wise
2019-01-18 7:37 ` Raju Rangoju
2019-01-18 7:37 ` Raju Rangoju
2019-01-19 13:34 ` Christoph Hellwig
2019-01-19 13:34 ` Christoph Hellwig
2019-01-21 9:10 ` Sagi Grimberg
2019-01-21 9:10 ` Sagi Grimberg
2019-01-21 13:07 ` Max Gurtovoy [this message]
2019-01-21 13:07 ` Max Gurtovoy
2019-01-21 15:46 ` Steve Wise
2019-01-21 15:46 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7da170-9eea-360d-0ab7-84838b6debac@mellanox.com \
--to=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.