All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
@ 2024-08-05 11:08 ` Alex Bee
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Bee @ 2024-08-05 11:08 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, Andy Yan, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann
  Cc: David Airlie, Daniel Vetter, dri-devel, linux-arm-kernel,
	linux-rockchip, linux-kernel, Alex Bee

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content
which is now given in the buffer parameter, but instead still uses the
(now) empty and superfluous packed_frame variable.

Fix it.

Fixes: 65548c8ff0ab ("drm/rockchip: inno_hdmi: Switch to HDMI connector")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
 drivers/gpu/drm/rockchip/inno_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 2241e53a2946..dec6913cec5b 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -279,7 +279,6 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 				  const u8 *buffer, size_t len)
 {
 	struct inno_hdmi *hdmi = connector_to_inno_hdmi(connector);
-	u8 packed_frame[HDMI_MAXIMUM_INFO_FRAME_SIZE];
 	ssize_t i;
 
 	if (type != HDMI_INFOFRAME_TYPE_AVI) {
@@ -291,8 +290,7 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 	inno_hdmi_disable_frame(connector, type);
 
 	for (i = 0; i < len; i++)
-		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i,
-			    packed_frame[i]);
+		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i, buffer[i]);
 
 	return 0;
 }
-- 
2.45.2


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
@ 2024-08-05 11:08 ` Alex Bee
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Bee @ 2024-08-05 11:08 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, Andy Yan, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann
  Cc: David Airlie, Daniel Vetter, dri-devel, linux-arm-kernel,
	linux-rockchip, linux-kernel, Alex Bee

HDMI analyser shows that the AVI infoframe is no being longer send.

The switch to the HDMI connector api should have used the frame content
which is now given in the buffer parameter, but instead still uses the
(now) empty and superfluous packed_frame variable.

Fix it.

Fixes: 65548c8ff0ab ("drm/rockchip: inno_hdmi: Switch to HDMI connector")
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
 drivers/gpu/drm/rockchip/inno_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 2241e53a2946..dec6913cec5b 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -279,7 +279,6 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 				  const u8 *buffer, size_t len)
 {
 	struct inno_hdmi *hdmi = connector_to_inno_hdmi(connector);
-	u8 packed_frame[HDMI_MAXIMUM_INFO_FRAME_SIZE];
 	ssize_t i;
 
 	if (type != HDMI_INFOFRAME_TYPE_AVI) {
@@ -291,8 +290,7 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
 	inno_hdmi_disable_frame(connector, type);
 
 	for (i = 0; i < len; i++)
-		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i,
-			    packed_frame[i]);
+		hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i, buffer[i]);
 
 	return 0;
 }
-- 
2.45.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
  2024-08-05 11:08 ` Alex Bee
@ 2024-08-05 11:30   ` Maxime Ripard
  -1 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2024-08-05 11:30 UTC (permalink / raw)
  To: Alex Bee
  Cc: dri-devel, linux-arm-kernel, linux-kernel, linux-rockchip,
	Andy Yan, Daniel Vetter, David Airlie, Heiko Stübner,
	Maarten Lankhorst, Maxime Ripard, Sandy Huang, Thomas Zimmermann

On Mon, 5 Aug 2024 13:08:56 +0200, Alex Bee wrote:
> HDMI analyser shows that the AVI infoframe is no being longer send.
> 
> The switch to the HDMI connector api should have used the frame content
> which is now given in the buffer parameter, but instead still uses the
> (now) empty and superfluous packed_frame variable.
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
@ 2024-08-05 11:30   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2024-08-05 11:30 UTC (permalink / raw)
  To: Alex Bee
  Cc: dri-devel, linux-arm-kernel, linux-kernel, linux-rockchip,
	Andy Yan, Daniel Vetter, David Airlie, Heiko Stübner,
	Maarten Lankhorst, Maxime Ripard, Sandy Huang, Thomas Zimmermann

On Mon, 5 Aug 2024 13:08:56 +0200, Alex Bee wrote:
> HDMI analyser shows that the AVI infoframe is no being longer send.
> 
> The switch to the HDMI connector api should have used the frame content
> which is now given in the buffer parameter, but instead still uses the
> (now) empty and superfluous packed_frame variable.
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
  2024-08-05 11:08 ` Alex Bee
@ 2024-08-15 10:40   ` Heiko Stuebner
  -1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2024-08-15 10:40 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, Maxime Ripard, Sandy Huang,
	Andy Yan, Alex Bee
  Cc: Heiko Stuebner, Daniel Vetter, linux-kernel, dri-devel,
	linux-rockchip, David Airlie, linux-arm-kernel

On Mon, 5 Aug 2024 13:08:56 +0200, Alex Bee wrote:
> HDMI analyser shows that the AVI infoframe is no being longer send.
> 
> The switch to the HDMI connector api should have used the frame content
> which is now given in the buffer parameter, but instead still uses the
> (now) empty and superfluous packed_frame variable.
> 
> Fix it.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: inno-hdmi: Fix infoframe upload
      commit: fd45cc614b8acca5bb435ba37fe9b3f9a17fab84

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload
@ 2024-08-15 10:40   ` Heiko Stuebner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2024-08-15 10:40 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, Maxime Ripard, Sandy Huang,
	Andy Yan, Alex Bee
  Cc: Heiko Stuebner, Daniel Vetter, linux-kernel, dri-devel,
	linux-rockchip, David Airlie, linux-arm-kernel

On Mon, 5 Aug 2024 13:08:56 +0200, Alex Bee wrote:
> HDMI analyser shows that the AVI infoframe is no being longer send.
> 
> The switch to the HDMI connector api should have used the frame content
> which is now given in the buffer parameter, but instead still uses the
> (now) empty and superfluous packed_frame variable.
> 
> Fix it.
> 
> [...]

Applied, thanks!

[1/1] drm/rockchip: inno-hdmi: Fix infoframe upload
      commit: fd45cc614b8acca5bb435ba37fe9b3f9a17fab84

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-15 10:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-05 11:08 [PATCH] drm/rockchip: inno-hdmi: Fix infoframe upload Alex Bee
2024-08-05 11:08 ` Alex Bee
2024-08-05 11:30 ` Maxime Ripard
2024-08-05 11:30   ` Maxime Ripard
2024-08-15 10:40 ` Heiko Stuebner
2024-08-15 10:40   ` Heiko Stuebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.