From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>, linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err
Date: Wed, 27 May 2020 11:42:33 +0000 [thread overview]
Message-ID: <feb4f798-ce3b-6a08-e462-ab23bd223b18@kernel.dk> (raw)
In-Reply-To: <20200526224902.63975-1-colin.king@canonical.com>
On 5/26/20 4:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>, linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err
Date: Wed, 27 May 2020 05:42:33 -0600 [thread overview]
Message-ID: <feb4f798-ce3b-6a08-e462-ab23bd223b18@kernel.dk> (raw)
In-Reply-To: <20200526224902.63975-1-colin.king@canonical.com>
On 5/26/20 4:49 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2020-05-27 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 22:49 [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err Colin King
2020-05-26 22:49 ` Colin King
2020-05-26 23:20 ` Eric Biggers
2020-05-26 23:20 ` Eric Biggers
2020-05-26 23:27 ` [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err' Satya Tangirala
2020-05-27 11:42 ` Jens Axboe [this message]
2020-05-27 11:42 ` [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feb4f798-ce3b-6a08-e462-ab23bd223b18@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.