From: Baolu Lu <baolu.lu@linux.intel.com>
To: Xu Yilun <yilun.xu@linux.intel.com>,
jgg@nvidia.com, jgg@ziepe.ca, kevin.tian@intel.com,
will@kernel.org, aneesh.kumar@kernel.org
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
joro@8bytes.org, robin.murphy@arm.com, shuah@kernel.org,
nicolinc@nvidia.com, aik@amd.com, dan.j.williams@intel.com,
yilun.xu@intel.com
Subject: Re: [PATCH v2 2/4] iommufd/viommu: Fix the uninitialized iommufd_vdevice::ictx
Date: Tue, 24 Jun 2025 11:24:02 +0800 [thread overview]
Message-ID: <ff1a3fc1-3671-4cff-917f-5ea44bd2451e@linux.intel.com> (raw)
In-Reply-To: <20250623094946.1714996-3-yilun.xu@linux.intel.com>
On 6/23/25 17:49, Xu Yilun wrote:
> Fix the uninitialized iommufd_vdevice::ictx. No code was using this
> field before, but later vdevice will use it to sync up with idevice on
> destroy paths.
>
> Fixes: 0ce5c2477af2 ("iommufd/viommu: Add IOMMUFD_OBJ_VDEVICE and IOMMU_VDEVICE_ALLOC ioctl")
> Cc:<stable@vger.kernel.org>
> Signed-off-by: Xu Yilun<yilun.xu@linux.intel.com>
> ---
> drivers/iommu/iommufd/viommu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/iommufd/viommu.c b/drivers/iommu/iommufd/viommu.c
> index 01df2b985f02..4577b88c8560 100644
> --- a/drivers/iommu/iommufd/viommu.c
> +++ b/drivers/iommu/iommufd/viommu.c
> @@ -130,6 +130,7 @@ int iommufd_vdevice_alloc_ioctl(struct iommufd_ucmd *ucmd)
> goto out_put_idev;
> }
>
> + vdev->ictx = ucmd->ictx;
iommufd_vdevice::ictx has been removed by this commit:
6e235a772199 ("iommufd: Drop unused ictx in struct iommufd_vdevice")
in linux-next.
Thanks,
baolu
next prev parent reply other threads:[~2025-06-24 3:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 9:49 [PATCH v2 0/4] iommufd: Destroy vdevice on device unbind Xu Yilun
2025-06-23 9:49 ` [PATCH v2 1/4] iommufd: Add iommufd_object_tombstone_user() helper Xu Yilun
2025-06-24 13:35 ` Jason Gunthorpe
2025-06-25 7:24 ` Xu Yilun
2025-06-25 5:51 ` Aneesh Kumar K.V
2025-06-25 8:40 ` Xu Yilun
2025-06-23 9:49 ` [PATCH v2 2/4] iommufd/viommu: Fix the uninitialized iommufd_vdevice::ictx Xu Yilun
2025-06-24 3:24 ` Baolu Lu [this message]
2025-06-24 6:35 ` Xu Yilun
2025-06-23 9:49 ` [PATCH v2 3/4] iommufd: Destroy vdevice on idevice destroy Xu Yilun
2025-06-24 3:32 ` Baolu Lu
2025-06-24 8:11 ` Xu Yilun
2025-06-24 8:28 ` Tian, Kevin
2025-06-24 8:12 ` Tian, Kevin
2025-06-25 1:55 ` Baolu Lu
2025-06-24 6:47 ` Xu Yilun
2025-06-24 8:22 ` Tian, Kevin
2025-06-26 4:59 ` Xu Yilun
2025-06-24 14:53 ` Jason Gunthorpe
2025-06-24 23:57 ` Tian, Kevin
2025-06-25 1:36 ` Jason Gunthorpe
2025-06-25 2:11 ` Tian, Kevin
2025-06-25 12:33 ` Jason Gunthorpe
2025-06-25 10:06 ` Xu Yilun
2025-06-25 12:38 ` Jason Gunthorpe
2025-06-26 3:31 ` Xu Yilun
2025-06-26 14:36 ` Jason Gunthorpe
2025-06-25 6:40 ` Aneesh Kumar K.V
2025-06-25 9:38 ` Xu Yilun
2025-06-23 9:49 ` [PATCH v2 4/4] iommufd/selftest: Add coverage for vdevice tombstone Xu Yilun
2025-06-24 13:41 ` Jason Gunthorpe
2025-06-25 8:29 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1a3fc1-3671-4cff-917f-5ea44bd2451e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=aik@amd.com \
--cc=aneesh.kumar@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.