From: Randy Dunlap <rdunlap@infradead.org>
To: Conor Dooley <conor@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: linux-next: Tree for Oct 6 (riscv: andes)
Date: Sat, 7 Oct 2023 09:06:33 -0700 [thread overview]
Message-ID: <ff4bbd33-e494-4db2-93e2-59d1a866d7cf@infradead.org> (raw)
In-Reply-To: <20231007-poach-refute-b84fe5b7431a@spud>
Hi Conor,
On 10/7/23 03:56, Conor Dooley wrote:
> On Fri, Oct 06, 2023 at 05:28:27PM -0700, Randy Dunlap wrote:
>>
>>
>> On 10/5/23 21:38, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20231005:
>>>
>>
>> on riscv 64bit:
>>
>> WARNING: unmet direct dependencies detected for ERRATA_ANDES
>> Depends on [n]: RISCV_ALTERNATIVE [=n] && RISCV_SBI [=y]
>> Selected by [y]:
>> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y] && NONPORTABLE [=y] && RISCV_SBI [=y]
>>
>> ../arch/riscv/errata/andes/errata.c:59:54: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration
>> 59 | void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
>> | ^~~~~~~~~
>>
>>
>> Full randconfig file is attached.
>
> Riiight. XIP_KERNEL is enabled, which means no alternatives are
> permitted, but that R9A config option selects the Andes errata, which in
> turn depends on alternatives.
>
> I suppose we could do something like (untested):
> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> index 7b74de732718..6fe85255e2ce 100644
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -343,7 +343,7 @@ config ARCH_R9A07G043
> select ARCH_RZG2L
> select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT
> select DMA_GLOBAL_POOL
> - select ERRATA_ANDES if RISCV_SBI
> + select ERRATA_ANDES if (RISCV_SBI & RISCV_ALTERNATIVE)
s/&/&&/ and then this works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> select ERRATA_ANDES_CMO if ERRATA_ANDES
> help
> This enables support for the Renesas RZ/Five SoC.
--
~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Conor Dooley <conor@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: linux-next: Tree for Oct 6 (riscv: andes)
Date: Sat, 7 Oct 2023 09:06:33 -0700 [thread overview]
Message-ID: <ff4bbd33-e494-4db2-93e2-59d1a866d7cf@infradead.org> (raw)
In-Reply-To: <20231007-poach-refute-b84fe5b7431a@spud>
Hi Conor,
On 10/7/23 03:56, Conor Dooley wrote:
> On Fri, Oct 06, 2023 at 05:28:27PM -0700, Randy Dunlap wrote:
>>
>>
>> On 10/5/23 21:38, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20231005:
>>>
>>
>> on riscv 64bit:
>>
>> WARNING: unmet direct dependencies detected for ERRATA_ANDES
>> Depends on [n]: RISCV_ALTERNATIVE [=n] && RISCV_SBI [=y]
>> Selected by [y]:
>> - ARCH_R9A07G043 [=y] && SOC_RENESAS [=y] && RISCV [=y] && NONPORTABLE [=y] && RISCV_SBI [=y]
>>
>> ../arch/riscv/errata/andes/errata.c:59:54: warning: 'struct alt_entry' declared inside parameter list will not be visible outside of this definition or declaration
>> 59 | void __init_or_module andes_errata_patch_func(struct alt_entry *begin, struct alt_entry *end,
>> | ^~~~~~~~~
>>
>>
>> Full randconfig file is attached.
>
> Riiight. XIP_KERNEL is enabled, which means no alternatives are
> permitted, but that R9A config option selects the Andes errata, which in
> turn depends on alternatives.
>
> I suppose we could do something like (untested):
> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> index 7b74de732718..6fe85255e2ce 100644
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -343,7 +343,7 @@ config ARCH_R9A07G043
> select ARCH_RZG2L
> select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT
> select DMA_GLOBAL_POOL
> - select ERRATA_ANDES if RISCV_SBI
> + select ERRATA_ANDES if (RISCV_SBI & RISCV_ALTERNATIVE)
s/&/&&/ and then this works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> select ERRATA_ANDES_CMO if ERRATA_ANDES
> help
> This enables support for the Renesas RZ/Five SoC.
--
~Randy
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-10-07 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 4:38 linux-next: Tree for Oct 6 Stephen Rothwell
2023-10-07 0:28 ` linux-next: Tree for Oct 6 (riscv: andes) Randy Dunlap
2023-10-07 0:28 ` Randy Dunlap
2023-10-07 10:56 ` Conor Dooley
2023-10-07 10:56 ` Conor Dooley
2023-10-07 16:06 ` Randy Dunlap [this message]
2023-10-07 16:06 ` Randy Dunlap
2023-10-07 0:38 ` linux-next: Tree for Oct 6 [arch/loongarch/kvm/kvm.ko] Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4bbd33-e494-4db2-93e2-59d1a866d7cf@infradead.org \
--to=rdunlap@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.