From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>,
Patrick McLean <chutzpah@gentoo.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well
Date: Tue, 18 Apr 2023 17:00:01 +0900 [thread overview]
Message-ID: <ff7547c1-450d-7dea-1c11-e55dc77cae76@kernel.org> (raw)
In-Reply-To: <ZD4pg7EMgGU2yjLM@infradead.org>
On 4/18/23 14:24, Christoph Hellwig wrote:
> On Mon, Apr 17, 2023 at 06:17:20PM -0700, Patrick McLean wrote:
>> We have some machines with ASPEED SATA controllers, and are seeing the same NCQ
>> issues that ATI controllers (I am not sure if it's a rebranded ATI controller,
>> or they both have some faulty implementation). This NCQ breakage is consistent
>> across a few different types of drives.
>>
>> Instead of maintaining a list of drives that are broken with ASPEED controllers
>
> Are these ASPEED controllers all the same or a wide variety?
> Quirking all controllers from the same vendor seems like an overly
> broad approach to me.
Indeed. If you checked only one adapter model from ASPEED, then all that is
needed is define it with "board_ahci_noncq" in drivers/ata/ahci.c (see
ahci_pci_tbl array). NCQ support will be turned off for that particular adapter
with that.
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@infradead.org>,
Patrick McLean <chutzpah@gentoo.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well
Date: Tue, 18 Apr 2023 17:00:01 +0900 [thread overview]
Message-ID: <ff7547c1-450d-7dea-1c11-e55dc77cae76@kernel.org> (raw)
In-Reply-To: <ZD4pg7EMgGU2yjLM@infradead.org>
On 4/18/23 14:24, Christoph Hellwig wrote:
> On Mon, Apr 17, 2023 at 06:17:20PM -0700, Patrick McLean wrote:
>> We have some machines with ASPEED SATA controllers, and are seeing the same NCQ
>> issues that ATI controllers (I am not sure if it's a rebranded ATI controller,
>> or they both have some faulty implementation). This NCQ breakage is consistent
>> across a few different types of drives.
>>
>> Instead of maintaining a list of drives that are broken with ASPEED controllers
>
> Are these ASPEED controllers all the same or a wide variety?
> Quirking all controllers from the same vendor seems like an overly
> broad approach to me.
Indeed. If you checked only one adapter model from ASPEED, then all that is
needed is define it with "board_ahci_noncq" in drivers/ata/ahci.c (see
ahci_pci_tbl array). NCQ support will be turned off for that particular adapter
with that.
next prev parent reply other threads:[~2023-04-18 8:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 1:17 Apply ATI NCQ horkage to ASPEED as well Patrick McLean
2023-04-18 1:17 ` [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h Patrick McLean
2023-04-18 1:17 ` Patrick McLean
2023-04-18 8:35 ` Daniel Vetter
2023-04-18 8:35 ` Daniel Vetter
2023-04-18 8:48 ` Sergei Shtylyov
2023-04-18 8:48 ` Sergei Shtylyov
2023-04-18 21:14 ` Bjorn Helgaas
2023-04-18 21:14 ` Bjorn Helgaas
2023-04-18 21:17 ` Bjorn Helgaas
2023-04-18 21:17 ` Bjorn Helgaas
2023-04-18 1:17 ` [PATCH 2/2] ata: libata-core: Apply ATI NCQ horkage to ASPEED as well Patrick McLean
2023-04-18 1:17 ` Patrick McLean
2023-04-18 5:24 ` Christoph Hellwig
2023-04-18 8:00 ` Damien Le Moal [this message]
2023-04-18 8:00 ` Damien Le Moal
2023-04-18 8:42 ` Sergei Shtylyov
2023-04-18 8:42 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7547c1-450d-7dea-1c11-e55dc77cae76@kernel.org \
--to=dlemoal@kernel.org \
--cc=airlied@redhat.com \
--cc=bhelgaas@google.com \
--cc=chutzpah@gentoo.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.