[Fwd: Re: mtn disapprove]

[Fwd: Re: mtn disapprove]

[Rolf Leggewie]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Hi,

the OE mailing list was experiencing some hickups, it seems, so I am
resending this mail from Saturday.

Regards

Rolf

[-- Attachment #2: Re: [oe] mtn disapprove.eml --]
[-- Type: message/rfc822, Size: 2730 bytes --]

From: Rolf Leggewie <no2spam@nospam.arcornews.de>
Subject: Re: [oe] mtn disapprove
Date: Sat, 12 Jan 2008 16:44:16 +0100

Richard, thank you for your comments.

Richard Purdie schrieb:
>> -# This is needed for the ramdisk script to work
>> -MACHINE_EXTRA_RDEPENDS += "e2fsprogs-mke2fs"

> What happened to this? It looks wrong, I just want to make sure the
> underlying problem was fixed...

The suggestion came from hrw.  I would not know what it was needed for
so I looked through "mtn log".  It was imported from bitkeeper so I have
no way to find out who originally added this line.

>> -TARGET_CC_ARCH = "-march=armv4 -mtune=xscale"
>> +TARGET_CC_ARCH ?= "-march=armv4 -mtune=strongarm1100"
>> +TARGET_CC_ARCH_collie = "-march=armv4 -mtune=strongarm1110"
> 
> We should really have tune-strongarm1100.inc and
> tune-strongarm1110.inc...

I almost agree.  But since strongarm1110.inc would only be used by
collie and the file is a simple one-liner after all. I'd rather rename
tune-strongarm.inc to tune-strongarm1100.inc and replace the inclusion
of tune-strongarm.inc for collie with the correct one-liner.  One would
also add an explanation to tune-strongarm1100.inc that it is not
suitable for strongarm 1110 as used in the collie.

The following files would be affected by a renaming of tune-strongarm.inc

$ rgrep tune-strongarm conf/|grep inc|grep -v '#'|cut -b 6-
machine/collie.conf:require conf/machine/include/tune-strongarm.inc
machine/h3600.conf:require conf/machine/include/tune-strongarm.inc
machine/jornada56x.conf:require conf/machine/include/tune-strongarm.inc
machine/jornada7xx.conf:require conf/machine/include/tune-strongarm.inc
machine/simpad.conf:require conf/machine/include/tune-strongarm.inc
machine/shark.conf:require conf/machine/include/tune-strongarm.inc
machine/htcwallaby.conf:require conf/machine/include/tune-strongarm.inc

Since the patch is becoming quite big and starting to touch things
outside the scope of collie, I have made this into a separate patch and
committed it in 4989371c8e7cec943a964b459ec3e71c0f547204.

>> +PACKAGE_EXTRA_ARCHS ?= "armv4 armv4t armv5e armv5te"

> No need for the ?= here...
[...]
> or here...

OK, just wanted to be safe.  I'll remove the ?.  Thanks.  Diff is
updated again.

Regards

Rolf