All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: powerpc: add static and ifdef prom_strtoul and prom_memparse
Date: Thu, 10 Jul 2008 16:23:38 -0500 (CDT)	[thread overview]
Message-ID: <for-27-patch7@bga.com> (raw)
In-Reply-To: <for-27-patch1-0@bga.com>

These functions should have been static, and inspection shows they
are no longer used.   (We used to parse mem= but we now defer that
to early_param).

Signed-off-by: Milton Miller <miltonm@bga.com>
---
Should we just remove them instead?

diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
index 1ea8c8d..bf1f922 100644
--- a/arch/powerpc/kernel/prom_init.c
+++ b/arch/powerpc/kernel/prom_init.c
@@ -489,6 +489,7 @@ static int __init prom_setprop(phandle node, const char *nodename,
 	return call_prom("interpret", 1, 1, (u32)(unsigned long) cmd);
 }
 
+#if 0
 /* We can't use the standard versions because of RELOC headaches. */
 #define isxdigit(c)	(('0' <= (c) && (c) <= '9') \
 			 || ('a' <= (c) && (c) <= 'f') \
@@ -498,7 +499,7 @@ static int __init prom_setprop(phandle node, const char *nodename,
 #define islower(c)	('a' <= (c) && (c) <= 'z')
 #define toupper(c)	(islower(c) ? ((c) - 'a' + 'A') : (c))
 
-unsigned long prom_strtoul(const char *cp, const char **endp)
+static unsigned long prom_strtoul(const char *cp, const char **endp)
 {
 	unsigned long result = 0, base = 10, value;
 
@@ -523,7 +524,7 @@ unsigned long prom_strtoul(const char *cp, const char **endp)
 	return result;
 }
 
-unsigned long prom_memparse(const char *ptr, const char **retptr)
+static unsigned long prom_memparse(const char *ptr, const char **retptr)
 {
 	unsigned long ret = prom_strtoul(ptr, retptr);
 	int shift = 0;
@@ -549,6 +550,7 @@ unsigned long prom_memparse(const char *ptr, const char **retptr)
 
 	return ret;
 }
+#endif
 
 /*
  * Early parsing of the command line passed to the kernel, used for

  parent reply	other threads:[~2008-07-10 21:24 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 21:12 [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't Milton Miller
2008-07-10 21:12 ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Milton Miller
2008-07-10 21:14 ` mtd: remove __PPC__ hardcoded address from nand/diskonchip and devices/docprobe Milton Miller
2008-07-10 21:14 ` [1/3] powerpc: add _HEAD_GLOBAL to place functions in .text.head Milton Miller
2008-07-10 21:16 ` [2/3] powerpc: head_64.S: put irq vectors " Milton Miller
2008-07-10 21:19 ` powerpc: numa.c: always trim to lmb_end_of_DRAM Milton Miller
2008-07-10 21:20 ` powerpc: pseries, cell: use cpu_thread_in_core in smp_init for of_spin_map Milton Miller
2008-07-10 21:22 ` powerpc: find and destroy possible stale kernel added properties Milton Miller
2008-07-10 21:23 ` Milton Miller [this message]
2008-07-10 21:29 ` [PATCH] spufs: correct kcalloc usage Milton Miller
2008-07-10 23:04   ` Jeremy Kerr
2008-07-10 21:33 ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Hans de Goede
2008-07-10 21:33   ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Hans de Goede
2008-07-10 21:33   ` Hans de Goede
2008-07-10 21:51   ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Milton Miller
2008-07-10 21:51     ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Milton Miller
2008-07-10 21:51     ` Milton Miller
2008-07-11  6:52     ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-11  6:52       ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-11  6:52       ` Jean Delvare
2008-07-11  7:27       ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Hans de Goede
2008-07-11  7:27         ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Hans de Goede
2008-07-11  7:27         ` Hans de Goede
2008-07-11  7:36         ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-11  7:36           ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-11  7:36           ` Jean Delvare
2008-07-13  6:31           ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Hans de Goede
2008-07-13  6:31             ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Hans de Goede
2008-07-13  6:31             ` Hans de Goede
2008-07-13 21:11             ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please David Hubbard
2008-07-13 21:11               ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region David Hubbard
2008-07-13 21:11               ` David Hubbard
2008-07-13 21:22               ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Hans de Goede
2008-07-13 21:22                 ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Hans de Goede
2008-07-13 21:22                 ` Hans de Goede
2008-07-13 21:26                 ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please David Hubbard
2008-07-13 21:26                   ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region David Hubbard
2008-07-13 21:26                   ` David Hubbard
2008-07-14  7:59                   ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-14  7:59                     ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-14  7:59                     ` Jean Delvare
2008-07-14 17:09                     ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Milton Miller
2008-07-14 17:09                       ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Milton Miller
2008-07-14 17:09                       ` Milton Miller
2008-07-14 17:30                       ` [lm-sensors] [RFC] (almost) booting allyesconfig -- Hans de Goede
2008-07-14 17:30                         ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Hans de Goede
2008-07-14 17:30                         ` Hans de Goede
2008-07-14 17:55                         ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please David Hubbard
2008-07-14 17:55                           ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region David Hubbard
2008-07-14 17:55                           ` David Hubbard
2008-07-15  8:36                           ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-15  8:36                             ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-15  8:36                             ` Jean Delvare
2008-07-15 15:31                             ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please David Hubbard
2008-07-15 15:31                               ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region David Hubbard
2008-07-15 15:31                               ` David Hubbard
2008-07-16  7:46                               ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-16  7:46                                 ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-16  7:46                                 ` Jean Delvare
2008-07-16  8:09                                 ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Rene Herman
2008-07-16  8:09                                   ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Rene Herman
2008-07-16  8:09                                   ` Rene Herman
2008-07-15  8:28                       ` [lm-sensors] [RFC] (almost) booting allyesconfig -- please Jean Delvare
2008-07-15  8:28                         ` [RFC] (almost) booting allyesconfig -- please don't poke super-io without request_region Jean Delvare
2008-07-15  8:28                         ` Jean Delvare
     [not found] ` <for-27-patch9@bga.com>
2008-07-12 20:02   ` [PATCH/RESEND] pci: dynids.use_driver_data considered harmful Milton Miller
2008-07-12 20:17     ` Greg KH
2008-07-12 20:58       ` Jean Delvare
2008-07-12 21:17       ` Milton Miller
2008-07-12 21:29         ` Milton Miller
     [not found]   ` <20080712041137.GA5933@kroah.com>
2008-07-12 21:08     ` [PATCH/RFC] " Milton Miller
2008-07-12 22:48       ` Milton Miller
2008-07-16 10:18         ` Milton Miller
2008-07-17  7:07           ` Greg KH
2008-07-17 14:36             ` Milton Miller
2008-08-06  7:31             ` Jean Delvare
2008-08-14 22:12               ` Greg KH
2008-08-15 14:50                 ` Milton Miller
2008-08-15 15:50                 ` Jean Delvare
2008-08-15 17:46                   ` Jesse Barnes
2008-08-15 18:55                     ` Jean Delvare
2008-08-15 19:15                       ` Jesse Barnes
2008-08-16  6:22                         ` Greg KH
2008-08-17 19:06                           ` Jean Delvare
2008-08-18  3:50                             ` Greg KH
2008-08-18 17:13                             ` Jesse Barnes
2008-08-18 20:41                             ` Jesse Barnes
2008-08-19 18:01                             ` Milton Miller
2008-08-06  7:22           ` Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2008-10-21  1:37 powerpc: add static and ifdef prom_strtoul and prom_memparse Milton Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=for-27-patch7@bga.com \
    --to=miltonm@bga.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.