* [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas()
@ 2026-07-13 9:17 Thorsten Blum
2026-07-13 9:27 ` Amit Machhiwal
2026-07-13 14:03 ` Ritesh Harjani
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2026-07-13 9:17 UTC (permalink / raw)
To: Geoff Levand, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Christophe Leroy (CS GROUP)
Cc: Amit Machhiwal, Thorsten Blum, Geert Uytterhoeven, linuxppc-dev,
linux-kernel
The local table structure is not used - remove it.
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
Changes in v2:
- Drop the %0 change because it is valid kernel-doc markup (Amit)
- v1: https://lore.kernel.org/r/20260712151300.3664-3-thorsten.blum@linux.dev/
---
arch/powerpc/platforms/ps3/spu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
index e817def7f424..2c785bc72565 100644
--- a/arch/powerpc/platforms/ps3/spu.c
+++ b/arch/powerpc/platforms/ps3/spu.c
@@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
static int __init setup_areas(struct spu *spu)
{
- struct table {char* name; unsigned long addr; unsigned long size;};
-
spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
sizeof(struct spe_shadow),
pgprot_noncached_wc(PAGE_KERNEL_RO));
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas()
2026-07-13 9:17 [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas() Thorsten Blum
@ 2026-07-13 9:27 ` Amit Machhiwal
2026-07-13 14:03 ` Ritesh Harjani
1 sibling, 0 replies; 3+ messages in thread
From: Amit Machhiwal @ 2026-07-13 9:27 UTC (permalink / raw)
To: Thorsten Blum
Cc: Geoff Levand, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Christophe Leroy (CS GROUP), Amit Machhiwal,
Geert Uytterhoeven, linuxppc-dev, linux-kernel
On 2026/07/13 11:17 AM, Thorsten Blum wrote:
> The local table structure is not used - remove it.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> Changes in v2:
> - Drop the %0 change because it is valid kernel-doc markup (Amit)
Thanks for addressing the comment and sending a v2!
Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
~Amit
> - v1: https://lore.kernel.org/r/20260712151300.3664-3-thorsten.blum@linux.dev/
> ---
> arch/powerpc/platforms/ps3/spu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e817def7f424..2c785bc72565 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
>
> static int __init setup_areas(struct spu *spu)
> {
> - struct table {char* name; unsigned long addr; unsigned long size;};
> -
> spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
> sizeof(struct spe_shadow),
> pgprot_noncached_wc(PAGE_KERNEL_RO));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas()
2026-07-13 9:17 [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas() Thorsten Blum
2026-07-13 9:27 ` Amit Machhiwal
@ 2026-07-13 14:03 ` Ritesh Harjani
1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2026-07-13 14:03 UTC (permalink / raw)
To: Thorsten Blum, Geoff Levand, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP)
Cc: Amit Machhiwal, Thorsten Blum, Geert Uytterhoeven, linuxppc-dev,
linux-kernel
Thorsten Blum <thorsten.blum@linux.dev> writes:
> The local table structure is not used - remove it.
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
LGTM.
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-13 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 9:17 [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas() Thorsten Blum
2026-07-13 9:27 ` Amit Machhiwal
2026-07-13 14:03 ` Ritesh Harjani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.