All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Foiani <tkil@scrye.com>
To: Bhushan Bharat-R65777 <R65777@freescale.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: MPC8315 reboot failure, lockdep splat possibly related?
Date: Sat, 17 Aug 2013 11:17:49 -0600	[thread overview]
Message-ID: <g1u5sp77m.fsf@dworkin.scrye.com> (raw)
In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07114F7C@039-SN2MPN1-013.039d.mgd.msft.net> (Bhushan Bharat-R's message of "Sat\, 17 Aug 2013 04\:58\:34 +0000")

Bharat, greetings --

Bhushan Bharat-R65777 <R65777@freescale.com> writes:

> You should get rid of this by changing spin_lock/unlock() in
> fsl_sata_set_irq_coalescing() to spin_lock_irqsave/restore()

I'll do that -- thanks!

Looks like linux-next still has plain spin_lock, not the irqsave variant.

Is this something that needs to be pushed to mainline and/or stable?

If it should go upstream, is this something that Freescale can do, or
should I try to put together a patch?  (I'd like to avoid having to do
it myself, because I'm carrying out-of-tree patches that I'd have to
port to linux-next before it'd be accepted there, I fear.)

Either way, I'll definitely report if it fixes the splat on my 3.9.7
system.

Thanks again!

Best regards,
Anthony Foiani

  reply	other threads:[~2013-08-17 17:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17  1:39 MPC8315 reboot failure, lockdep splat possibly related? Anthony Foiani
2013-08-17  4:58 ` Bhushan Bharat-R65777
2013-08-17 17:17   ` Anthony Foiani [this message]
2013-08-18  0:07   ` Anthony Foiani
2013-08-18 17:00     ` Bhushan Bharat-R65777
2013-08-18 19:19       ` Anthony Foiani
2013-08-19 18:15         ` [PATCH] sata: fsl: save irqs while coalescing Anthony Foiani
2013-08-20  0:21           ` Scott Wood
2013-08-20  1:20         ` Anthony Foiani
2013-08-20  1:20           ` Anthony Foiani
2013-08-20 12:39           ` Tejun Heo
2013-08-20 12:39             ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=g1u5sp77m.fsf@dworkin.scrye.com \
    --to=tkil@scrye.com \
    --cc=R65777@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.