Packaged Staging Problems

Packaged Staging Problems

[Graeme Gregory]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

I get the problem in packaged staging that it repeatedly issues the
error.

NOTE: Checking if staging package installed
head: `-1' option is obsolete; use `-n 1'
Try `head --help' for more information.
sed: couldn't flush stdout: Broken pipe
NOTE: No. Manually removing any installed files

I suspect the attached patch is the fix for this. But this is scary core
stuff so I thought I would send it for review.

Graeme


[-- Attachment #2: stage-manager.patch --]
[-- Type: text/x-diff, Size: 1304 bytes --]

#
# old_revision [6ff295c2536e27dfcb4ab565a0592a3dc502d6aa]
#
# patch "packages/stage-manager/files/stage-manager-ipkg"
#  from [7593166519513f8e516b14d394e2d3576854f946]
#    to [039533c80c39c7ad92cf0d47b2a4df052ab060fa]
#
============================================================
--- packages/stage-manager/files/stage-manager-ipkg	7593166519513f8e516b14d394e2d3576854f946
+++ packages/stage-manager/files/stage-manager-ipkg	039533c80c39c7ad92cf0d47b2a4df052ab060fa
@@ -33,7 +33,7 @@ ipkg_src_byname() {
 
 ipkg_src_byname() {
 	local src="$1"
-	ipkg_srcs $src | head -1
+	ipkg_srcs $src | head -n1
 }
 
 ipkg_dests() {
@@ -58,16 +58,16 @@ ipkg_dest_default() {
 }
 
 ipkg_dest_default() {
-	ipkg_dests_all | head -1
+	ipkg_dests_all | head -n1
 }
 
 ipkg_dest_default_name() {
-	ipkg_dest_names | head -1
+	ipkg_dest_names | head -n1
 }
 
 ipkg_dest_byname() {
 	local dest="$1"
-	ipkg_dests $dest | head -1
+	ipkg_dests $dest | head -n1
 }
 
 ipkg_option() {
@@ -975,7 +975,7 @@ ipkg_upgrade_pkg() {
 
 ipkg_upgrade_pkg() {
 	local pkg="$1"
-	local avail_ver=`ipkg_info $pkg Version | ipkg_extract_value | head -1`
+	local avail_ver=`ipkg_info $pkg Version | ipkg_extract_value | head -n1`
 
 	is_installed=
 	for dest_name in `ipkg_dest_names`; do

Re: Packaged Staging Problems

[Koen Kooi]

Graeme Gregory wrote:
> I get the problem in packaged staging that it repeatedly issues the
> error.
>
> NOTE: Checking if staging package installed
> head: `-1' option is obsolete; use `-n 1'
> Try `head --help' for more information.
> sed: couldn't flush stdout: Broken pipe
> NOTE: No. Manually removing any installed files
>
> I suspect the attached patch is the fix for this. But this is scary core
> stuff so I thought I would send it for review.

I really should start reading email first before I start fixing the 
things you sent me over jabber :)
Anyway, I commmitted something that looks a lot like your patch 5 
minutes ago.

regards,

Koen

Re: Packaged Staging Problems

[Koen Kooi]

Graeme Gregory wrote:
> I get the problem in packaged staging that it repeatedly issues the
> error.
>
> NOTE: Checking if staging package installed
> head: `-1' option is obsolete; use `-n 1'
> Try `head --help' for more information.
> sed: couldn't flush stdout: Broken pipe
> NOTE: No. Manually removing any installed files
>
> I suspect the attached patch is the fix for this. But this is scary core
> stuff so I thought I would send it for review.

I wondered why I wasn't seeing those errors, it turns out I have a stray 
ipkg-cl from my original packaged-staging in /usr/local/bin, so 
stagemanager-ipkg doesn't get used. A 'bitbake opkg-native' gets you a 
nice opkg-cl in $PATH, but we still need a real solution.

regards,

Koen