All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: rrdtool: fixup in EXTRA_OECONF to get past error in do_configure. add do_stage. Closes 2524.
@ 2008-08-03  8:05 Koen Kooi
  2008-08-05 13:29 ` Rolf Leggewie
  0 siblings, 1 reply; 2+ messages in thread
From: Koen Kooi @ 2008-08-03  8:05 UTC (permalink / raw)
  To: openembedded-devel

Hi,

I just noticed a commit doing this:

-EXTRA_OECONF = "--enable-shared --enable-local-libpng 
--enable-local-zlib --program-prefix=''"
+EXTRA_OECONF = "rd_cv_ieee_works=yes --enable-shared 
--enable-local-libpng --enable-local-zlib --program-prefix=''"

Please don't specify such information on the commandline, it belongs 
into the site files.

If you are sure it's generic, put it in site/common like this:

rd_cv_ieee_works=${rd_cv_ieee_works=yes}

I'f you aren't sure if it applies to both linux and uclinux, put it in 
common-linux or common-uclinux or even in <arch>-common.

If we put it in the site files we don't have to reinvent the wheel 
everytime a package tests for rd_cv_ieee_works.

regards,

Koen






^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: rrdtool: fixup in EXTRA_OECONF to get past error in do_configure. add do_stage. Closes 2524.
  2008-08-03  8:05 rrdtool: fixup in EXTRA_OECONF to get past error in do_configure. add do_stage. Closes 2524 Koen Kooi
@ 2008-08-05 13:29 ` Rolf Leggewie
  0 siblings, 0 replies; 2+ messages in thread
From: Rolf Leggewie @ 2008-08-05 13:29 UTC (permalink / raw)
  To: openembedded-devel

Koen Kooi wrote:
> rd_cv_ieee_works=${rd_cv_ieee_works=yes}

Thanks for noticing and providing an explanation

Fixed in 9767e2c8632f709640f3b42264030553c9906cb2




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-05 13:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-03  8:05 rrdtool: fixup in EXTRA_OECONF to get past error in do_configure. add do_stage. Closes 2524 Koen Kooi
2008-08-05 13:29 ` Rolf Leggewie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.