From: Anthony Foiani <tkil@scrye.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Li Yang-R58472 <r58472@freescale.com>,
"Robert P.J.Day" <rpjday@crashcourse.ca>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Shaohui.Xie@freescale.com, Adrian Bunk <bunk@stusta.de>
Subject: Re: ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS
Date: Sat, 24 Aug 2013 02:03:14 -0600 [thread overview]
Message-ID: <gd2p3h5x9.fsf@dworkin.scrye.com> (raw)
In-Reply-To: <1377301643.20722.109.camel@snotra.buserror.net> (Scott Wood's message of "Fri\, 23 Aug 2013 18\:47\:23 -0500")
Scott Wood <scottwood@freescale.com> writes:
> On Fri, 2013-08-23 at 17:41 -0600, Anthony Foiani wrote:
> > In my original patch [...] I used "fsl,sata-max-gen". I thought
> > Jeff disliked it, so I changed it be more generic -- but maybe I
> > misread his complaint. (And while his opinions are still
> > respected, new maintainers might have different tastes.)
>
> I didn't see anything to that effect from Jeff in that thread -- maybe
> it was elsewhere.
I think I'm referring to this message:
http://article.gmane.org/gmane.linux.ports.ppc.embedded/58720
As he was referring me to generic methods, I inferred that I should be
providing generic knobs...
> The device tree describes the hardware, not the driver -- and thus
> should be free to use clearer wording. :-)
*nod*
> As for fsl-specific versus generic, generic is fine but then it
> needs to be documented in a generic place.
Agreed. I actually prefer the "generation" nomenclature, as it has a
more direct/straightforward interpretation. ("speed=1" vs
"generation=1"; the latter is a much bigger clue, IMHO.)
> Sorry, linux-ide.
Ok, thanks.
I'll wait a few days to see if there are any other comments or
concerns, then I'll spin a final version
As always, thanks for the review and insight!
Best regards,
Anthony Foiani
next prev parent reply other threads:[~2013-08-24 8:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 19:25 ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS Scott Wood
2013-08-23 23:41 ` Anthony Foiani
2013-08-23 23:47 ` Scott Wood
2013-08-24 8:03 ` Anthony Foiani [this message]
2013-08-27 10:51 ` Xie Shaohui-B21989
-- strict thread matches above, loose matches on Subject: below --
2012-05-17 17:08 Anthony Foiani
2012-05-21 6:31 ` Li Yang-R58472
2012-05-26 6:53 ` Anthony Foiani
2012-05-29 18:02 ` Scott Wood
2012-05-29 22:07 ` Anthony Foiani
2012-05-29 22:57 ` Scott Wood
2012-05-30 10:59 ` Li Yang
2012-05-30 20:07 ` Anthony Foiani
2012-05-30 20:14 ` Anthony Foiani
2012-05-30 20:20 ` Scott Wood
2012-05-30 20:52 ` Anthony Foiani
2013-04-30 6:41 ` Anthony Foiani
2013-04-30 18:15 ` Scott Wood
2013-05-01 0:34 ` Anthony Foiani
2013-05-01 0:42 ` Scott Wood
2013-05-01 2:06 ` Anthony Foiani
2013-05-01 18:05 ` Scott Wood
2013-05-01 23:35 ` Anthony Foiani
2013-05-02 0:13 ` Scott Wood
2013-04-30 21:35 ` Jeff Garzik
2013-05-02 6:37 ` Anthony Foiani
2013-05-08 12:04 ` Anthony Foiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gd2p3h5x9.fsf@dworkin.scrye.com \
--to=tkil@scrye.com \
--cc=Shaohui.Xie@freescale.com \
--cc=bunk@stusta.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=rpjday@crashcourse.ca \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.