Commit policy violations

Commit policy violations

[Koen Kooi]

Hi,

We have had a commit policy for some years now, so it would be nice if 
people would actually stick to it.

So don't do things like this:

"[PR] Change PR to FILE_PR and intro PR as FILE_PR + DISTRO_PR"

or

"[hal] Add latest hal and hal-info"

or

"add task-fonts-truetype"

Those 3 are all *bad*.

Re: Commit policy violations

[Otavio Salvador]

Koen Kooi <k.kooi@student.utwente.nl> writes:

> Hi,
>
> We have had a commit policy for some years now, so it would be nice if
> people would actually stick to it.
>
> So don't do things like this:
>
> "[PR] Change PR to FILE_PR and intro PR as FILE_PR + DISTRO_PR"
>
> or
>
> "[hal] Add latest hal and hal-info"
>
> or
>
> "add task-fonts-truetype"
>
> Those 3 are all *bad*.

Could you explain which would be the good ones?

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."

Re: Commit policy violations

[Koen Kooi]

On 16-10-2008 19:02, Otavio Salvador wrote:
> Koen Kooi<k.kooi@student.utwente.nl>  writes:
>
>> Hi,
>>
>> We have had a commit policy for some years now, so it would be nice if
>> people would actually stick to it.
>>
>> So don't do things like this:
>>
>> "[PR] Change PR to FILE_PR and intro PR as FILE_PR + DISTRO_PR"
>>
>> or
>>
>> "[hal] Add latest hal and hal-info"
>>
>> or
>>
>> "add task-fonts-truetype"
>>
>> Those 3 are all *bad*.
>
> Could you explain which would be the good ones?

The git phrasebook has the format:

http://wiki.openembedded.net/index.php/GitPhraseBook

Examples of decent commit messages from today[1]:

"hal_0.5.11.bb : add new version from OM branch"

"xmms: add sed magic to fix builds with gettext > 0.14.0"

"hal 0.5.11: move to nonworking:
* autoreconf fails
* after fixing that it doesn't build"

regards,

Koen

[1] That sentence no verb!