Pidgin needs to RDEPENDS on pidgin-data?

Pidgin needs to RDEPENDS on pidgin-data?

[Stefan Schmidt]

Hello.

I have a user bug report here that pidgin segfaults without pidgin-data
installed:
http://trac.freesmartphone.org/ticket/170

In pidgin.inc it only RRECOMMANDS pidgin-data, but not RDEPENDS on it.
Patch below is what I would push if nobody objects.

regards
Stefan Schmidt

diff --git a/packages/pidgin/pidgin.inc b/packages/pidgin/pidgin.inc
index db66d13..e3c35a7 100644
--- a/packages/pidgin/pidgin.inc
+++ b/packages/pidgin/pidgin.inc
@@ -44,7 +44,7 @@ FILES_finch-dbg     = "${bindir}/.debug/finch \
 
 FILES_${PN} = "${bindir} ${datadir}/${PN} ${libdir}/${PN}/*.so \
 	       ${datadir}/applications"
-RRECOMMENDS_${PN{ += "${PN}-data "
+RDEPENDS_${PN{ += "${PN}-data "
 FILES_${PN}-data = "${datadir}/pixmaps ${datadir}/sounds ${datadir}/icons"
 FILES_${PN}-dev += "${libdir}/${PN}/*.la"
 

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Koen Kooi]

On 23-10-2008 14:41, Stefan Schmidt wrote:
> Hello.
>
> I have a user bug report here that pidgin segfaults without pidgin-data
> installed:
> http://trac.freesmartphone.org/ticket/170
>
> In pidgin.inc it only RRECOMMANDS pidgin-data, but not RDEPENDS on it.
> Patch below is what I would push if nobody objects.

That patch is no good. The real fix is to move the 2 files pidgin needs 
from -data to the main package.
Also: if pidgin-data is not getting installed when installing pidgin 
something is wrong with your feeds.

regards,

Koen


>
> regards
> Stefan Schmidt
>
> diff --git a/packages/pidgin/pidgin.inc b/packages/pidgin/pidgin.inc
> index db66d13..e3c35a7 100644
> --- a/packages/pidgin/pidgin.inc
> +++ b/packages/pidgin/pidgin.inc
> @@ -44,7 +44,7 @@ FILES_finch-dbg     = "${bindir}/.debug/finch \
>
>   FILES_${PN} = "${bindir} ${datadir}/${PN} ${libdir}/${PN}/*.so \
>   	       ${datadir}/applications"
> -RRECOMMENDS_${PN{ += "${PN}-data "
> +RDEPENDS_${PN{ += "${PN}-data "
>   FILES_${PN}-data = "${datadir}/pixmaps ${datadir}/sounds ${datadir}/icons"
>   FILES_${PN}-dev += "${libdir}/${PN}/*.la"

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Stefan Schmidt]

Hello.

On Thu, 2008-10-23 at 15:29, Koen Kooi wrote:
> On 23-10-2008 14:41, Stefan Schmidt wrote:
>>
>> I have a user bug report here that pidgin segfaults without pidgin-data
>> installed:
>> http://trac.freesmartphone.org/ticket/170
>>
>> In pidgin.inc it only RRECOMMANDS pidgin-data, but not RDEPENDS on it.
>> Patch below is what I would push if nobody objects.
>
> That patch is no good. The real fix is to move the 2 files pidgin needs  
> from -data to the main package.

As you already know that two files are missing, can you name them so I can
cookup a patch?

> Also: if pidgin-data is not getting installed when installing pidgin  
> something is wrong with your feeds.

Hmm, It seems I need a better understanding then. From where comes the dep from
pidgin on pidgin-data? Do I miss some OE magic here?

Besides that it could good be that the feed is broken in that regard. Time to
fix it.

regards
Stefan Schmidt

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Koen Kooi]

On 23-10-2008 15:55, Stefan Schmidt wrote:
> Hello.
>
> On Thu, 2008-10-23 at 15:29, Koen Kooi wrote:
>> On 23-10-2008 14:41, Stefan Schmidt wrote:
>>> I have a user bug report here that pidgin segfaults without pidgin-data
>>> installed:
>>> http://trac.freesmartphone.org/ticket/170
>>>
>>> In pidgin.inc it only RRECOMMANDS pidgin-data, but not RDEPENDS on it.
>>> Patch below is what I would push if nobody objects.
>> That patch is no good. The real fix is to move the 2 files pidgin needs
>> from -data to the main package.
>
> As you already know that two files are missing, can you name them so I can
> cookup a patch?

iirc it's the .desktop and some other file, I straced a few weeks ago, 
but I'm fuzzy on the details

>
>> Also: if pidgin-data is not getting installed when installing pidgin
>> something is wrong with your feeds.
>
> Hmm, It seems I need a better understanding then. From where comes the dep from
> pidgin on pidgin-data? Do I miss some OE magic here?
>
> Besides that it could good be that the feed is broken in that regard. Time to
> fix it.
>
> regards
> Stefan Schmidt

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Stefan Schmidt]

Hello.

On Thu, 2008-10-23 at 17:16, Koen Kooi wrote:
> On 23-10-2008 15:55, Stefan Schmidt wrote:
>>
>> As you already know that two files are missing, can you name them so I can
>> cookup a patch?
>
> iirc it's the .desktop and some other file, I straced a few weeks ago,  
> but I'm fuzzy on the details

For now I fixed the wrong bracket only. Not sure if I'll come to trace the files
down. Let's see if I can get the user motivated doing it. :)

regards
Stefan Schmidt

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Koen Kooi]

On 23-10-2008 14:41, Stefan Schmidt wrote:
> Hello.
>
> I have a user bug report here that pidgin segfaults without pidgin-data
> installed:
> http://trac.freesmartphone.org/ticket/170
>
> In pidgin.inc it only RRECOMMANDS pidgin-data, but not RDEPENDS on it.
> Patch below is what I would push if nobody objects.

Actually...


> regards
> Stefan Schmidt
>
> diff --git a/packages/pidgin/pidgin.inc b/packages/pidgin/pidgin.inc
> index db66d13..e3c35a7 100644
> --- a/packages/pidgin/pidgin.inc
> +++ b/packages/pidgin/pidgin.inc
> @@ -44,7 +44,7 @@ FILES_finch-dbg     = "${bindir}/.debug/finch \
>
>   FILES_${PN} = "${bindir} ${datadir}/${PN} ${libdir}/${PN}/*.so \
>   	       ${datadir}/applications"
> -RRECOMMENDS_${PN{ += "${PN}-data "

Typo alert! it's ${PN} (note the closing bracket)

> +RDEPENDS_${PN{ += "${PN}-data "

Another typo alert!

>   FILES_${PN}-data = "${datadir}/pixmaps ${datadir}/sounds ${datadir}/icons"
>   FILES_${PN}-dev += "${libdir}/${PN}/*.la"

Re: Pidgin needs to RDEPENDS on pidgin-data?

[Stefan Schmidt]

Hello.

On Thu, 2008-10-23 at 17:15, Koen Kooi wrote:
> On 23-10-2008 14:41, Stefan Schmidt wrote:
>>
>> diff --git a/packages/pidgin/pidgin.inc b/packages/pidgin/pidgin.inc
>> index db66d13..e3c35a7 100644
>> --- a/packages/pidgin/pidgin.inc
>> +++ b/packages/pidgin/pidgin.inc
>> @@ -44,7 +44,7 @@ FILES_finch-dbg     = "${bindir}/.debug/finch \
>>
>>   FILES_${PN} = "${bindir} ${datadir}/${PN} ${libdir}/${PN}/*.so \
>>   	       ${datadir}/applications"
>> -RRECOMMENDS_${PN{ += "${PN}-data "
>
> Typo alert! it's ${PN} (note the closing bracket)

Darn, directly in front of my eyes and I missed it. Just pushed a fix for this.

>> +RDEPENDS_${PN{ += "${PN}-data "
>
> Another typo alert!

Sure, a stupid copy. :)

regards
Stefan Schmidt