[patch review] bitbake.conf: Introduce STAGING_BINDIR_CROSS_BASEPKG

[patch review] bitbake.conf: Introduce STAGING_BINDIR_CROSS_BASEPKG

[Stanislav Brabec]

Hallo core developers.

Please approve or comment following patch of bitbake.conf.

It introduces STAGING_BINDIR_CROSS_BASEPKG pointing to
STAGING_BINDIR_CROSS of base packages and adds it to PATH (after
STAGING_BINDIR_CROSS).

It fixes highly base package cross bindir lookup while compiling highly
optimized packages. Actually it's mplayer and sdl-config lookup.

Note that similar patch adding highly optimized pkgconfig dir to
PKG_CONFIG_PATH may be needed in future.

diff --git a/conf/bitbake.conf b/conf/bitbake.conf
index 4273152..678062a 100644
--- a/conf/bitbake.conf
+++ b/conf/bitbake.conf
@@ -245,6 +245,7 @@ STAGING_DIR = "${TMPDIR}/staging"
 STAGING_DIR_NATIVE = "${STAGING_DIR}/${BUILD_SYS}"
 STAGING_BINDIR_NATIVE = "${STAGING_DIR_NATIVE}${layout_bindir}"
 STAGING_BINDIR_CROSS  = "${STAGING_DIR_NATIVE}${layout_bindir}/${MULTIMACH_HOST_SYS}"
+STAGING_BINDIR_CROSS_BASEPKG = "${STAGING_DIR_NATIVE}${layout_bindir}/${BASEPKG_TARGET_SYS}"
 STAGING_LIBDIR_NATIVE = "${STAGING_DIR_NATIVE}${layout_libdir}"
 STAGING_INCDIR_NATIVE = "${STAGING_DIR_NATIVE}${layout_includedir}"
 STAGING_ETCDIR_NATIVE = "${STAGING_DIR_NATIVE}${layout_sysconfdir}"
@@ -337,7 +338,7 @@ EXTRA_IMAGEDEPENDS = ""
 
 CROSS_DIR = "${TMPDIR}/cross/${BASE_PACKAGE_ARCH}"
 CROSS_DATADIR = "${CROSS_DIR}/share"
-PATH_prepend = "${STAGING_BINDIR_CROSS}:${STAGING_DIR_NATIVE}${layout_sbindir}:${STAGING_BINDIR_NATIVE}:${CROSS_DIR}/bin:${STAGING_DIR_NATIVE}${layout_base_sbindir}:${STAGING_DIR_NATIVE}${layout_base_bindir}:"
+PATH_prepend = "${STAGING_BINDIR_CROSS}:${STAGING_BINDIR_CROSS_BASEPKG}:${STAGING_DIR_NATIVE}${layout_sbindir}:${STAGING_BINDIR_NATIVE}:${CROSS_DIR}/bin:${STAGING_DIR_NATIVE}${layout_base_sbindir}:${STAGING_DIR_NATIVE}${layout_base_bindir}:"
 export PATH
 
 ##################################################################



________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus

Re: [patch review] bitbake.conf: Introduce STAGING_BINDIR_CROSS_BASEPKG

[Leon Woestenberg]

Hello,

On Sat, Nov 8, 2008 at 12:05 AM, Stanislav Brabec <utx@penguin.cz> wrote:
> It introduces STAGING_BINDIR_CROSS_BASEPKG pointing to
> STAGING_BINDIR_CROSS of base packages and adds it to PATH (after
> STAGING_BINDIR_CROSS).
>
> It fixes highly base package cross bindir lookup while compiling highly
> optimized packages. Actually it's mplayer and sdl-config lookup.
>
I do not understand what exactly you fix.

Could you explain more elaborately?

Thanks,
-- 
Leon

Re: [patch review] bitbake.conf: Introduce STAGING_BINDIR_CROSS_BASEPKG

[Koen Kooi]

On 08-11-2008 21:04, Leon Woestenberg wrote:
> Hello,
>
> On Sat, Nov 8, 2008 at 12:05 AM, Stanislav Brabec<utx@penguin.cz>  wrote:
>> It introduces STAGING_BINDIR_CROSS_BASEPKG pointing to
>> STAGING_BINDIR_CROSS of base packages and adds it to PATH (after
>> STAGING_BINDIR_CROSS).
>>
>> It fixes highly base package cross bindir lookup while compiling highly
>> optimized packages. Actually it's mplayer and sdl-config lookup.
>>
> I do not understand what exactly you fix.
>
> Could you explain more elaborately?

For pxa270 CPUs mplayer will enable iwmmxt extensions and do 
PACKAGE_ARCH = "iwmmxt", while other packages in the same build retain 
their default PACKAGE_ARCH (armv5te). So the sdl-config script wouldn't 
be in staging/iwmmxt-foo-linux, but in staging/armv5te-foo-linux. Since 
STAGING_BINDIR_CROSS is composed using PACKAGE_ARCH we need to point it 
'manually' to the armv5te one.

regards,

Koen