gdb-cross-sdk hacking around gcc-4.3 warnings?

gdb-cross-sdk hacking around gcc-4.3 warnings?

[Tom Rini]

Hello, I see that in
http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
If so, could we replace that by importing
http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
instead?  I'll do the work, just don't want to step on anyones toes if
there was a different reason behind the change, thanks!

-- 
Tom Rini

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Khem Raj]

IIRC yes. if thats the only patch needed then please go ahead and reenable it.

On Thu, Dec 4, 2008 at 12:02 AM, Tom Rini <trini@kernel.crashing.org> wrote:
> Hello, I see that in
> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
> If so, could we replace that by importing
> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
> instead?  I'll do the work, just don't want to step on anyones toes if
> there was a different reason behind the change, thanks!
>
> --
> Tom Rini
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Koen Kooi]

On 04-12-08 09:02, Tom Rini wrote:
> Hello, I see that in
> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
> If so, could we replace that by importing
> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
> instead?  I'll do the work, just don't want to step on anyones toes if
> there was a different reason behind the change, thanks!

I'm not fond of enabling -Werror in crossbuilders, since simple, 
harmless warnings will break your build.
If you are *completely* sure your patch removes *all* -Werror related 
problems, then go ahead.

regards,

Koen

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Koen Kooi]

On 04-12-08 09:02, Tom Rini wrote:
> Hello, I see that in
> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
> If so, could we replace that by importing
> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
> instead?  I'll do the work, just don't want to step on anyones toes if
> there was a different reason behind the change, thanks!

Also: ~lart me for not stating *why* the commit was made.

Maybe we should follow the cairo commit message policy that requires 
people to add a short 'why' section in each commit message to reduce 
confusion.

regards,

Koen

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Tom Rini]

On Thu, Dec 04, 2008 at 06:32:33PM +0100, Koen Kooi wrote:
[snip]
> Maybe we should follow the cairo commit message policy that requires  
> people to add a short 'why' section in each commit message to reduce  
> confusion.

This sounds good.  Is it possible to modify the template git gives you
when you're doing a commit?

-- 
Tom Rini

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Tom Rini]

On Thu, Dec 04, 2008 at 06:06:03PM +0100, Koen Kooi wrote:
> On 04-12-08 09:02, Tom Rini wrote:
>> Hello, I see that in
>> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
>> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
>> If so, could we replace that by importing
>> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
>> instead?  I'll do the work, just don't want to step on anyones toes if
>> there was a different reason behind the change, thanks!
>
> I'm not fond of enabling -Werror in crossbuilders, since simple,  
> harmless warnings will break your build.
> If you are *completely* sure your patch removes *all* -Werror related  
> problems, then go ahead.

Checked with an ARM and x86 build now, so yes, I'm pretty confident.
Tangentally, what're a powerpc / avr32 target that should build (I'll fix
db1200 / MIPS if that's broken, again) ?

-- 
Tom Rini

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Khem Raj]

> Tangentally, what're a powerpc / avr32 target that should build (I'll fix
> db1200 / MIPS if that's broken, again) ?

mpc8313e-rdb is what I have used in past.

-Khem

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Koen Kooi]

On 04-12-08 20:28, Tom Rini wrote:
> On Thu, Dec 04, 2008 at 06:06:03PM +0100, Koen Kooi wrote:
>> On 04-12-08 09:02, Tom Rini wrote:
>>> Hello, I see that in
>>> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
>>> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
>>> If so, could we replace that by importing
>>> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
>>> instead?  I'll do the work, just don't want to step on anyones toes if
>>> there was a different reason behind the change, thanks!
>> I'm not fond of enabling -Werror in crossbuilders, since simple,
>> harmless warnings will break your build.
>> If you are *completely* sure your patch removes *all* -Werror related
>> problems, then go ahead.
>
> Checked with an ARM and x86 build now, so yes, I'm pretty confident.
> Tangentally, what're a powerpc / avr32 target that should build (I'll fix
> db1200 / MIPS if that's broken, again) ?

Which arm? IIRC it broke on an armv7 build.

regards,

Koen

Re: gdb-cross-sdk hacking around gcc-4.3 warnings?

[Tom Rini]

On Thu, Dec 04, 2008 at 09:33:51PM +0100, Koen Kooi wrote:
> On 04-12-08 20:28, Tom Rini wrote:
>> On Thu, Dec 04, 2008 at 06:06:03PM +0100, Koen Kooi wrote:
>>> On 04-12-08 09:02, Tom Rini wrote:
>>>> Hello, I see that in
>>>> http://gitweb.openembedded.net/?p=openembedded.git;a=commit;h=6348b3baf7a61fc07626a3ecb29b539d438cfb4f
>>>> we dropped -Werror from gdb-cross-sdk.  Was this for gcc-4.3 support?
>>>> If so, could we replace that by importing
>>>> http://patches.ubuntu.com/g/gdb/extracted/gcc-4.3-build-error.patch
>>>> instead?  I'll do the work, just don't want to step on anyones toes if
>>>> there was a different reason behind the change, thanks!
>>> I'm not fond of enabling -Werror in crossbuilders, since simple,
>>> harmless warnings will break your build.
>>> If you are *completely* sure your patch removes *all* -Werror related
>>> problems, then go ahead.
>>
>> Checked with an ARM and x86 build now, so yes, I'm pretty confident.
>> Tangentally, what're a powerpc / avr32 target that should build (I'll fix
>> db1200 / MIPS if that's broken, again) ?
>
> Which arm? IIRC it broke on an armv7 build.

I saw it break, then fixed it, on v6

-- 
Tom Rini