All of lore.kernel.org
 help / color / mirror / Atom feed
* disable hash-style=gnu for mips machines
@ 2008-12-05 19:35 Khem Raj
  2008-12-05 20:09 ` Koen Kooi
  0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2008-12-05 19:35 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

Hi

mips dynamic section is not compatible with gnu hash style there we need
to disable this option when building for mips targets. Attached patch
(tested on eglibc) fixes the problem.

OK for dev ?

Thanks

-Khem


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1734 bytes --]

diff --git a/conf/distro/include/angstrom-eglibc.inc b/conf/distro/include/angstrom-eglibc.inc
index 1d38e5f..c0d87a4 100644
--- a/conf/distro/include/angstrom-eglibc.inc
+++ b/conf/distro/include/angstrom-eglibc.inc
@@ -29,7 +29,7 @@ BUILD_OPTIMIZATION = "-Os"
 BUILD_OPTIMIZATION_pn-perl = "-O1"
 BUILD_OPTIMIZATION_sparc = "-O2"
 
-TARGET_LINK_HASH_STYLE = "-Wl,--hash-style=gnu"
+TARGET_LINK_HASH_STYLE = "${@['-Wl,--hash-style=gnu',''][bb.data.getVar('TARGET_ARCH',d,1) in ['mips', 'mipsel']]}"
 
 CXXFLAGS += "-fvisibility-inlines-hidden"
 
diff --git a/conf/distro/include/angstrom-glibc.inc b/conf/distro/include/angstrom-glibc.inc
index fdb59f3..b14f880 100644
--- a/conf/distro/include/angstrom-glibc.inc
+++ b/conf/distro/include/angstrom-glibc.inc
@@ -33,7 +33,7 @@ BUILD_OPTIMIZATION_pn-perl = "-O1"
 BUILD_OPTIMIZATION_pn-glibc = "-O2"
 BUILD_OPTIMIZATION_sparc = "-O2"
 
-TARGET_LINK_HASH_STYLE = "-Wl,--hash-style=gnu"
+TARGET_LINK_HASH_STYLE = "${@['-Wl,--hash-style=gnu',''][bb.data.getVar('TARGET_ARCH',d,1) in ['mips', 'mipsel']]}"
 
 CXXFLAGS += "-fvisibility-inlines-hidden"
 
diff --git a/conf/distro/include/angstrom-uclibc.inc b/conf/distro/include/angstrom-uclibc.inc
index 8383ddc..71b8862 100644
--- a/conf/distro/include/angstrom-uclibc.inc
+++ b/conf/distro/include/angstrom-uclibc.inc
@@ -33,7 +33,7 @@ BUILD_OPTIMIZATION = "-Os"
 #Note that this testing was done without the gcc-pr32889.patch.
 FULL_OPTIMIZATION_avr32 = "-Os -fomit-frame-pointer"
 
-TARGET_LINK_HASH_STYLE = "-Wl,--hash-style=gnu"
+TARGET_LINK_HASH_STYLE = "${@['-Wl,--hash-style=gnu',''][bb.data.getVar('TARGET_ARCH',d,1) in ['mips', 'mipsel']]}"
 
 CXXFLAGS += "-fvisibility-inlines-hidden"
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: disable hash-style=gnu for mips machines
  2008-12-05 19:35 disable hash-style=gnu for mips machines Khem Raj
@ 2008-12-05 20:09 ` Koen Kooi
  0 siblings, 0 replies; 2+ messages in thread
From: Koen Kooi @ 2008-12-05 20:09 UTC (permalink / raw)
  To: openembedded-devel

On 05-12-08 20:35, Khem Raj wrote:
> Hi
>
> mips dynamic section is not compatible with gnu hash style there we need
> to disable this option when building for mips targets. Attached patch
> (tested on eglibc) fixes the problem.
>
> OK for dev ?

Looks OK to me.

regards,

Koen

>
> Thanks
>
> -Khem
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-05 20:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-05 19:35 disable hash-style=gnu for mips machines Khem Raj
2008-12-05 20:09 ` Koen Kooi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.