All of lore.kernel.org
 help / color / mirror / Atom feed
* BUG: amdgpu: NULL pointer dereference introduced in 5.9-rc1
@ 2020-09-30 20:13 ` Dirk Gouders
  0 siblings, 0 replies; 12+ messages in thread
From: Dirk Gouders @ 2020-09-30 20:13 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Evan Quan, Hawking Zhang, Christian König, amd-gfx,
	linux-kernel

Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir)
introduced a NULL pointer dereference when booting with
amdgpu.discovery=0.

For amdgpu.discovery=0 that commit effectively removed the call of
vega10_reg_base_init(adev), so I tested the correctness of the bisect
session by restoring that function call for amdgpu_discovery == 0 and with
that change, the NULL pointer dereference does not occur:

diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 84d811b6e48b..2e93c5e1e7e6 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -699,7 +699,8 @@ static void soc15_reg_base_init(struct amdgpu_device *adev)
                                         "fallback to legacy init method\n");
                                vega10_reg_base_init(adev);
                        }
-               }
+               } else
+                       vega10_reg_base_init(adev);
                break;
        case CHIP_VEGA20:
                vega20_reg_base_init(adev);

Dirk
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-10-01 20:48 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-30 20:13 BUG: amdgpu: NULL pointer dereference introduced in 5.9-rc1 Dirk Gouders
2020-09-30 20:13 ` Dirk Gouders
2020-10-01 14:05 ` Alex Deucher
2020-10-01 14:05   ` Alex Deucher
2020-10-01 19:55   ` [PATCH 0/1] drm/amdgpu: fix NULL pointer dereference for Renoir Dirk Gouders
2020-10-01 19:55     ` Dirk Gouders
2020-10-01 19:55   ` [PATCH 1/1] " Dirk Gouders
2020-10-01 19:55     ` Dirk Gouders
2020-10-01 20:30     ` Dirk Gouders
2020-10-01 20:30       ` Dirk Gouders
2020-10-01 20:47       ` Alex Deucher
2020-10-01 20:47         ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.