Re: [PATCH] Fix compilation of Openembedded on ppc64

Re: [PATCH] Fix compilation of Openembedded on ppc64

[Michael 'Mickey' Lauer]

sent to org.oe.dev, thanks.

-- 
:M:

Re: [PATCH] Fix compilation of Openembedded on ppc64

[Koen Kooi]

On 09-12-08 11:02, Michael 'Mickey' Lauer wrote:
> sent to org.oe.dev, thanks.

Could you please fix the commit message next time?

Re: [PATCH] Fix compilation of Openembedded on ppc64

[Michael 'Mickey' Lauer]

Am Tuesday 09 December 2008 11:43:30 schrieb Koen Kooi:
> On 09-12-08 11:02, Michael 'Mickey' Lauer wrote:
> > sent to org.oe.dev, thanks.
>
> Could you please fix the commit message next time?

Do you really think it's worth it? Not a strong opinion here, but this kind of 
destroys the elegant workflow with 'git am' and I think we should relax the 
policy for patches we receive by mail.

-- 
:M:

Re: [PATCH] Fix compilation of Openembedded on ppc64

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

Michael 'Mickey' Lauer wrote:
> Am Tuesday 09 December 2008 11:43:30 schrieb Koen Kooi:
>> On 09-12-08 11:02, Michael 'Mickey' Lauer wrote:
>>> sent to org.oe.dev, thanks.
>> Could you please fix the commit message next time?
> 
> Do you really think it's worth it? Not a strong opinion here, but this kind of 
> destroys the elegant workflow with 'git am' and I think we should relax the 
> policy for patches we receive by mail.

I haven't looked at the commit in question.

We should strive to have all the commit messages use the same format. 
The occasional exception is OK, but I don't want to see specific 
exceptions added to the policy. Also, if the message is really bad, it 
should be fixed. If it is marginal, let it go, but remind the source to 
do better next time.

Does this make sense?

Philip

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: [PATCH] Fix compilation of Openembedded on ppc64

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]


Op 9 dec 2008, om 19:03 heeft Michael Buesch het volgende geschreven:

> On Tuesday 09 December 2008 13:42:04 Koen Kooi wrote:
>> git-am should only be used for patches that are 100% correct, if they
>> aren't, fixup is needed.
>
> Could you give me some hint on what you consider 100% correct,
> so I can do it correctly next time?

http://wiki.openembedded.net/index.php/Commit_Policy

regards,

Koen
>
>
> -- 
> Greetings, Michael.
>


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 193 bytes --]