All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix missing groups in udevd
@ 2009-01-28 11:25 Petr Štetiar
  2009-01-28 11:57 ` Koen Kooi
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Štetiar @ 2009-01-28 11:25 UTC (permalink / raw)
  To: openembedded-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]

Fix for udevd warning messages when I plug in USB stick:

	Starting udevudevd[585]: lookup_group: specified group 'scanner' unknown
	udevd[585]: lookup_group: specified group 'nvram' unknown
	udevd[585]: lookup_user: specified user 'tss' unknown
	udevd[585]: lookup_group: specified group 'fuse' unknown
	udevd[585]: lookup_group: specified group 'kvm' unknown
	udevd[585]: lookup_group: specified group 'rdma' unknown
	udevd version 124 started

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 packages/udev/udev-124/permissions.rules |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/packages/udev/udev-124/permissions.rules b/packages/udev/udev-124/permissions.rules
index 205b733..fbc9974 100644
--- a/packages/udev/udev-124/permissions.rules
+++ b/packages/udev/udev-124/permissions.rules
@@ -32,12 +32,12 @@ KERNEL=="nht[0-9]*", 				GROUP="tape"
 # SCSI devices
 KERNEL=="sr[0-9]*", IMPORT{program}="cdrom_id --export $tempnode"
 SUBSYSTEMS=="scsi", ATTRS{type}=="1",				GROUP="tape"
-SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="HP",	GROUP="scanner"
-SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="Epson",	GROUP="scanner"
-SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="EPSON",	GROUP="scanner"
+SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="HP",	GROUP="plugdev"
+SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="Epson",	GROUP="plugdev"
+SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="EPSON",	GROUP="plugdev"
 SUBSYSTEMS=="scsi", ATTRS{type}=="4",				GROUP="cdrom"
 SUBSYSTEMS=="scsi", ATTRS{type}=="5",				GROUP="cdrom"
-SUBSYSTEMS=="scsi", ATTRS{type}=="6",				GROUP="scanner"
+SUBSYSTEMS=="scsi", ATTRS{type}=="6",				GROUP="plugdev"
 SUBSYSTEMS=="scsi", ATTRS{type}=="8",				GROUP="tape"
 
 # USB devices
@@ -86,10 +86,10 @@ KERNEL=="inotify",		MODE="0666"
 KERNEL=="sgi_fetchop",		MODE="0666"
 KERNEL=="sonypi",		MODE="0666"
 KERNEL=="agpgart",				GROUP="video"
-KERNEL=="nvram",				GROUP="nvram"
+KERNEL=="nvram",				GROUP="staff"
 KERNEL=="rtc|rtc[0-9]*",			GROUP="audio"
-KERNEL=="tpm*",			MODE="0600",	OWNER="tss", GROUP="tss"
-KERNEL=="fuse",					GROUP="fuse"
+KERNEL=="tpm*",			MODE="0600",	OWNER="root", GROUP="staff"
+KERNEL=="fuse",					GROUP="staff"
 KERNEL=="kqemu",		MODE="0666"
 KERNEL=="kvm",					GROUP="kvm"
 KERNEL=="tun",			MODE="0666",
@@ -98,9 +98,9 @@ KERNEL=="cdemu[0-9]*",				GROUP="cdrom"
 KERNEL=="pktcdvd[0-9]*",			GROUP="cdrom"
 KERNEL=="pktcdvd",		MODE="0644"
 
-KERNEL=="uverbs*",				GROUP="rdma"
-KERNEL=="ucm*",					GROUP="rdma"
-KERNEL=="rdma_ucm",				GROUP="rdma"
+KERNEL=="uverbs*",				GROUP="staff"
+KERNEL=="ucm*",					GROUP="staff"
+KERNEL=="rdma_ucm",				GROUP="staff"
 
 # printers and parallel devices
 SUBSYSTEM=="printer",				GROUP="lp"
-- 
1.5.4.3




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix missing groups in udevd
  2009-01-28 11:25 [PATCH] fix missing groups in udevd Petr Štetiar
@ 2009-01-28 11:57 ` Koen Kooi
  2009-01-28 12:11   ` Petr Stetiar
  0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2009-01-28 11:57 UTC (permalink / raw)
  To: openembedded-devel

On 28-01-09 12:25, Petr Štetiar wrote:
> Fix for udevd warning messages when I plug in USB stick:
>
> 	Starting udevudevd[585]: lookup_group: specified group 'scanner' unknown
> 	udevd[585]: lookup_group: specified group 'nvram' unknown
> 	udevd[585]: lookup_user: specified user 'tss' unknown
> 	udevd[585]: lookup_group: specified group 'fuse' unknown
> 	udevd[585]: lookup_group: specified group 'kvm' unknown
> 	udevd[585]: lookup_group: specified group 'rdma' unknown
> 	udevd version 124 started
>
> Signed-off-by: Petr Štetiar<ynezz@true.cz>

Would it make sense to have udev install those groups? If not, your 
patch looks OK, but it's missing a PR bump for udev 124.

regards,

Koen



> ---
>   packages/udev/udev-124/permissions.rules |   20 ++++++++++----------
>   1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/packages/udev/udev-124/permissions.rules b/packages/udev/udev-124/permissions.rules
> index 205b733..fbc9974 100644
> --- a/packages/udev/udev-124/permissions.rules
> +++ b/packages/udev/udev-124/permissions.rules
> @@ -32,12 +32,12 @@ KERNEL=="nht[0-9]*", 				GROUP="tape"
>   # SCSI devices
>   KERNEL=="sr[0-9]*", IMPORT{program}="cdrom_id --export $tempnode"
>   SUBSYSTEMS=="scsi", ATTRS{type}=="1",				GROUP="tape"
> -SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="HP",	GROUP="scanner"
> -SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="Epson",	GROUP="scanner"
> -SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="EPSON",	GROUP="scanner"
> +SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="HP",	GROUP="plugdev"
> +SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="Epson",	GROUP="plugdev"
> +SUBSYSTEMS=="scsi", ATTRS{type}=="3", ATTRS{vendor}=="EPSON",	GROUP="plugdev"
>   SUBSYSTEMS=="scsi", ATTRS{type}=="4",				GROUP="cdrom"
>   SUBSYSTEMS=="scsi", ATTRS{type}=="5",				GROUP="cdrom"
> -SUBSYSTEMS=="scsi", ATTRS{type}=="6",				GROUP="scanner"
> +SUBSYSTEMS=="scsi", ATTRS{type}=="6",				GROUP="plugdev"
>   SUBSYSTEMS=="scsi", ATTRS{type}=="8",				GROUP="tape"
>
>   # USB devices
> @@ -86,10 +86,10 @@ KERNEL=="inotify",		MODE="0666"
>   KERNEL=="sgi_fetchop",		MODE="0666"
>   KERNEL=="sonypi",		MODE="0666"
>   KERNEL=="agpgart",				GROUP="video"
> -KERNEL=="nvram",				GROUP="nvram"
> +KERNEL=="nvram",				GROUP="staff"
>   KERNEL=="rtc|rtc[0-9]*",			GROUP="audio"
> -KERNEL=="tpm*",			MODE="0600",	OWNER="tss", GROUP="tss"
> -KERNEL=="fuse",					GROUP="fuse"
> +KERNEL=="tpm*",			MODE="0600",	OWNER="root", GROUP="staff"
> +KERNEL=="fuse",					GROUP="staff"
>   KERNEL=="kqemu",		MODE="0666"
>   KERNEL=="kvm",					GROUP="kvm"
>   KERNEL=="tun",			MODE="0666",
> @@ -98,9 +98,9 @@ KERNEL=="cdemu[0-9]*",				GROUP="cdrom"
>   KERNEL=="pktcdvd[0-9]*",			GROUP="cdrom"
>   KERNEL=="pktcdvd",		MODE="0644"
>
> -KERNEL=="uverbs*",				GROUP="rdma"
> -KERNEL=="ucm*",					GROUP="rdma"
> -KERNEL=="rdma_ucm",				GROUP="rdma"
> +KERNEL=="uverbs*",				GROUP="staff"
> +KERNEL=="ucm*",					GROUP="staff"
> +KERNEL=="rdma_ucm",				GROUP="staff"
>
>   # printers and parallel devices
>   SUBSYSTEM=="printer",				GROUP="lp"
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fix missing groups in udevd
  2009-01-28 11:57 ` Koen Kooi
@ 2009-01-28 12:11   ` Petr Stetiar
  0 siblings, 0 replies; 3+ messages in thread
From: Petr Stetiar @ 2009-01-28 12:11 UTC (permalink / raw)
  To: openembedded-devel

Koen Kooi <k.kooi@student.utwente.nl> [2009-01-28 12:57:23]:

> On 28-01-09 12:25, Petr Štetiar wrote:
> >Fix for udevd warning messages when I plug in USB stick:
> >
> >	Starting udevudevd[585]: lookup_group: specified group 'scanner' 
> >	unknown
> >	udevd[585]: lookup_group: specified group 'nvram' unknown
> >	udevd[585]: lookup_user: specified user 'tss' unknown
> >	udevd[585]: lookup_group: specified group 'fuse' unknown
> >	udevd[585]: lookup_group: specified group 'kvm' unknown
> >	udevd[585]: lookup_group: specified group 'rdma' unknown
> >	udevd version 124 started
> >
> >Signed-off-by: Petr Štetiar<ynezz@true.cz>
> 
> Would it make sense to have udev install those groups? If not, your 
> patch looks OK, but it's missing a PR bump for udev 124.

Yep, I was thinking about the new groups also and thinking about it again,
it might be a better solution for the future udev releases also.

I can't decide what's better, so I rather sent this patch.

-- ynezz



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-01-28 12:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 11:25 [PATCH] fix missing groups in udevd Petr Štetiar
2009-01-28 11:57 ` Koen Kooi
2009-01-28 12:11   ` Petr Stetiar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.