Re: [PATCH 3/6] package.bbclass, package_ipk.bbclass: add dynamic depends on locale packages (ipk specific)

[Koen Kooi <k.kooi@student.utwente.nl>]

On 12-02-09 17:38, Otavio Salvador wrote:
> ---
>   classes/package.bbclass     |   10 ----------
>   classes/package_ipk.bbclass |    4 ++++
>   2 files changed, 4 insertions(+), 10 deletions(-)

I'd like a bigger explanation what does wants to do and what the impact 
of it is.

regards,

Koen




>
> diff --git a/classes/package.bbclass b/classes/package.bbclass
> index a7cdb5f..5559592 100644
> --- a/classes/package.bbclass
> +++ b/classes/package.bbclass
> @@ -293,16 +293,6 @@ python package_do_split_locales() {
>   		bb.data.setVar('DESCRIPTION_' + pkg, '%s translation for %s' % (l, pn), d)
>
>   	bb.data.setVar('PACKAGES', ' '.join(packages), d)
> -
> -	# Disabled by RP 18/06/07
> -	# Wildcards aren't supported in debian
> -	# They break with ipkg since glibc-locale* will mean that
> -	# glibc-localedata-translit* won't install as a dependency
> -	# for some other package which breaks meta-toolchain
> -	# Probably breaks since virtual-locale- isn't provided anywhere
> -	#rdep = (bb.data.getVar('RDEPENDS_%s' % mainpkg, d, 1) or bb.data.getVar('RDEPENDS', d, 1) or "").split()
> -	#rdep.append('%s-locale*' % pn)
> -	#bb.data.setVar('RDEPENDS_%s' % mainpkg, ' '.join(rdep), d)
>   }
>
>   python populate_packages () {
> diff --git a/classes/package_ipk.bbclass b/classes/package_ipk.bbclass
> index 3a97729..2d28cf8 100644
> --- a/classes/package_ipk.bbclass
> +++ b/classes/package_ipk.bbclass
> @@ -244,6 +244,10 @@ python do_package_ipk () {
>   		rprovides = (bb.data.getVar("RPROVIDES", localdata, 1) or "").split()
>   		rreplaces = (bb.data.getVar("RREPLACES", localdata, 1) or "").split()
>   		rconflicts = (bb.data.getVar("RCONFLICTS", localdata, 1) or "").split()
> +
> +		if pkgname.find('-locale-') == -1:
> +			rdepends.append('%s-locale*' % pkgname)
> +
>   		if rdepends:
>   			ctrlfile.write("Depends: %s\n" % ", ".join(rdepends))
>   		if rsuggests: