Re: [PATCH 5/6] sun-jre6: add 1.6.0.10

[Koen Kooi <k.kooi@student.utwente.nl>]

On 13-02-09 00:48, Otavio Salvador wrote:
> Koen Kooi<k.kooi@student.utwente.nl>  writes:
>
>> On 12-02-09 17:38, Otavio Salvador wrote:
>>> Signed-off-by: Otavio Salvador<otavio@ossystems.com.br>
>>> ---
>> NACK:
>>
>>> +PACKAGES =+ "${PN}-plugin"
>>> +
>>> +FILES_${PN} = "/usr/"
>>> +FILES_${PN}-dbg += "/usr/*/.debug /usr/*/*/.debug /usr/*/*/*/.debug /usr/*/*/*/*/.debug /usr/*/*/*/*/*/.debug"
>>> +FILES_${PN}-plugin = "${libdir}/firefox-3.0.1/plugins/* ${libdir}/sun-java6-${PV}/plugin/i386/ns7/libjavaplugin_oji.so"
>> it would be better to install the plugin to /usr/lib/mozilla/plugins
>> and have a postinst that symlinks it to ${libdir}/firefox-*,
>> ${libdir}/fennec-*, ${libdir}/iceweasle when those are present. That
>> way other browser implement NPAPI (webkit...) can use the one in
>> mozilla/plugins.
>
> I've not added the symbolic links since it is quite easy to make firefox
> to use that dir. In fact, it has already been done at
> d09c754ec52a3f09f1cad6a34d12b9ef7283bc17 and can be done for others I
> think.

Please do :)

> I've fixed the style issues and the plugin installation as you've
> spot. Please check and ack if it is all OK.

ACK