[patch] Fix for nfs-utils tools build

[patch] Fix for nfs-utils tools build

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi

Currently nfs-utils 1.1.2 does not build correctly. The reason is that
there are certain tools which are passed in CFLAGS in their makefiles
even though they are to be build using host compiler for them to be run
on host machine. 

Current builds use target headers to build them due to CFLAGS funkiness
where we have alters system include dirs. This goes ok with arm and x86
but on mips you see errors.

This patch fixes the issue

OK for .dev

Thx

-Khem



[-- Attachment #2: nfs-utils-tools-unset-cflags.patch --]
[-- Type: text/x-diff, Size: 3298 bytes --]

Index: nfs-utils-1.1.2/tools/Makefile.am
===================================================================
--- nfs-utils-1.1.2.orig/tools/Makefile.am	2008-03-14 08:46:29.000000000 -0700
+++ nfs-utils-1.1.2/tools/Makefile.am	2009-03-04 01:58:50.000000000 -0800
@@ -5,7 +5,10 @@
 if CONFIG_RPCGEN
 OPTDIRS += rpcgen
 endif
-
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 SUBDIRS = locktest rpcdebug nlmtest $(OPTDIRS)
 
 MAINTAINERCLEANFILES = Makefile.in
Index: nfs-utils-1.1.2/tools/locktest/Makefile.am
===================================================================
--- nfs-utils-1.1.2.orig/tools/locktest/Makefile.am	2008-03-14 08:46:29.000000000 -0700
+++ nfs-utils-1.1.2/tools/locktest/Makefile.am	2009-03-04 01:58:50.000000000 -0800
@@ -1,12 +1,13 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 noinst_PROGRAMS = testlk
 testlk_SOURCES = testlk.c
-testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
-testlk_CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
-testlk_LDFLAGS=$(LDFLAGS_FOR_BUILD)
 
 MAINTAINERCLEANFILES = Makefile.in
Index: nfs-utils-1.1.2/tools/nlmtest/Makefile.am
===================================================================
--- nfs-utils-1.1.2.orig/tools/nlmtest/Makefile.am	2008-03-14 08:46:29.000000000 -0700
+++ nfs-utils-1.1.2/tools/nlmtest/Makefile.am	2009-03-04 01:58:50.000000000 -0800
@@ -1,5 +1,8 @@
 ## Process this file with automake to produce Makefile.in
-
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 EXTRA_DIST = \
 	README \
 	host.h \
Index: nfs-utils-1.1.2/tools/rpcgen/Makefile.am
===================================================================
--- nfs-utils-1.1.2.orig/tools/rpcgen/Makefile.am	2008-03-14 08:46:29.000000000 -0700
+++ nfs-utils-1.1.2/tools/rpcgen/Makefile.am	2009-03-04 01:58:50.000000000 -0800
@@ -1,6 +1,10 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 noinst_PROGRAMS = rpcgen
@@ -9,10 +13,6 @@
 		 rpc_util.c rpc_sample.c rpc_output.h rpc_parse.h \
 		 rpc_scan.h rpc_util.h
 
-rpcgen_CFLAGS=$(CFLAGS_FOR_BUILD)
-rpcgen_CPPLAGS=$(CPPFLAGS_FOR_BUILD)
-rpcgen_LDFLAGS=$(LDFLAGS_FOR_BUILD)
-
 MAINTAINERCLEANFILES = Makefile.in
 
 EXTRA_DIST = rpcgen.new.1
Index: nfs-utils-1.1.2/tools/rpcdebug/Makefile.am
===================================================================
--- nfs-utils-1.1.2.orig/tools/rpcdebug/Makefile.am	2009-03-04 02:01:41.000000000 -0800
+++ nfs-utils-1.1.2/tools/rpcdebug/Makefile.am	2009-03-04 02:02:42.000000000 -0800
@@ -1,6 +1,10 @@
 ## Process this file with automake to produce Makefile.in
 
 CC=$(CC_FOR_BUILD)
+CFLAGS=$(CFLAGS_FOR_BUILD)
+CPPFLAGS=$(CPPFLAGS_FOR_BUILD)
+CXXFLAGS=$(CXXFLAGS_FOR_BUILD)
+LDFLAGS=$(LDFLAGS_FOR_BUILD)
 LIBTOOL = @LIBTOOL@ --tag=CC
 
 man8_MANS = rpcdebug.man

Re: [patch] Fix for nfs-utils tools build

[Koen Kooi]

On 04-03-09 11:10, Khem Raj wrote:
> Hi
>
> Currently nfs-utils 1.1.2 does not build correctly. The reason is that
> there are certain tools which are passed in CFLAGS in their makefiles
> even though they are to be build using host compiler for them to be run
> on host machine.
>
> Current builds use target headers to build them due to CFLAGS funkiness
> where we have alters system include dirs. This goes ok with arm and x86
> but on mips you see errors.

I can trigger this on arm as well, FWIW.

> This patch fixes the issue
>
> OK for .dev

Yes :)

regards,

Koen

Re: [patch] Fix for nfs-utils tools build

[Ihar Hrachyshka]

That's what I was going to send to ML now. Voting for this patch.

On Wed, Mar 4, 2009 at 12:10 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Hi
>
> Currently nfs-utils 1.1.2 does not build correctly. The reason is that
> there are certain tools which are passed in CFLAGS in their makefiles
> even though they are to be build using host compiler for them to be run
> on host machine.
>
> Current builds use target headers to build them due to CFLAGS funkiness
> where we have alters system include dirs. This goes ok with arm and x86
> but on mips you see errors.
>
> This patch fixes the issue
>
> OK for .dev
>
> Thx
>
> -Khem
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>