[PATCH] connman: Package python test scripts into connman-test-utils

[PATCH] connman: Package python test scripts into connman-test-utils

[Stefan Schmidt]

Hello.

I would like to get some feedback from other people using connman in OE. I did
the following to package the test scripts which enables you to install them as
separate package.

I'm also thinking about removing some older connman versions. Say everything
below 0.14. (0.13 was broken from upstream)

Feedback?

regards
Stefan Schmidt


From 0b61b8085f4c0cad0ff6137cb66fe71bda0c0a99 Mon Sep 17 00:00:00 2001
From: Stefan Schmidt <stefan@datenfreihafen.org>
Date: Fri, 27 Mar 2009 17:36:46 +0100
Subject: [PATCH] connman: Package python test scripts into connman-test-utils

---
 packages/connman/connman.inc     |    7 ++++++-
 packages/connman/connman_0.15.bb |    2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/packages/connman/connman.inc b/packages/connman/connman.inc
index 5ca7723..dd845f5 100644
--- a/packages/connman/connman.inc
+++ b/packages/connman/connman.inc
@@ -26,6 +26,9 @@ do_configure_append() {
 
 do_install_append() {
     install -m 0755 ${WORKDIR}/connman ${D}${sysconfdir}/init.d/connman
+    install -d ${D}${libdir}/connman/test/
+    for file in test/*; do install -m 0755 $file ${D}${libdir}/connman/test/; done
+    rm ${D}${libdir}/connman/test/Makefile*
 }
 
 do_stage() {
@@ -49,7 +52,7 @@ python populate_packages_prepend() {
 
 PACKAGES_DYNAMIC = "${PN}-plugin-*"
 
-PACKAGES += "${PN}-scripts"
+PACKAGES += "${PN}-scripts ${PN}-test-utils"
 
 FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
             ${sysconfdir} ${sharedstatedir} ${localstatedir} \
@@ -59,6 +62,8 @@ FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
             ${libdir}/bonobo/servers \
             ${datadir}/dbus-1/system-services/*"
 
+FILES_${PN}-test-utils += "${libdir}/connman/test/*"
+
 FILES_${PN}-scripts += "${libdir}/connman/scripts"
 FILES_${PN}-dbg += "${libdir}/connman/*/.debug"
 FILES_${PN}-dev += "${libdir}/connman/*/*.la"
diff --git a/packages/connman/connman_0.15.bb b/packages/connman/connman_0.15.bb
index c2bb92b..4d86500 100644
--- a/packages/connman/connman_0.15.bb
+++ b/packages/connman/connman_0.15.bb
@@ -1,5 +1,5 @@
 require connman.inc
-PR = "r0"
+PR = "r1"
 
 EXTRA_OECONF += "\
   --disable-gtk-doc \
-- 
1.6.2.1

Re: [PATCH] connman: Package python test scripts into connman-test-utils

[Koen Kooi]

On 29-03-09 15:17, Stefan Schmidt wrote:
> Hello.
>
> I would like to get some feedback from other people using connman in OE. I did
> the following to package the test scripts which enables you to install them as
> separate package.

The package is missing RDEPENDS on the necessary python interpreter and 
modules.

regards,

Koen

Re: [PATCH] connman: Package python test scripts into connman-test-utils

[Stefan Schmidt]

Hello.

On Sun, 2009-03-29 at 16:14, Koen Kooi wrote:
> On 29-03-09 15:17, Stefan Schmidt wrote:
>>
>> I would like to get some feedback from other people using connman in OE. I did
>> the following to package the test scripts which enables you to install them as
>> separate package.
>
> The package is missing RDEPENDS on the necessary python interpreter and  
> modules.

Good point. That reminds me of some other recipes that lack such things. Will
have a look at them later.

I'm wondering how I should handle this case as connman itself does not RDEPEND
on python here. Is there a special trick for such FILE_${PN} packages and
RDEPENDS?

regards
Stefan Schmidt

Re: [PATCH] connman: Package python test scripts into connman-test-utils

[Koen Kooi]

On 30-03-09 14:45, Stefan Schmidt wrote:
> Hello.
>
> On Sun, 2009-03-29 at 16:14, Koen Kooi wrote:
>> On 29-03-09 15:17, Stefan Schmidt wrote:
>>>
>>> I would like to get some feedback from other people using connman in OE. I did
>>> the following to package the test scripts which enables you to install them as
>>> separate package.
>>
>> The package is missing RDEPENDS on the necessary python interpreter and
>> modules.
>
> Good point. That reminds me of some other recipes that lack such things. Will
> have a look at them later.
>
> I'm wondering how I should handle this case as connman itself does not RDEPEND
> on python here. Is there a special trick for such FILE_${PN} packages and
> RDEPENDS?

Yes, overrides work on RDEPENDS as well, so RDEPENDS_${PN}-test-utils = 
"python-core python-dbus python-b0rk" will work.

regards,

Koen

Re: [PATCH] connman: Package python test scripts into connman-test-utils

[Stefan Schmidt]

Hello.

On Mon, 2009-03-30 at 16:16, Koen Kooi wrote:
> On 30-03-09 14:45, Stefan Schmidt wrote:
>> Hello.
>>
>> On Sun, 2009-03-29 at 16:14, Koen Kooi wrote:
>>> On 29-03-09 15:17, Stefan Schmidt wrote:
>>>>
>>>> I would like to get some feedback from other people using connman in OE. I did
>>>> the following to package the test scripts which enables you to install them as
>>>> separate package.
>>>
>>> The package is missing RDEPENDS on the necessary python interpreter and
>>> modules.
>>
>> Good point. That reminds me of some other recipes that lack such things. Will
>> have a look at them later.
>>
>> I'm wondering how I should handle this case as connman itself does not RDEPEND
>> on python here. Is there a special trick for such FILE_${PN} packages and
>> RDEPENDS?
>
> Yes, overrides work on RDEPENDS as well, so RDEPENDS_${PN}-test-utils =  
> "python-core python-dbus python-b0rk" will work.

Cool. Another bit I did not know from OE so far. Will make the changes and
resend.

regards
Stefan Schmidt

Re: [PATCH] connman: Package python test scripts into connman-test-utils

[Holger Schurig]

> > Yes, overrides work on RDEPENDS as well, so
> > RDEPENDS_${PN}-test-utils = "python-core python-dbus
> > python-b0rk" will work.
>
> Cool. Another bit I did not know from OE so far. Will make the
> changes and resend.

The way I designed the overrides years ago was that they can 
override *ANY* variable.

However, as I didn't follow OE/bitbake closely during the last 
years, it might be the case that there are now exceptions.