[PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[David Huggins-Daines]

Currently it's not possible to build the stable/2009 branch with GCC 4.3.3,
because it hardcodes a download location for the sources which is not
resolvable (at least from where I am...).  It was suggested to change the
recipe to use GNU_MIRROR.

Unfortunately, bitbake.conf and checksums.ini have a different idea of what
the URI for the main GNU download site is.  This patch fixes these problems.
---
 conf/bitbake.conf         |    2 +-
 recipes/gcc/gcc-4.3.3.inc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/bitbake.conf b/conf/bitbake.conf
index 7c159af..34b0ba9 100644
--- a/conf/bitbake.conf
+++ b/conf/bitbake.conf
@@ -495,7 +495,7 @@ FREESMARTPHONE_GIT = "git://git.freesmartphone.org"
 GENTOO_MIRROR = "http://distro.ibiblio.org/pub/linux/distributions/gentoo/distfiles"
 GNOME_GIT = "git://git.gnome.org"
 GNOME_MIRROR = "http://ftp.gnome.org/pub/GNOME/sources"
-GNU_MIRROR = "ftp://ftp.gnu.org/gnu"
+GNU_MIRROR = "ftp://ftp.gnu.org/pub/gnu"
 GPE_MIRROR = "http://gpe.linuxtogo.org/download/source"
 GPE_EXTRA_SVN = "svn://projects.linuxtogo.org/svn/gpe/trunk/extra;module=${PN}"
 GPE_SVN = "svn://projects.linuxtogo.org/svn/gpe/trunk/base;module=${PN}"
diff --git a/recipes/gcc/gcc-4.3.3.inc b/recipes/gcc/gcc-4.3.3.inc
index 4bed0e4..860c96c 100644
--- a/recipes/gcc/gcc-4.3.3.inc
+++ b/recipes/gcc/gcc-4.3.3.inc
@@ -6,7 +6,7 @@ require gcc-common.inc
 
 DEPENDS = "mpfr gmp"
 
-SRC_URI = "http://gcc.releasenotes.org/releases/gcc-${PV}/gcc-${PV}.tar.bz2 \
+SRC_URI = "${GNU_MIRROR}/gcc/gcc-${PV}/gcc-${PV}.tar.bz2 \
 	file://fedora/gcc43-c++-builtin-redecl.patch;patch=1;pnum=0 \
 	file://fedora/gcc43-ia64-libunwind.patch;patch=1;pnum=0 \
 	file://fedora/gcc43-java-nomulti.patch;patch=1;pnum=0 \
-- 
1.5.6.3

Re: [PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[Tom Rini]

On Tue, Apr 07, 2009 at 11:16:44AM -0400, David Huggins-Daines wrote:

> Currently it's not possible to build the stable/2009 branch with GCC 4.3.3,
> because it hardcodes a download location for the sources which is not
> resolvable (at least from where I am...).  It was suggested to change the
> recipe to use GNU_MIRROR.
> 
> Unfortunately, bitbake.conf and checksums.ini have a different idea of what
> the URI for the main GNU download site is.  This patch fixes these problems.

NACK.

First, this is fixed in .dev now, by fixing all of the gcc recipes
(except for csl ones) to use ${GNU_MIRROR} and updating the checksums
file.  Second, ftp.gnu.org/gnu is correct as 'pub' is just a symlink to
'.'.

-- 
Tom Rini

Re: [PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[David Huggins-Daines]

Tom Rini wrote:
>
> First, this is fixed in .dev now, by fixing all of the gcc recipes
> (except for csl ones) to use ${GNU_MIRROR} and updating the checksums
> file.  Second, ftp.gnu.org/gnu is correct as 'pub' is just a symlink to
> '.'.
>   
Yeah, actually, after trying to rebuild, I agree.  Changing bitbake.conf 
is a very bad idea.

However I still think the changes to the gcc recipes and checksums.ini 
should be merged into the stable branch, otherwise it is not possible to 
build any recent versions of GCC (and in particular, thumb support seems 
not to work properly without using 4.3.3)

Re: [PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[Tom Rini]

On Tue, Apr 07, 2009 at 12:54:34PM -0400, David Huggins-Daines wrote:
> Tom Rini wrote:
>>
>> First, this is fixed in .dev now, by fixing all of the gcc recipes
>> (except for csl ones) to use ${GNU_MIRROR} and updating the checksums
>> file.  Second, ftp.gnu.org/gnu is correct as 'pub' is just a symlink to
>> '.'.
>>   
> Yeah, actually, after trying to rebuild, I agree.  Changing bitbake.conf  
> is a very bad idea.
>
> However I still think the changes to the gcc recipes and checksums.ini  
> should be merged into the stable branch, otherwise it is not possible to  
> build any recent versions of GCC (and in particular, thumb support seems  
> not to work properly without using 4.3.3)

I'll propose
http://cgit.openembedded.net/cgit.cgi?url=openembedded/commit/&id=e053ff45acfa098921fc7e8c124ae0d96ed33750
shortly (need to make breakfast).

-- 
Tom Rini

Re: [PATCH] fix GCC 4.3.3 sources in stable/2009 branch

[Koen Kooi]

On 07-04-09 18:54, David Huggins-Daines wrote:
> Tom Rini wrote:
>>
>> First, this is fixed in .dev now, by fixing all of the gcc recipes
>> (except for csl ones) to use ${GNU_MIRROR} and updating the checksums
>> file. Second, ftp.gnu.org/gnu is correct as 'pub' is just a symlink to
>> '.'.
> Yeah, actually, after trying to rebuild, I agree. Changing bitbake.conf
> is a very bad idea.
>
> However I still think the changes to the gcc recipes and checksums.ini
> should be merged into the stable branch, otherwise it is not possible to
> build any recent versions of GCC (and in particular, thumb support seems
> not to work properly without using 4.3.3)

Anyone is free to send a patch to this mailinglist to add to stable. 
It's really easy:

Powerbook-3:openembedded koen$ cat contrib/mail-diff.sh
#!/bin/sh

# This script will fetch an 'mbox' patch from patchwork and git am it
# usage: mail-diff.sh <rev>
# example: 'pw-am.sh 3a485444f0dd07fd2315769db3f6f46e3972134e'

PATCHNAME="$(git format-patch -s -1 $1)"
sed -i -e 's:\[PATCH:\[STABLE\]\[PATCH:g' $PATCHNAME
git send-email --from "Koen Kooi <k.kooi@student.utwente.nl>" --to 
openembedded-devel@lists.openembedded.org $PATCHNAME
rm $PATCHNAME

regards,

Koen