* [PATCH] guile-native: added missing gettext-native dependency
@ 2009-06-04 14:13 Ihar Hrachyshka
2009-06-04 14:58 ` Koen Kooi
2009-06-04 16:18 ` [patch] autotools: detect missing depends for aclocal packages Phil Blundell
0 siblings, 2 replies; 5+ messages in thread
From: Ihar Hrachyshka @ 2009-06-04 14:13 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
---
recipes/guile/guile-native_1.8.5.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/recipes/guile/guile-native_1.8.5.bb b/recipes/guile/guile-native_1.8.5.bb
index e73616e..bf21c6a 100644
--- a/recipes/guile/guile-native_1.8.5.bb
+++ b/recipes/guile/guile-native_1.8.5.bb
@@ -1,6 +1,6 @@
SECTION = "unknown"
LICENSE = "GPL"
-DEPENDS = "gmp-native"
+DEPENDS = "gmp-native gettext-native"
SRC_URI = "http://ftp.gnu.org/pub/gnu/guile/guile-${PV}.tar.gz \
file://configure-fix.patch;patch=1 \
"
--
1.6.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] guile-native: added missing gettext-native dependency
2009-06-04 14:13 [PATCH] guile-native: added missing gettext-native dependency Ihar Hrachyshka
@ 2009-06-04 14:58 ` Koen Kooi
2009-06-04 16:18 ` [patch] autotools: detect missing depends for aclocal packages Phil Blundell
1 sibling, 0 replies; 5+ messages in thread
From: Koen Kooi @ 2009-06-04 14:58 UTC (permalink / raw)
To: openembedded-devel
On 04-06-09 16:13, Ihar Hrachyshka wrote:
> Signed-off-by: Ihar Hrachyshka<ihar.hrachyshka@gmail.com>
> ---
> recipes/guile/guile-native_1.8.5.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/guile/guile-native_1.8.5.bb b/recipes/guile/guile-native_1.8.5.bb
> index e73616e..bf21c6a 100644
> --- a/recipes/guile/guile-native_1.8.5.bb
> +++ b/recipes/guile/guile-native_1.8.5.bb
> @@ -1,6 +1,6 @@
> SECTION = "unknown"
> LICENSE = "GPL"
> -DEPENDS = "gmp-native"
> +DEPENDS = "gmp-native gettext-native"
> SRC_URI = "http://ftp.gnu.org/pub/gnu/guile/guile-${PV}.tar.gz \
> file://configure-fix.patch;patch=1 \
> "
I already have that fix queued up:
http://dominion.thruhere.net/git/cgit.cgi/openembedded/commit/?id=c1643b0dba7286af8c7a9e26e6aa96c0315df14f
regards,
Koen
^ permalink raw reply [flat|nested] 5+ messages in thread* [patch] autotools: detect missing depends for aclocal packages
2009-06-04 14:13 [PATCH] guile-native: added missing gettext-native dependency Ihar Hrachyshka
2009-06-04 14:58 ` Koen Kooi
@ 2009-06-04 16:18 ` Phil Blundell
2009-08-12 9:35 ` Holger Hans Peter Freyther
1 sibling, 1 reply; 5+ messages in thread
From: Phil Blundell @ 2009-06-04 16:18 UTC (permalink / raw)
To: openembedded-devel
On Thu, 2009-06-04 at 17:13 +0300, Ihar Hrachyshka wrote:
> -DEPENDS = "gmp-native"
> +DEPENDS = "gmp-native gettext-native"
For laughs, here's a small patch to detect this kind of thing
automatically in at least some cases.
p.
--
diff --git a/classes/autotools.bbclass b/classes/autotools.bbclass
index e43b289..214da3c 100644
--- a/classes/autotools.bbclass
+++ b/classes/autotools.bbclass
@@ -67,6 +67,49 @@ oe_runconf () {
fi
}
+python autotools_do_check_aclocal() {
+ frags = bb.data.expand('${T}/acfragments', d)
+ bb.note(frags)
+ if os.path.exists(frags):
+ pcproviders = {}
+ needed = []
+ f = open(frags, "r")
+ import re
+ sr = re.compile("aclocal: saw macro (.*)")
+ fr = re.compile("aclocal: found macro (.*) in .*/(.*).m4")
+ for l in f.readlines():
+ l = l.rstrip()
+ m = sr.match(l)
+ if m:
+ if not m.group(1) in needed:
+ needed.append(m.group(1))
+ else:
+ m = fr.match(l)
+ if m:
+ pcproviders[m.group(1)] = m.group(2)
+ f.close()
+ needed_pkgs = []
+ for n in needed:
+ if not pcproviders.has_key(n):
+ continue
+ fn = bb.data.expand("${STAGING_DIR}/${HOST_SYS}/acdeps/%s.m4" % pcproviders[n], d)
+ if os.path.exists(fn):
+ f = open(fn, "r")
+ p = f.readline().rstrip()
+ f.close()
+ if not p in needed_pkgs:
+ needed_pkgs.append(p)
+ deps = bb.data.getVar("DEPENDS", d, True).split()
+ lost = []
+ for n in needed_pkgs:
+ if not n in deps:
+ lost.append(n)
+ if lost:
+ bb.note("possibly missing dependencies: %s" % " ".join(lost))
+}
+
+addtask check_aclocal after do_configure
+
autotools_do_configure() {
case ${PN} in
autoconf*)
@@ -126,6 +169,8 @@ autotools_do_configure() {
oenote Executing intltoolize --copy --force --automake
intltoolize --copy --force --automake
fi
+ oenote Extracting list of required m4 fragments
+ aclocal --output=/dev/null --verbose 2>&1 | egrep '(^aclocal: found macro)|(^aclocal: saw macro)' > ${T}/acfragments || true
oenote Executing autoreconf --verbose --install --force ${EXTRA_AUTORECONF} $acpaths
mkdir -p m4
autoreconf -Wcross --verbose --install --force ${EXTRA_AUTORECONF} $acpaths || oefatal "autoreconf execution failed."
@@ -239,8 +284,14 @@ autotools_stage_all() {
rm -rf ${STAGE_TEMP}/${mandir} || true
rm -rf ${STAGE_TEMP}/${infodir} || true
autotools_stage_dir ${STAGE_TEMP}/${datadir} ${STAGING_DATADIR}
+ if [ -d ${STAGE_TEMP}/${datadir}/aclocal ]; then
+ mkdir -p ${STAGING_DIR}/${HOST_SYS}/acdeps
+ for i in `find ${STAGE_TEMP}/${datadir}/aclocal/ -name '*.m4'`; do
+ echo ${PN} > ${STAGING_DIR}/${HOST_SYS}/acdeps/`basename $i`
+ done
+ fi
rm -rf ${STAGE_TEMP}
}
-EXPORT_FUNCTIONS do_configure do_install
+EXPORT_FUNCTIONS do_configure do_install do_check_aclocal
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] autotools: detect missing depends for aclocal packages
2009-06-04 16:18 ` [patch] autotools: detect missing depends for aclocal packages Phil Blundell
@ 2009-08-12 9:35 ` Holger Hans Peter Freyther
2010-03-26 21:23 ` Stefan Schmidt
0 siblings, 1 reply; 5+ messages in thread
From: Holger Hans Peter Freyther @ 2009-08-12 9:35 UTC (permalink / raw)
To: openembedded-devel
On Thursday 04 June 2009 18:18:03 Phil Blundell wrote:
> On Thu, 2009-06-04 at 17:13 +0300, Ihar Hrachyshka wrote:
> > -DEPENDS = "gmp-native"
> > +DEPENDS = "gmp-native gettext-native"
>
> For laughs, here's a small patch to detect this kind of thing
> automatically in at least some cases.
>
> p.
Signed-Off-by: Holger Freyther <zecke@selfish.org>
>
> --
>
> diff --git a/classes/autotools.bbclass b/classes/autotools.bbclass
> index e43b289..214da3c 100644
> --- a/classes/autotools.bbclass
> +++ b/classes/autotools.bbclass
> @@ -67,6 +67,49 @@ oe_runconf () {
> fi
> }
>
> +python autotools_do_check_aclocal() {
> + frags = bb.data.expand('${T}/acfragments', d)
> + bb.note(frags)
> + if os.path.exists(frags):
> + pcproviders = {}
> + needed = []
> + f = open(frags, "r")
> + import re
> + sr = re.compile("aclocal: saw macro (.*)")
> + fr = re.compile("aclocal: found macro (.*) in .*/(.*).m4")
> + for l in f.readlines():
> + l = l.rstrip()
> + m = sr.match(l)
> + if m:
> + if not m.group(1) in needed:
> + needed.append(m.group(1))
> + else:
> + m = fr.match(l)
> + if m:
> + pcproviders[m.group(1)] =
> m.group(2) + f.close()
> + needed_pkgs = []
> + for n in needed:
> + if not pcproviders.has_key(n):
> + continue
> + fn =
> bb.data.expand("${STAGING_DIR}/${HOST_SYS}/acdeps/%s.m4" % pcproviders[n],
> d) + if os.path.exists(fn):
> + f = open(fn, "r")
> + p = f.readline().rstrip()
> + f.close()
> + if not p in needed_pkgs:
> + needed_pkgs.append(p)
> + deps = bb.data.getVar("DEPENDS", d, True).split()
> + lost = []
> + for n in needed_pkgs:
> + if not n in deps:
> + lost.append(n)
> + if lost:
> + bb.note("possibly missing dependencies: %s" % "
> ".join(lost)) +}
> +
> +addtask check_aclocal after do_configure
> +
> autotools_do_configure() {
> case ${PN} in
> autoconf*)
> @@ -126,6 +169,8 @@ autotools_do_configure() {
> oenote Executing intltoolize --copy --force --automake
> intltoolize --copy --force --automake
> fi
> + oenote Extracting list of required m4 fragments
> + aclocal --output=/dev/null --verbose 2>&1 | egrep
> '(^aclocal: found macro)|(^aclocal: saw macro)' > ${T}/acfragments || true
> oenote Executing autoreconf --verbose --install --force ${EXTRA_AUTORECONF}
> $acpaths mkdir -p m4
> autoreconf -Wcross --verbose --install --force ${EXTRA_AUTORECONF}
> $acpaths || oefatal "autoreconf execution failed." @@ -239,8 +284,14 @@
> autotools_stage_all() {
> rm -rf ${STAGE_TEMP}/${mandir} || true
> rm -rf ${STAGE_TEMP}/${infodir} || true
> autotools_stage_dir ${STAGE_TEMP}/${datadir} ${STAGING_DATADIR}
> + if [ -d ${STAGE_TEMP}/${datadir}/aclocal ]; then
> + mkdir -p ${STAGING_DIR}/${HOST_SYS}/acdeps
> + for i in `find ${STAGE_TEMP}/${datadir}/aclocal/ -name
> '*.m4'`; do + echo ${PN} >
> ${STAGING_DIR}/${HOST_SYS}/acdeps/`basename $i` + done
> + fi
> rm -rf ${STAGE_TEMP}
> }
>
> -EXPORT_FUNCTIONS do_configure do_install
> +EXPORT_FUNCTIONS do_configure do_install do_check_aclocal
>
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] autotools: detect missing depends for aclocal packages
2009-08-12 9:35 ` Holger Hans Peter Freyther
@ 2010-03-26 21:23 ` Stefan Schmidt
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Schmidt @ 2010-03-26 21:23 UTC (permalink / raw)
To: openembedded-devel
Hello.
On Wed, 2009-08-12 at 11:35, Holger Hans Peter Freyther wrote:
> On Thursday 04 June 2009 18:18:03 Phil Blundell wrote:
> > On Thu, 2009-06-04 at 17:13 +0300, Ihar Hrachyshka wrote:
> > > -DEPENDS = "gmp-native"
> > > +DEPENDS = "gmp-native gettext-native"
> >
> > For laughs, here's a small patch to detect this kind of thing
> > automatically in at least some cases.
> >
> > p.
>
>
> Signed-Off-by: Holger Freyther <zecke@selfish.org>
I just found this one in patchwork as one of the oldest patches siting in
there. I like the check and Holger did sign it off as well. Anyone a problem
with this going in?
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-03-26 21:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-04 14:13 [PATCH] guile-native: added missing gettext-native dependency Ihar Hrachyshka
2009-06-04 14:58 ` Koen Kooi
2009-06-04 16:18 ` [patch] autotools: detect missing depends for aclocal packages Phil Blundell
2009-08-12 9:35 ` Holger Hans Peter Freyther
2010-03-26 21:23 ` Stefan Schmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.