sqlite3 recipe

sqlite3 recipe

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

Does anyone mind if I push this change? I ran across a package that 
needed an additional header not staged by the current inc file.

Philip

diff --git a/recipes/sqlite/sqlite3.inc b/recipes/sqlite/sqlite3.inc
index 93a536e..ae20ff5 100644
--- a/recipes/sqlite/sqlite3.inc
+++ b/recipes/sqlite/sqlite3.inc
@@ -9,7 +9,7 @@ SRC_URI = "http://www.sqlite.org/sqlite-${PV}.tar.gz \

  S = "${WORKDIR}/sqlite-${PV}"

-inherit autotools pkgconfig
+inherit autotools_stage pkgconfig

  EXTRA_OECONF = "--disable-tcl --enable-shared \
                 --enable-threadsafe"
@@ -26,15 +26,6 @@ do_compile_prepend() {
         install -m 0644 sqlite3.h ${STAGING_INCDIR}
  }

-do_stage() {
-       oe_libinstall -so libsqlite3 ${STAGING_LIBDIR}
-       install -m 0644 sqlite3.h ${STAGING_INCDIR}
-}
-
-#do_install() {
-#      oe_runmake install DESTDIR=${D} prefix=${prefix} 
exec_prefix=${exec_pref
-#}
-
  PACKAGES = "libsqlite libsqlite-dev libsqlite-doc sqlite3 sqlite3-dbg"
  FILES_sqlite3 = "${bindir}/*"
  FILES_libsqlite = "${libdir}/*.so.*"

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: sqlite3 recipe

[Koen Kooi]

On 19-07-09 21:32, Philip Balister wrote:
> Does anyone mind if I push this change? I ran across a package that
> needed an additional header not staged by the current inc file.

Go ahead, the currunt do_stage is obviously wrong.

regards,

Koen

>
> Philip
>
> diff --git a/recipes/sqlite/sqlite3.inc b/recipes/sqlite/sqlite3.inc
> index 93a536e..ae20ff5 100644
> --- a/recipes/sqlite/sqlite3.inc
> +++ b/recipes/sqlite/sqlite3.inc
> @@ -9,7 +9,7 @@ SRC_URI = "http://www.sqlite.org/sqlite-${PV}.tar.gz \
>
> S = "${WORKDIR}/sqlite-${PV}"
>
> -inherit autotools pkgconfig
> +inherit autotools_stage pkgconfig
>
> EXTRA_OECONF = "--disable-tcl --enable-shared \
> --enable-threadsafe"
> @@ -26,15 +26,6 @@ do_compile_prepend() {
> install -m 0644 sqlite3.h ${STAGING_INCDIR}
> }
>
> -do_stage() {
> - oe_libinstall -so libsqlite3 ${STAGING_LIBDIR}
> - install -m 0644 sqlite3.h ${STAGING_INCDIR}
> -}
> -
> -#do_install() {
> -# oe_runmake install DESTDIR=${D} prefix=${prefix} exec_prefix=${exec_pref
> -#}
> -
> PACKAGES = "libsqlite libsqlite-dev libsqlite-doc sqlite3 sqlite3-dbg"
> FILES_sqlite3 = "${bindir}/*"
> FILES_libsqlite = "${libdir}/*.so.*"
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: sqlite3 recipe

[Otavio Salvador]

Hello,

On Sun, Jul 19, 2009 at 4:32 PM, Philip Balister<philip@balister.org> wrote:
> Does anyone mind if I push this change? I ran across a package that needed
> an additional header not staged by the current inc file.

It looks like you've forgotten the PR bump. In this case would be nice
to move it to INC_PR stuff.

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br

Re: sqlite3 recipe

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Otavio Salvador wrote:
> Hello,
> 
> On Sun, Jul 19, 2009 at 4:32 PM, Philip Balister<philip@balister.org> wrote:
>> Does anyone mind if I push this change? I ran across a package that needed
>> an additional header not staged by the current inc file.
> 
> It looks like you've forgotten the PR bump. In this case would be nice
> to move it to INC_PR stuff.

Well, for this case only staging changes, not the packaging. I needed to 
do this for a local recipe that used a different header file that the 
previous recipe did not install into staging. Certainly, if the 
packaging changes, it should move to INC_PR.

Phili p

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: sqlite3 recipe

[Marcin Juszkiewicz]

Dnia poniedziałek, 20 lipca 2009 o 03:55:44 Philip Balister napisał(a):
> Otavio Salvador wrote:

> > It looks like you've forgotten the PR bump. In this case would be
> > nice to move it to INC_PR stuff.
>
> Well, for this case only staging changes, not the packaging. I needed
> to do this for a local recipe that used a different header file that
> the previous recipe did not install into staging. Certainly, if the
> packaging changes, it should move to INC_PR.

You change made all packages built after it have access to all SQLite 
headers. You do not know how many of them use those.

Change to packages content require PR bump. Change to staging also 
require PR bump - otherwise I am not able to build your local recipe 
without rebuilding sqlite by hand.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

Re: sqlite3 recipe

[Koen Kooi]

On 20-07-09 03:55, Philip Balister wrote:
> Otavio Salvador wrote:
>> Hello,
>>
>> On Sun, Jul 19, 2009 at 4:32 PM, Philip Balister<philip@balister.org>
>> wrote:
>>> Does anyone mind if I push this change? I ran across a package that
>>> needed
>>> an additional header not staged by the current inc file.
>>
>> It looks like you've forgotten the PR bump. In this case would be nice
>> to move it to INC_PR stuff.
>
> Well, for this case only staging changes, not the packaging.

You change the packaged-staging package :) And what Marcin said of 
needing manual intervention.

regards,

Koen