All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] base.bbclass: Pass in PATH to popen.
Date: Sun, 30 Aug 2009 12:01:56 +0200	[thread overview]
Message-ID: <h7dimk$86n$1@ger.gmane.org> (raw)
In-Reply-To: <1251582336-3324-1-git-send-email-raj.khem@gmail.com>

On 29-08-09 23:45, Khem Raj wrote:
> On Mac OSX its not able to find md5sum if
> path is not passed to os.popen shell.
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>

This fixes a host of other bugs as well

Acked-by: Koen Kooi <koen@openembedded.org>



> ---
>   classes/base.bbclass |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index 97ccf5d..d29ba4b 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -84,7 +84,7 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data):
>
>       # call md5(sum) and shasum
>       try:
> -        md5pipe = os.popen('md5sum ' + localpath)
> +	md5pipe = os.popen('PATH=%s md5sum %s' % (bb.data.getVar('PATH', data, True), localpath))
>           md5data = (md5pipe.readline().split() or [ "" ])[0]
>           md5pipe.close()
>       except OSError:





      reply	other threads:[~2009-08-30 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-29 21:45 [PATCH] base.bbclass: Pass in PATH to popen Khem Raj
2009-08-30 10:01 ` Koen Kooi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h7dimk$86n$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.