* [PATCH] base.bbclass: Pass in PATH to popen.
@ 2009-08-29 21:45 Khem Raj
2009-08-30 10:01 ` Koen Kooi
0 siblings, 1 reply; 2+ messages in thread
From: Khem Raj @ 2009-08-29 21:45 UTC (permalink / raw)
To: openembedded-devel
On Mac OSX its not able to find md5sum if
path is not passed to os.popen shell.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
classes/base.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/base.bbclass b/classes/base.bbclass
index 97ccf5d..d29ba4b 100644
--- a/classes/base.bbclass
+++ b/classes/base.bbclass
@@ -84,7 +84,7 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data):
# call md5(sum) and shasum
try:
- md5pipe = os.popen('md5sum ' + localpath)
+ md5pipe = os.popen('PATH=%s md5sum %s' % (bb.data.getVar('PATH', data, True), localpath))
md5data = (md5pipe.readline().split() or [ "" ])[0]
md5pipe.close()
except OSError:
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] base.bbclass: Pass in PATH to popen.
2009-08-29 21:45 [PATCH] base.bbclass: Pass in PATH to popen Khem Raj
@ 2009-08-30 10:01 ` Koen Kooi
0 siblings, 0 replies; 2+ messages in thread
From: Koen Kooi @ 2009-08-30 10:01 UTC (permalink / raw)
To: openembedded-devel
On 29-08-09 23:45, Khem Raj wrote:
> On Mac OSX its not able to find md5sum if
> path is not passed to os.popen shell.
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
This fixes a host of other bugs as well
Acked-by: Koen Kooi <koen@openembedded.org>
> ---
> classes/base.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/classes/base.bbclass b/classes/base.bbclass
> index 97ccf5d..d29ba4b 100644
> --- a/classes/base.bbclass
> +++ b/classes/base.bbclass
> @@ -84,7 +84,7 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data):
>
> # call md5(sum) and shasum
> try:
> - md5pipe = os.popen('md5sum ' + localpath)
> + md5pipe = os.popen('PATH=%s md5sum %s' % (bb.data.getVar('PATH', data, True), localpath))
> md5data = (md5pipe.readline().split() or [ "" ])[0]
> md5pipe.close()
> except OSError:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-30 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-29 21:45 [PATCH] base.bbclass: Pass in PATH to popen Khem Raj
2009-08-30 10:01 ` Koen Kooi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.