dropbear-0.51-r3 allow-nopw.patch: No such file or directory

dropbear-0.51-r3 allow-nopw.patch: No such file or directory

[Steffen Sledz]

It seems that commit c26fc5db90702b035bd545cff3ee7575a0f9b70f was incomplete.

Re: dropbear-0.51-r3 allow-nopw.patch: No such file or directory -> reverted

[Koen Kooi]

On 04-09-09 11:06, Steffen Sledz wrote:
> It seems that commit c26fc5db90702b035bd545cff3ee7575a0f9b70f was incomplete.

No, that commit is just plain wrong, from dropbear.inc:

do_configure_prepend() {
	if [ "x${DISTRO_TYPE}" = "xdebug" ]; then
		oenote "WARNING: applying allow-nopw.patch which allows password-less 
logins!"
		patch -p1 < ${WORKDIR}/allow-nopw.patch
	fi
}

The faulty commit in question breaks that by applying it it 
unconditionally and not fixing do_configure_prepend.

I've reverted that commit in the meant time.

regards,

Koen

Re: dropbear-0.51-r3 allow-nopw.patch: No such file or directory

[Phil Blundell]

On Fri, 2009-09-04 at 11:06 +0200, Steffen Sledz wrote:
> It seems that commit c26fc5db90702b035bd545cff3ee7575a0f9b70f was incomplete.

Not so much incomplete as just misconceived: allow-nopw.patch is meant
to be applied in do_configure_prepend (under control of ${DISTRO_TYPE}),
not by do_patch.  

Changing that patch to apply unconditionally in do_patch is a rather
drastic policy change since it will enable passwordless logins for
non-debug distros (and, as it turns out, break compilation for debug
distros although that is something of a side issue).  This should
definitely not have been committed without discussion here.

p.

Re: dropbear-0.51-r3 allow-nopw.patch: No such file or directory -> reverted

[Khem Raj]

On Fri, Sep 4, 2009 at 2:42 AM, Koen Kooi<k.kooi@student.utwente.nl> wrote:
> On 04-09-09 11:06, Steffen Sledz wrote:
>>
>> It seems that commit c26fc5db90702b035bd545cff3ee7575a0f9b70f was
>> incomplete.
>
> No, that commit is just plain wrong, from dropbear.inc:
>
> do_configure_prepend() {
>        if [ "x${DISTRO_TYPE}" = "xdebug" ]; then
>                oenote "WARNING: applying allow-nopw.patch which allows
> password-less logins!"
>                patch -p1 < ${WORKDIR}/allow-nopw.patch
>        fi
> }
>
> The faulty commit in question breaks that by applying it it unconditionally
> and not fixing do_configure_prepend.
>
> I've reverted that commit in the meant time.
>

Thanks for taking care of it thats was an oversight from me

> regards,
>
> Koen
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>