[PATCH v2] Enable bmp and JPEG files for fbv

[PATCH v2] Enable bmp and JPEG files for fbv

[Ulf Samuelsson]

Enable bmp and JPEG files for fbv

Previously only supported PNG.
Ungif still not supported
Remove unneccesary whitespace
Do not install manuals to target

Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>
---
 recipes/fbv/fbv-1.0b/fbv-1.0b.patch |   12 ++++++++++++
 recipes/fbv/fbv_1.0b.bb             |   21 +++++++++++----------
 2 files changed, 23 insertions(+), 10 deletions(-)
 create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch

diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
new file mode 100644
index 0000000..6fbd1fb
--- /dev/null
+++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
@@ -0,0 +1,12 @@
+diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
+--- fbv-1.0b-0rig/Makefile	2009-08-20 00:33:58.000000000 +0200
++++ fbv-1.0b/Makefile	2009-08-20 00:34:16.000000000 +0200
+@@ -12,7 +12,7 @@
+ OBJECTS	= ${SOURCES:.c=.o}
+
+ OUT	= fbv
+-#LIBS	= -lungif -L/usr/X11R6/lib -ljpeg -lpng
++LIBS	= -L/usr/lib -ljpeg -lpng #-lungif
+
+ all: $(OUT)
+ 	@echo Build DONE.
diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
index 04c7066..e593eb4 100644
--- a/recipes/fbv/fbv_1.0b.bb
+++ b/recipes/fbv/fbv_1.0b.bb
@@ -1,25 +1,26 @@
 DESCRIPTION = "Frame Buffer Viewer"
 LICENSE = "GPL"
-DEPENDS = "libpng"
-PR = "r1"
+DEPENDS = "libpng jpeg"
+PR = "r2"

 SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
-	   file://cross_compile.patch;patch=1"
+	file://cross_compile.patch;patch=1 \
+	file://fbv-1.0b.patch;patch=1 \
+	"

 do_configure() {
-	CC="${CC}" ./configure --without-libungif --without-bmp \
-		--without-libjpeg
+	CC="${CC}" ./configure --without-libungif
 }

 do_compile() {
 	oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
 		CC="${CC}"
 }
+
 do_install() {
 	install -d ${D}${bindir}
-        install -m 0755 fbv ${D}${bindir}
-
-        # man
-        install -d ${D}${mandir}/man1/
-        install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
+	install -m 0755 fbv ${D}${bindir}
 }
+
+PACKAGES = "fbv"
+
-- 
1.6.0.2

-- 
Best Regards
Ulf Samuelsson

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Marcin Juszkiewicz]

Dnia środa, 20 stycznia 2010 o 01:15:57 Ulf Samuelsson napisał(a):
>  do_install() {
>         install -d ${D}${bindir}
> -        install -m 0755 fbv ${D}${bindir}
> -
> -        # man
> -        install -d ${D}${mandir}/man1/
> -        install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> +       install -m 0755 fbv ${D}${bindir}
>  }

I like to be able to install fbv-doc package to read manuals. Please revert 
that part.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

Am Mittwoch, den 20.01.2010, 01:15 +0100 schrieb Ulf Samuelsson:
> Enable bmp and JPEG files for fbv
> 
> Previously only supported PNG.
> Ungif still not supported.

Not supported or just not enabled?

One last question. Does anyone know why this support was not enabled in
the first place? Not needed back then, not working, size constrains?

        $ git log --follow recipes/fbv/fbv_1.0b.bb 
        commit 0bdb7654c8a9b9850db27e5f6b4a746fb1083ed1
        Author: Tom Rini <trini@embeddedalley.com>
        Date:   Thu Apr 23 15:07:52 2009 -0400
        
            fbv: Add a framebuffer-based png viewer.
            bmp/gif is supported but disabled.

> Remove unneccesary whitespace.
> Do not install manuals to target
> 
> Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>

I do not have commit rights. Someone else has to commit your patches.


Thanks,

Paul

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Philip Balister]

On 01/19/2010 07:15 PM, Ulf Samuelsson wrote:
> Enable bmp and JPEG files for fbv
>
> Previously only supported PNG.
> Ungif still not supported
> Remove unneccesary whitespace
> Do not install manuals to target
>
> Signed-off-by: Ulf Samuelsson<ulf.samuelsson@atmel.com>

Ulf,

Thanks for the patches. Can you fix your commit messages to follow the 
form outlined in:

http://wiki.openembedded.net/index.php/Commit_log_example

Having everyone follow the same form makes it much easier to follow OE 
development by following the git short log.

Sorry I didn't make this comment earlier :(

Philip

> ---
>   recipes/fbv/fbv-1.0b/fbv-1.0b.patch |   12 ++++++++++++
>   recipes/fbv/fbv_1.0b.bb             |   21 +++++++++++----------
>   2 files changed, 23 insertions(+), 10 deletions(-)
>   create mode 100644 recipes/fbv/fbv-1.0b/fbv-1.0b.patch
>
> diff --git a/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> new file mode 100644
> index 0000000..6fbd1fb
> --- /dev/null
> +++ b/recipes/fbv/fbv-1.0b/fbv-1.0b.patch
> @@ -0,0 +1,12 @@
> +diff -urN fbv-1.0b-0rig/Makefile fbv-1.0b/Makefile
> +--- fbv-1.0b-0rig/Makefile	2009-08-20 00:33:58.000000000 +0200
> ++++ fbv-1.0b/Makefile	2009-08-20 00:34:16.000000000 +0200
> +@@ -12,7 +12,7 @@
> + OBJECTS	= ${SOURCES:.c=.o}
> +
> + OUT	= fbv
> +-#LIBS	= -lungif -L/usr/X11R6/lib -ljpeg -lpng
> ++LIBS	= -L/usr/lib -ljpeg -lpng #-lungif
> +
> + all: $(OUT)
> + 	@echo Build DONE.
> diff --git a/recipes/fbv/fbv_1.0b.bb b/recipes/fbv/fbv_1.0b.bb
> index 04c7066..e593eb4 100644
> --- a/recipes/fbv/fbv_1.0b.bb
> +++ b/recipes/fbv/fbv_1.0b.bb
> @@ -1,25 +1,26 @@
>   DESCRIPTION = "Frame Buffer Viewer"
>   LICENSE = "GPL"
> -DEPENDS = "libpng"
> -PR = "r1"
> +DEPENDS = "libpng jpeg"
> +PR = "r2"
>
>   SRC_URI = "http://s-tech.elsat.net.pl/fbv/fbv-1.0b.tar.gz \
> -	   file://cross_compile.patch;patch=1"
> +	file://cross_compile.patch;patch=1 \
> +	file://fbv-1.0b.patch;patch=1 \
> +	"
>
>   do_configure() {
> -	CC="${CC}" ./configure --without-libungif --without-bmp \
> -		--without-libjpeg
> +	CC="${CC}" ./configure --without-libungif
>   }
>
>   do_compile() {
>   	oe_runmake CFLAGS="-O2 -Wall -D_GNU_SOURCE -D__KERNEL_STRICT_NAMES" \
>   		CC="${CC}"
>   }
> +
>   do_install() {
>   	install -d ${D}${bindir}
> -        install -m 0755 fbv ${D}${bindir}
> -
> -        # man
> -        install -d ${D}${mandir}/man1/
> -        install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> +	install -m 0755 fbv ${D}${bindir}
>   }
> +
> +PACKAGES = "fbv"
> +

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Phil Blundell]

On Wed, 2010-01-20 at 01:15 +0100, Ulf Samuelsson wrote:
> Enable bmp and JPEG files for fbv
> 
> Previously only supported PNG.
> Ungif still not supported
> Remove unneccesary whitespace
> Do not install manuals to target
> 
> Signed-off-by: Ulf Samuelsson <ulf.samuelsson@atmel.com>

What's the reason for not installing the manuals?  That seems like a
retrograde step.

p.

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Graeme Gregory]

Ulf Samuelsson <ulf.samuelsson <at> atmel.com> writes:

> +PACKAGES = "fbv"

NAK

PACKAGES is never set in a recipe only added to.

Graeme

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Am Freitag, den 22.01.2010, 09:05 +0000 schrieb Graeme Gregory:
> Ulf Samuelsson <ulf.samuelsson <at> atmel.com> writes:
> 
> > +PACKAGES = "fbv"
> 
> NAK
> 
> PACKAGES is never set in a recipe only added to.

More information seems to available in the user manual [1].


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/html/recipes_packages.html

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 20-01-10 01:15, Ulf Samuelsson wrote:

>  do_install() {
>  	install -d ${D}${bindir}
> -        install -m 0755 fbv ${D}${bindir}
> -
> -        # man
> -        install -d ${D}${mandir}/man1/
> -        install -m 0644 fbv.1 ${D}${mandir}/man1/fbv.1
> +	install -m 0755 fbv ${D}${bindir}

NAK, we still want proper -doc packages

>  }
> +
> +PACKAGES = "fbv"
> +

And NEVER EVER redefine PACKAGES! We want proper -dbg and -dev packages
for depchain purposes.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLWrykMkyGM64RGpERAg0RAJ9AFmVVMuoZ2/Dh9QM6ehG8H7WsAgCfSGGC
dd0SrEUtuXUkbRSnLSLRt0s=
=x2vo
-----END PGP SIGNATURE-----

Re: [PATCH v2] Enable bmp and JPEG files for fbv

[Tom Rini]

On Wed, 2010-01-20 at 10:37 +0100, Paul Menzel wrote:
> Am Mittwoch, den 20.01.2010, 01:15 +0100 schrieb Ulf Samuelsson:
> > Enable bmp and JPEG files for fbv
> > 
> > Previously only supported PNG.
> > Ungif still not supported.
> 
> Not supported or just not enabled?
> 
> One last question. Does anyone know why this support was not enabled in
> the first place? Not needed back then, not working, size constrains?
> 
>         $ git log --follow recipes/fbv/fbv_1.0b.bb 
>         commit 0bdb7654c8a9b9850db27e5f6b4a746fb1083ed1
>         Author: Tom Rini <trini@embeddedalley.com>
>         Date:   Thu Apr 23 15:07:52 2009 -0400
>         
>             fbv: Add a framebuffer-based png viewer.
>             bmp/gif is supported but disabled.

<Insert USE_FLAGS rant here>

Didn't need bmp/jpeg support in the use case I added fbv for (testing
the fb driver easily) and didn't have jpeg/bmp support being pulled in
otherwise.

-- 
Tom Rini <tom_rini@mentor.com>
Mentor Graphics Corporation