From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: New state for patches not complying with commit policy
Date: Sat, 23 Jan 2010 19:00:42 +0100 [thread overview]
Message-ID: <hjfdg9$4lv$1@ger.gmane.org> (raw)
In-Reply-To: <1264263068.9974.14.camel@lenovo.internal.reciva.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 23-01-10 17:11, Phil Blundell wrote:
> On Sat, 2010-01-23 at 13:19 +0100, Paul Menzel wrote:
>> If it is possible, I suggest to add a new state (»Rejected – Commit
>> Policy«) for patches not complying with the commit policy [3]?
>
> If the patch is basically correct then it seems a little bit officious
> to reject it purely because it fails to conform to the commit policy in
> some way. Most of the issues listed in the policy are easy enough to
> fix up when applying the patch, after all.
And yet OE developers aren't fixing those up (latest example: the patch
stack Khem pushed last week), however easy it may be.
Maybe it's a case of sampling bias since I only inspect bad commits, but
in any case, the commit message of the commits that end up in .dev needs
to get improved.
regards,
Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLWzlJMkyGM64RGpERAvyDAKCE7pBD3krfl2wBN4GvYi59Wi+g8wCeLNmA
Wg9qotVtOlkyOtLgSkhTrPQ=
=ar+b
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-01-23 18:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 8:43 Patchwork Workflow improvement Holger Hans Peter Freyther
2010-01-23 9:22 ` Holger Hans Peter Freyther
2010-01-23 9:26 ` Holger Hans Peter Freyther
2010-01-23 9:56 ` Holger Hans Peter Freyther
2010-01-23 14:53 ` Paul Menzel
2010-01-23 15:12 ` Koen Kooi
2010-01-23 16:46 ` Holger Hans Peter Freyther
2010-01-23 16:53 ` pwclient (was: Patchwork Workflow improvement) Paul Menzel
2010-01-23 21:29 ` pwclient Paul Menzel
2010-01-23 10:42 ` Patchwork Workflow improvement Koen Kooi
2010-01-23 12:19 ` New state for patches not complying with commit policy (was: Patchwork Workflow improvement) Paul Menzel
2010-01-23 14:10 ` New state for patches not complying with commit policy Koen Kooi
2010-01-23 16:11 ` New state for patches not complying with commit policy (was: Patchwork Workflow improvement) Phil Blundell
2010-01-23 18:00 ` Koen Kooi [this message]
2010-01-23 12:56 ` Patchwork Workflow improvement Holger Hans Peter Freyther
2010-01-23 23:40 ` Khem Raj
2010-01-23 23:42 ` Khem Raj
2010-01-24 0:28 ` Rolf Leggewie
2010-01-24 13:00 ` Useful Git hooks for ensuring code quality. (was: Patchwork Workflow improvement) Paul Menzel
2010-01-23 15:19 ` Patchwork Workflow improvement Petr Štetiar
2010-01-23 16:40 ` Holger Hans Peter Freyther
2010-01-23 16:34 ` Rolf Leggewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hjfdg9$4lv$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.