* [PATCH] Do not generate NEON code for qt-4.6.2 embedded
@ 2010-03-12 15:29 Valentin Longchamp
2010-03-12 16:44 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Valentin Longchamp @ 2010-03-12 15:29 UTC (permalink / raw)
To: openembedded-devel; +Cc: Valentin Longchamp
http://bugreports.qt.nokia.com/browse/QTBUG-8749
Neon code is generated for armv6 processor, where it should be armv7 only.
This results in illegal instructions with some of the qt4 libraries.
The current solution is not optimal, I just needed a quick fix for my arch
and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
to point this issue out.
---
recipes/qt4/qt4-embedded_4.6.2.bb | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/recipes/qt4/qt4-embedded_4.6.2.bb b/recipes/qt4/qt4-embedded_4.6.2.bb
index 94ecd01..2d59609 100644
--- a/recipes/qt4/qt4-embedded_4.6.2.bb
+++ b/recipes/qt4/qt4-embedded_4.6.2.bb
@@ -2,5 +2,7 @@ require qt4-embedded.inc
PR = "${INC_PR}.0"
+QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
+
require qt-${PV}.inc
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Do not generate NEON code for qt-4.6.2 embedded
2010-03-12 15:29 [PATCH] Do not generate NEON code for qt-4.6.2 embedded Valentin Longchamp
@ 2010-03-12 16:44 ` Koen Kooi
2010-03-15 17:04 ` [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6 Valentin Longchamp
0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2010-03-12 16:44 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12-03-10 16:29, Valentin Longchamp wrote:
> http://bugreports.qt.nokia.com/browse/QTBUG-8749
> Neon code is generated for armv6 processor, where it should be armv7 only.
> This results in illegal instructions with some of the qt4 libraries.
>
> The current solution is not optimal, I just needed a quick fix for my arch
> and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
> to point this issue out.
Thanks for looking into this, could you please redo this patch with a PR
increase so distributions get the update automatically?
regards,
Koen
> ---
> recipes/qt4/qt4-embedded_4.6.2.bb | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/qt4/qt4-embedded_4.6.2.bb b/recipes/qt4/qt4-embedded_4.6.2.bb
> index 94ecd01..2d59609 100644
> --- a/recipes/qt4/qt4-embedded_4.6.2.bb
> +++ b/recipes/qt4/qt4-embedded_4.6.2.bb
> @@ -2,5 +2,7 @@ require qt4-embedded.inc
>
> PR = "${INC_PR}.0"
>
> +QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
> +
> require qt-${PV}.inc
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLmm9ZMkyGM64RGpERAnhkAJ4juTtN1P8CFWLeAjgQ0Mweon/WGQCgrhvN
vxsU6USZPP5CTP6ka7TTXDQ=
=Nf3F
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6
2010-03-12 16:44 ` Koen Kooi
@ 2010-03-15 17:04 ` Valentin Longchamp
2010-03-15 17:15 ` Koen Kooi
2010-03-16 0:36 ` Holger Hans Peter Freyther
0 siblings, 2 replies; 6+ messages in thread
From: Valentin Longchamp @ 2010-03-15 17:04 UTC (permalink / raw)
To: openembedded-devel; +Cc: Valentin Longchamp
http://bugreports.qt.nokia.com/browse/QTBUG-8749
Neon code is generated for armv6 processor, where it should be armv7 only.
This results in illegal instructions with some of the qt4 libraries.
The current solution is not optimal, I just needed a quick fix for my arch
and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
to point this issue out. But at least other arch (armv5 and armv4) should have
the same problem and receive the same fix.
---
recipes/qt4/qt4-embedded_4.6.2.bb | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/recipes/qt4/qt4-embedded_4.6.2.bb b/recipes/qt4/qt4-embedded_4.6.2.bb
index 94ecd01..8583752 100644
--- a/recipes/qt4/qt4-embedded_4.6.2.bb
+++ b/recipes/qt4/qt4-embedded_4.6.2.bb
@@ -1,6 +1,8 @@
require qt4-embedded.inc
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
+
+QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
require qt-${PV}.inc
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6
2010-03-15 17:04 ` [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6 Valentin Longchamp
@ 2010-03-15 17:15 ` Koen Kooi
2010-03-16 0:36 ` Holger Hans Peter Freyther
1 sibling, 0 replies; 6+ messages in thread
From: Koen Kooi @ 2010-03-15 17:15 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
thanks, applied
On 15-03-10 18:04, Valentin Longchamp wrote:
> http://bugreports.qt.nokia.com/browse/QTBUG-8749
> Neon code is generated for armv6 processor, where it should be armv7 only.
> This results in illegal instructions with some of the qt4 libraries.
>
> The current solution is not optimal, I just needed a quick fix for my arch
> and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
> to point this issue out. But at least other arch (armv5 and armv4) should have
> the same problem and receive the same fix.
> ---
> recipes/qt4/qt4-embedded_4.6.2.bb | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/qt4/qt4-embedded_4.6.2.bb b/recipes/qt4/qt4-embedded_4.6.2.bb
> index 94ecd01..8583752 100644
> --- a/recipes/qt4/qt4-embedded_4.6.2.bb
> +++ b/recipes/qt4/qt4-embedded_4.6.2.bb
> @@ -1,6 +1,8 @@
> require qt4-embedded.inc
>
> -PR = "${INC_PR}.0"
> +PR = "${INC_PR}.1"
> +
> +QT_CONFIG_FLAGS_append_armv6 = " -no-neon "
>
> require qt-${PV}.inc
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLnmscMkyGM64RGpERAickAJ9VD453KacoX2EDcQWeFgZG2vDPIgCfWjL6
oYTOJp08SjqM/PFpJBWkplM=
=ge+P
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6
2010-03-15 17:04 ` [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6 Valentin Longchamp
2010-03-15 17:15 ` Koen Kooi
@ 2010-03-16 0:36 ` Holger Hans Peter Freyther
2010-03-16 1:50 ` Khem Raj
1 sibling, 1 reply; 6+ messages in thread
From: Holger Hans Peter Freyther @ 2010-03-16 0:36 UTC (permalink / raw)
To: openembedded-devel
On Monday 15 March 2010 18:04:04 Valentin Longchamp wrote:
> http://bugreports.qt.nokia.com/browse/QTBUG-8749
> Neon code is generated for armv6 processor, where it should be armv7 only.
> This results in illegal instructions with some of the qt4 libraries.
>
> The current solution is not optimal, I just needed a quick fix for my arch
> and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
> to point this issue out. But at least other arch (armv5 and armv4) should
> have the same problem and receive the same fix.
Well... then maybe this should be fixed differently then?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6
2010-03-16 0:36 ` Holger Hans Peter Freyther
@ 2010-03-16 1:50 ` Khem Raj
0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2010-03-16 1:50 UTC (permalink / raw)
To: openembedded-devel
On Mon, Mar 15, 2010 at 5:36 PM, Holger Hans Peter Freyther
<holger+oe@freyther.de> wrote:
> On Monday 15 March 2010 18:04:04 Valentin Longchamp wrote:
>> http://bugreports.qt.nokia.com/browse/QTBUG-8749
>> Neon code is generated for armv6 processor, where it should be armv7 only.
>> This results in illegal instructions with some of the qt4 libraries.
>>
>> The current solution is not optimal, I just needed a quick fix for my arch
>> and I don't have the needed knowledge in OE to fix it cleanly, but I wanted
>> to point this issue out. But at least other arch (armv5 and armv4) should
>> have the same problem and receive the same fix.
>
> Well... then maybe this should be fixed differently then?
probably disable neon by default in qt build system and only enable it
for architectures that support
neon will make it work better with default option set for older arms.
One could also ask compiler
at build time but then it would be autoconf like :)
-Khem
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-03-16 1:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-12 15:29 [PATCH] Do not generate NEON code for qt-4.6.2 embedded Valentin Longchamp
2010-03-12 16:44 ` Koen Kooi
2010-03-15 17:04 ` [PATCH] Do not generate NEON code for qt-4.6.2 embedded on armv6 Valentin Longchamp
2010-03-15 17:15 ` Koen Kooi
2010-03-16 0:36 ` Holger Hans Peter Freyther
2010-03-16 1:50 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.