From: "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] video/sn9c102: improve error handling
Date: Sun, 28 Mar 2010 15:09:48 +0000 [thread overview]
Message-ID: <honrg5$7uk$1@dough.gmane.org> (raw)
In-Reply-To: 20100328115005.GW5069@bicker
Hi,
this patch seems incomplete.
You had an opening { wityhout the corresponding }.
Best regards,
Christophe Jaillet.
"Dan Carpenter" <error27@gmail.com> a écrit
dans le message de news:20100328115005.GW5069@bicker...
> Return an error if the controller is not found.
>
> Signed-off-by: Dan Carpenter
<error27@gmail.com>
>
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
b/drivers/media/video/sn9c102/sn9c102_core.c
> index cbf8087..28e19da 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -2295,7 +2295,7 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
> return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
> if (ctrl.id = s->qctrl[i].id) {
> if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
> return -EINVAL;
> @@ -2305,7 +2305,9 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> ctrl.value -= ctrl.value % s->qctrl[i].step;
> break;
> }
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] video/sn9c102: improve error handling
Date: Sun, 28 Mar 2010 17:09:48 +0200 [thread overview]
Message-ID: <honrg5$7uk$1@dough.gmane.org> (raw)
In-Reply-To: 20100328115005.GW5069@bicker
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
Hi,
this patch seems incomplete.
You had an opening { wityhout the corresponding }.
Best regards,
Christophe Jaillet.
"Dan Carpenter" <error27@gmail.com> a écrit
dans le message de news:20100328115005.GW5069@bicker...
> Return an error if the controller is not found.
>
> Signed-off-by: Dan Carpenter
<error27@gmail.com>
>
> diff --git a/drivers/media/video/sn9c102/sn9c102_core.c
b/drivers/media/video/sn9c102/sn9c102_core.c
> index cbf8087..28e19da 100644
> --- a/drivers/media/video/sn9c102/sn9c102_core.c
> +++ b/drivers/media/video/sn9c102/sn9c102_core.c
> @@ -2295,7 +2295,7 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
> return -EFAULT;
>
> - for (i = 0; i < ARRAY_SIZE(s->qctrl); i++)
> + for (i = 0; i < ARRAY_SIZE(s->qctrl); i++) {
> if (ctrl.id == s->qctrl[i].id) {
> if (s->qctrl[i].flags & V4L2_CTRL_FLAG_DISABLED)
> return -EINVAL;
> @@ -2305,7 +2305,9 @@ sn9c102_vidioc_s_ctrl(struct sn9c102_device* cam,
void __user * arg)
> ctrl.value -= ctrl.value % s->qctrl[i].step;
> break;
> }
next prev parent reply other threads:[~2010-03-28 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 11:50 [patch] video/sn9c102: improve error handling Dan Carpenter
2010-03-28 11:50 ` Dan Carpenter
2010-03-28 15:09 ` Christophe JAILLET [this message]
2010-03-28 15:09 ` Christophe JAILLET
2010-03-28 15:38 ` Dan Carpenter
2010-03-28 15:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='honrg5$7uk$1@dough.gmane.org' \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.