All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Remove superfluous "patch=1" parameters from some recipes.
Date: Sun, 06 Jun 2010 19:47:18 +0200	[thread overview]
Message-ID: <hugmv6$ej0$1@dough.gmane.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1006061312550.2992@lynx>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06-06-10 19:13, Robert P. J. Day wrote:
> 
> If a filename has either a ".diff" or ".patch" suffix, then the
> "patch=1" parameter is unnecessary.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

For the TI part:

Acked-by: Koen Kooi <k-kooi@ti.com>

The rest looks fine as well, but please change the commit message to be
more inline with OE guidelines, e.g. 'matrix-gui, udev: Remove
superfluous "patch=1" parameters'

> 
> ---
> 
> diff --git a/recipes/ti/matrix-gui_svn.bb b/recipes/ti/matrix-gui_svn.bb
> index 4388d28..4bfe7c2 100644
> --- a/recipes/ti/matrix-gui_svn.bb
> +++ b/recipes/ti/matrix-gui_svn.bb
> @@ -9,7 +9,7 @@ PV = "1.0"
>  PR = "r14+svnr${SRCPV}"
> 
>  SRC_URI = "svn://gforge.ti.com/svn/matrix_gui/;module=trunk;proto=https;user=anonymous;pswd='' \
> -    file://0001-Disable-cursor-override-for-X11.patch;patch=1 \
> +    file://0001-Disable-cursor-override-for-X11.patch \
>  	file://init \
>      file://matrix-gui.desktop \
>  "
> diff --git a/recipes/udev/udev_092.bb b/recipes/udev/udev_092.bb
> index 3ed05d1..a3c5521 100644
> --- a/recipes/udev/udev_092.bb
> +++ b/recipes/udev/udev_092.bb
> @@ -9,12 +9,12 @@ LD = "${CC}"
> 
>  PR = "${INC_PR}.0"
> 
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> -	    file://flags.patch;patch=1 \
> -	    file://udevsynthesize.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> +	    file://flags.patch \
> +	    file://udevsynthesize.patch \
>  	    file://udevsynthesize.sh \
> -            file://arm_inotify_fix.patch;patch=1 \
> -	    file://mtd-exclude-persistent.patch;patch=1 \
> +            file://arm_inotify_fix.patch \
> +	    file://mtd-exclude-persistent.patch \
>  	    file://mount.blacklist \
>  	   "
> 
> diff --git a/recipes/udev/udev_097.bb b/recipes/udev/udev_097.bb
> index 8757794..84d4b61 100644
> --- a/recipes/udev/udev_097.bb
> +++ b/recipes/udev/udev_097.bb
> @@ -14,8 +14,8 @@ PR = "${INC_PR}.0"
> 
>  LD = "${CC}"
> 
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> -	    file://flags.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> +	    file://flags.patch \
>  	    file://mount.blacklist \
>  	   "
> 
> diff --git a/recipes/udev/udev_100.bb b/recipes/udev/udev_100.bb
> index 7261483..a6692cf 100644
> --- a/recipes/udev/udev_100.bb
> +++ b/recipes/udev/udev_100.bb
> @@ -15,9 +15,9 @@ PR = "${INC_PR}.0"
> 
>  LD = "${CC}"
> 
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> -	    file://flags.patch;patch=1 \
> -	    file://mtd-exclude-persistent.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> +	    file://flags.patch \
> +	    file://mtd-exclude-persistent.patch \
>  	    file://mount.blacklist \
>  	    file://mount.sh \
>  	   "
> 
> 
> rday
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMC98mMkyGM64RGpERAjuHAJ9/HbYXwRkzRrhDqfV6CErsokIw2wCgtqNs
MPgsJxz4k/WgRA8+Lwz1mvc=
=OiWn
-----END PGP SIGNATURE-----




  reply	other threads:[~2010-06-06 17:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06 17:13 [PATCH] Remove superfluous "patch=1" parameters from some recipes Robert P. J. Day
2010-06-06 17:47 ` Koen Kooi [this message]
2010-06-06 18:09   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='hugmv6$ej0$1@dough.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.