* [PATCH] Remove superfluous "patch=1" parameters from some recipes.
@ 2010-06-06 17:13 Robert P. J. Day
2010-06-06 17:47 ` Koen Kooi
0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2010-06-06 17:13 UTC (permalink / raw)
To: OpenEmbedded Development mailing list
If a filename has either a ".diff" or ".patch" suffix, then the
"patch=1" parameter is unnecessary.
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
---
diff --git a/recipes/ti/matrix-gui_svn.bb b/recipes/ti/matrix-gui_svn.bb
index 4388d28..4bfe7c2 100644
--- a/recipes/ti/matrix-gui_svn.bb
+++ b/recipes/ti/matrix-gui_svn.bb
@@ -9,7 +9,7 @@ PV = "1.0"
PR = "r14+svnr${SRCPV}"
SRC_URI = "svn://gforge.ti.com/svn/matrix_gui/;module=trunk;proto=https;user=anonymous;pswd='' \
- file://0001-Disable-cursor-override-for-X11.patch;patch=1 \
+ file://0001-Disable-cursor-override-for-X11.patch \
file://init \
file://matrix-gui.desktop \
"
diff --git a/recipes/udev/udev_092.bb b/recipes/udev/udev_092.bb
index 3ed05d1..a3c5521 100644
--- a/recipes/udev/udev_092.bb
+++ b/recipes/udev/udev_092.bb
@@ -9,12 +9,12 @@ LD = "${CC}"
PR = "${INC_PR}.0"
-SRC_URI += "file://noasmlinkage.patch;patch=1 \
- file://flags.patch;patch=1 \
- file://udevsynthesize.patch;patch=1 \
+SRC_URI += "file://noasmlinkage.patch \
+ file://flags.patch \
+ file://udevsynthesize.patch \
file://udevsynthesize.sh \
- file://arm_inotify_fix.patch;patch=1 \
- file://mtd-exclude-persistent.patch;patch=1 \
+ file://arm_inotify_fix.patch \
+ file://mtd-exclude-persistent.patch \
file://mount.blacklist \
"
diff --git a/recipes/udev/udev_097.bb b/recipes/udev/udev_097.bb
index 8757794..84d4b61 100644
--- a/recipes/udev/udev_097.bb
+++ b/recipes/udev/udev_097.bb
@@ -14,8 +14,8 @@ PR = "${INC_PR}.0"
LD = "${CC}"
-SRC_URI += "file://noasmlinkage.patch;patch=1 \
- file://flags.patch;patch=1 \
+SRC_URI += "file://noasmlinkage.patch \
+ file://flags.patch \
file://mount.blacklist \
"
diff --git a/recipes/udev/udev_100.bb b/recipes/udev/udev_100.bb
index 7261483..a6692cf 100644
--- a/recipes/udev/udev_100.bb
+++ b/recipes/udev/udev_100.bb
@@ -15,9 +15,9 @@ PR = "${INC_PR}.0"
LD = "${CC}"
-SRC_URI += "file://noasmlinkage.patch;patch=1 \
- file://flags.patch;patch=1 \
- file://mtd-exclude-persistent.patch;patch=1 \
+SRC_URI += "file://noasmlinkage.patch \
+ file://flags.patch \
+ file://mtd-exclude-persistent.patch \
file://mount.blacklist \
file://mount.sh \
"
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove superfluous "patch=1" parameters from some recipes.
2010-06-06 17:13 [PATCH] Remove superfluous "patch=1" parameters from some recipes Robert P. J. Day
@ 2010-06-06 17:47 ` Koen Kooi
2010-06-06 18:09 ` Robert P. J. Day
0 siblings, 1 reply; 3+ messages in thread
From: Koen Kooi @ 2010-06-06 17:47 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06-06-10 19:13, Robert P. J. Day wrote:
>
> If a filename has either a ".diff" or ".patch" suffix, then the
> "patch=1" parameter is unnecessary.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
For the TI part:
Acked-by: Koen Kooi <k-kooi@ti.com>
The rest looks fine as well, but please change the commit message to be
more inline with OE guidelines, e.g. 'matrix-gui, udev: Remove
superfluous "patch=1" parameters'
>
> ---
>
> diff --git a/recipes/ti/matrix-gui_svn.bb b/recipes/ti/matrix-gui_svn.bb
> index 4388d28..4bfe7c2 100644
> --- a/recipes/ti/matrix-gui_svn.bb
> +++ b/recipes/ti/matrix-gui_svn.bb
> @@ -9,7 +9,7 @@ PV = "1.0"
> PR = "r14+svnr${SRCPV}"
>
> SRC_URI = "svn://gforge.ti.com/svn/matrix_gui/;module=trunk;proto=https;user=anonymous;pswd='' \
> - file://0001-Disable-cursor-override-for-X11.patch;patch=1 \
> + file://0001-Disable-cursor-override-for-X11.patch \
> file://init \
> file://matrix-gui.desktop \
> "
> diff --git a/recipes/udev/udev_092.bb b/recipes/udev/udev_092.bb
> index 3ed05d1..a3c5521 100644
> --- a/recipes/udev/udev_092.bb
> +++ b/recipes/udev/udev_092.bb
> @@ -9,12 +9,12 @@ LD = "${CC}"
>
> PR = "${INC_PR}.0"
>
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> - file://flags.patch;patch=1 \
> - file://udevsynthesize.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> + file://flags.patch \
> + file://udevsynthesize.patch \
> file://udevsynthesize.sh \
> - file://arm_inotify_fix.patch;patch=1 \
> - file://mtd-exclude-persistent.patch;patch=1 \
> + file://arm_inotify_fix.patch \
> + file://mtd-exclude-persistent.patch \
> file://mount.blacklist \
> "
>
> diff --git a/recipes/udev/udev_097.bb b/recipes/udev/udev_097.bb
> index 8757794..84d4b61 100644
> --- a/recipes/udev/udev_097.bb
> +++ b/recipes/udev/udev_097.bb
> @@ -14,8 +14,8 @@ PR = "${INC_PR}.0"
>
> LD = "${CC}"
>
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> - file://flags.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> + file://flags.patch \
> file://mount.blacklist \
> "
>
> diff --git a/recipes/udev/udev_100.bb b/recipes/udev/udev_100.bb
> index 7261483..a6692cf 100644
> --- a/recipes/udev/udev_100.bb
> +++ b/recipes/udev/udev_100.bb
> @@ -15,9 +15,9 @@ PR = "${INC_PR}.0"
>
> LD = "${CC}"
>
> -SRC_URI += "file://noasmlinkage.patch;patch=1 \
> - file://flags.patch;patch=1 \
> - file://mtd-exclude-persistent.patch;patch=1 \
> +SRC_URI += "file://noasmlinkage.patch \
> + file://flags.patch \
> + file://mtd-exclude-persistent.patch \
> file://mount.blacklist \
> file://mount.sh \
> "
>
>
> rday
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMC98mMkyGM64RGpERAjuHAJ9/HbYXwRkzRrhDqfV6CErsokIw2wCgtqNs
MPgsJxz4k/WgRA8+Lwz1mvc=
=OiWn
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove superfluous "patch=1" parameters from some recipes.
2010-06-06 17:47 ` Koen Kooi
@ 2010-06-06 18:09 ` Robert P. J. Day
0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2010-06-06 18:09 UTC (permalink / raw)
To: openembedded-devel
On Sun, 6 Jun 2010, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06-06-10 19:13, Robert P. J. Day wrote:
> >
> > If a filename has either a ".diff" or ".patch" suffix, then the
> > "patch=1" parameter is unnecessary.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> For the TI part:
>
> Acked-by: Koen Kooi <k-kooi@ti.com>
>
> The rest looks fine as well, but please change the commit message to be
> more inline with OE guidelines, e.g. 'matrix-gui, udev: Remove
> superfluous "patch=1" parameters'
ok, will resubmit shortly.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-06 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-06 17:13 [PATCH] Remove superfluous "patch=1" parameters from some recipes Robert P. J. Day
2010-06-06 17:47 ` Koen Kooi
2010-06-06 18:09 ` Robert P. J. Day
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.