All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] TS-78xxx NAND resource type should be IORESOURCE_MEM
@ 2010-11-05 17:14 ` Michael Spang
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Spang @ 2010-11-05 17:14 UTC (permalink / raw)
  To: linux-arm-kernel

The type was IORESOURCE_IO which is not what is expected by
plat_nand_probe(). This device has not worked since 2d098a72
("mtd: plat_nand: request memory resource before doing ioremap").

Signed-off-by: Michael Spang <mspang@csclub.uwaterloo.ca>
---
 arch/arm/mach-orion5x/ts78xx-setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-orion5x/ts78xx-setup.c b/arch/arm/mach-orion5x/ts78xx-setup.c
index 16f1bd5..c1c1cd0 100644
--- a/arch/arm/mach-orion5x/ts78xx-setup.c
+++ b/arch/arm/mach-orion5x/ts78xx-setup.c
@@ -239,7 +239,7 @@ static struct platform_nand_data ts78xx_ts_nand_data = {
 static struct resource ts78xx_ts_nand_resources = {
 	.start		= TS_NAND_DATA,
 	.end		= TS_NAND_DATA + 4,
-	.flags		= IORESOURCE_IO,
+	.flags		= IORESOURCE_MEM,
 };
 
 static struct platform_device ts78xx_ts_nand_device = {
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] TS-78xxx NAND resource type should be IORESOURCE_MEM
@ 2010-11-05 17:14 ` Michael Spang
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Spang @ 2010-11-05 17:14 UTC (permalink / raw)
  To: Lennert Buytenhek, Nicolas Pitre, Russell King, linux-arm-kernel,
	linux-kernel
  Cc: Michael Spang

The type was IORESOURCE_IO which is not what is expected by
plat_nand_probe(). This device has not worked since 2d098a72
("mtd: plat_nand: request memory resource before doing ioremap").

Signed-off-by: Michael Spang <mspang@csclub.uwaterloo.ca>
---
 arch/arm/mach-orion5x/ts78xx-setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-orion5x/ts78xx-setup.c b/arch/arm/mach-orion5x/ts78xx-setup.c
index 16f1bd5..c1c1cd0 100644
--- a/arch/arm/mach-orion5x/ts78xx-setup.c
+++ b/arch/arm/mach-orion5x/ts78xx-setup.c
@@ -239,7 +239,7 @@ static struct platform_nand_data ts78xx_ts_nand_data = {
 static struct resource ts78xx_ts_nand_resources = {
 	.start		= TS_NAND_DATA,
 	.end		= TS_NAND_DATA + 4,
-	.flags		= IORESOURCE_IO,
+	.flags		= IORESOURCE_MEM,
 };
 
 static struct platform_device ts78xx_ts_nand_device = {
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] TS-78xxx NAND resource type should be IORESOURCE_MEM
  2010-11-05 17:14 ` Michael Spang
  (?)
@ 2010-11-05 20:28 ` Alexander Clouter
  -1 siblings, 0 replies; 3+ messages in thread
From: Alexander Clouter @ 2010-11-05 20:28 UTC (permalink / raw)
  To: linux-arm-kernel

In gmane.linux.kernel Michael Spang <mspang@csclub.uwaterloo.ca> wrote:
>
> The type was IORESOURCE_IO which is not what is expected by
> plat_nand_probe(). This device has not worked since 2d098a72
> ("mtd: plat_nand: request memory resource before doing ioremap").
> 
> Signed-off-by: Michael Spang <mspang@csclub.uwaterloo.ca>
>
Acked-by: Alexander Clouter <alex@digriz.org.uk>

Cheers

> ---
> arch/arm/mach-orion5x/ts78xx-setup.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-orion5x/ts78xx-setup.c b/arch/arm/mach-orion5x/ts78xx-setup.c
> index 16f1bd5..c1c1cd0 100644
> --- a/arch/arm/mach-orion5x/ts78xx-setup.c
> +++ b/arch/arm/mach-orion5x/ts78xx-setup.c
> @@ -239,7 +239,7 @@ static struct platform_nand_data ts78xx_ts_nand_data = {
> static struct resource ts78xx_ts_nand_resources = {
>        .start          = TS_NAND_DATA,
>        .end            = TS_NAND_DATA + 4,
> -       .flags          = IORESOURCE_IO,
> +       .flags          = IORESOURCE_MEM,
> };
> 
> static struct platform_device ts78xx_ts_nand_device = {
> -- 
> 1.7.1

-- 
Alexander Clouter
.sigmonster says: 98% lean.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-11-05 20:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-05 17:14 [PATCH] TS-78xxx NAND resource type should be IORESOURCE_MEM Michael Spang
2010-11-05 17:14 ` Michael Spang
2010-11-05 20:28 ` Alexander Clouter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.