libvpx should not inherit autotools

libvpx should not inherit autotools

[Khem Raj]

Hi Koen

libvpx recipes are inheriting autotools while it seems to me that they
should not. Yes it does have a configure script but its not autoconf
generated but a hand written one
and there are no other traces of autoconf or automake and stuff that
goes with normal automake autoconf build systems.

Would you take a look at it ?

Thanks
-Khem

Re: libvpx should not inherit autotools

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Wed, Oct 6, 2010 at 10:59 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Hi Koen
>
> libvpx recipes are inheriting autotools while it seems to me that they
> should not. Yes it does have a configure script but its not autoconf
> generated but a hand written one
> and there are no other traces of autoconf or automake and stuff that
> goes with normal automake autoconf build systems.
>
> Would you take a look at it ?

something like attached would work. What do you think ?



>
> Thanks
> -Khem
>

[-- Attachment #2: diff --]
[-- Type: application/octet-stream, Size: 635 bytes --]

diff --git a/recipes/webm/libvpx.inc b/recipes/webm/libvpx.inc
index d773d3a..00eba26 100644
--- a/recipes/webm/libvpx.inc
+++ b/recipes/webm/libvpx.inc
@@ -1,12 +1,10 @@
 DESCRIPTION = "vpx Multi-Format Codec SDK"
 LICENSE = "BSD"
 
-INC_PR = "r4"
+INC_PR = "r5"
 
 SRC_URI = "http://webm.googlecode.com/files/libvpx-${PV}.tar.bz2"
 
-inherit autotools
-
 CFLAGS += "-fPIC"
 
 export CC
@@ -23,7 +21,12 @@ CONFIGUREOPTS = " \
           --enable-libs \
           --disable-install-docs \
 "
-
+do_configure() {
+	${S}/configure ${CONFIGUREOPTS}
+}
+do_compile() {
+	oe_runmake
+}
 do_install() {
 	oe_runmake install DESTDIR=${D}
 }

Re: libvpx should not inherit autotools

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07-10-10 08:26, Khem Raj wrote:
> On Wed, Oct 6, 2010 at 10:59 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> Hi Koen
>>
>> libvpx recipes are inheriting autotools while it seems to me that they
>> should not. Yes it does have a configure script but its not autoconf
>> generated but a hand written one
>> and there are no other traces of autoconf or automake and stuff that
>> goes with normal automake autoconf build systems.
>>
>> Would you take a look at it ?
> 
> something like attached would work. What do you think ?

That works for me, I was just too lazy to create the do_compile and
do_install :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMrXPfMkyGM64RGpERAu6qAJ9N6gQM1etGUzSsClL/TRYXYiTKsQCfZTRD
D2oDrFbvVot3RDKPS7DdEko=
=l+C2
-----END PGP SIGNATURE-----