[PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[Víctor Manuel Jáquez Leal]

By doing this we could use external toolchains for build angstrom
based images.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
---
 conf/distro/include/angstrom.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/distro/include/angstrom.inc b/conf/distro/include/angstrom.inc
index 8983c86..9e5c869 100644
--- a/conf/distro/include/angstrom.inc
+++ b/conf/distro/include/angstrom.inc
@@ -9,7 +9,7 @@ DISTRO_NAME = "Angstrom"
 
 BUILDNAME = "Angstrom ${DISTRO_VERSION}"
 
-TARGET_VENDOR = "-angstrom"
+TARGET_VENDOR ?= "-angstrom"
 
 SOC_FAMILY ?= "Unknown"
 
-- 
1.7.1

Re: [PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[Víctor M. Jáquez L.]

On Fri, Oct 08, 2010 at 08:07:11PM +0200, Víctor Manuel Jáquez Leal wrote:
> By doing this we could use external toolchains for build angstrom
> based images.
> 

Ping. Any comment about this patch?

vmjl

Re: [PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11-10-10 11:33, Víctor M. Jáquez L. wrote:
> On Fri, Oct 08, 2010 at 08:07:11PM +0200, Víctor Manuel Jáquez Leal wrote:
>> By doing this we could use external toolchains for build angstrom
>> based images.
>>
> 
> Ping. Any comment about this patch?

Something like this should be done in external-toolchain.inc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMsubwMkyGM64RGpERAltkAKCzoLak6SGJ13n0N+wPuPo8dKAthQCfTzOM
Jse5t4NNC6RdqDcyjOFfUbg=
=bDqB
-----END PGP SIGNATURE-----

Re: [PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[Víctor M. Jáquez L.]

On Mon, Oct 11, 2010 at 12:29:04PM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 11-10-10 11:33, Víctor M. Jáquez L. wrote:
> > On Fri, Oct 08, 2010 at 08:07:11PM +0200, Víctor Manuel Jáquez Leal wrote:
> >> By doing this we could use external toolchains for build angstrom
> >> based images.
> >>
> > 
> > Ping. Any comment about this patch?
> 
> Something like this should be done in external-toolchain.inc

There's no external-toolchain.inc in OE's org.openembedded.dev branch. So I
assume that you refer to a user's local.conf require.

I done that and it doesn't work: the distro/include/angstrom.inc evaluation
happens later and overrides the TARGET_VENDOR variable, that why a ?= is
needed.

vmjl

Re: [PATCH] angstrom.inc: set TARGET_VENDOR ?= "-angstrom"

[Frans Meulenbroeks]

2010/10/11 Víctor M. Jáquez L. <vjaquez@igalia.com>:
> On Mon, Oct 11, 2010 at 12:29:04PM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 11-10-10 11:33, Víctor M. Jáquez L. wrote:
>> > On Fri, Oct 08, 2010 at 08:07:11PM +0200, Víctor Manuel Jáquez Leal wrote:
>> >> By doing this we could use external toolchains for build angstrom
>> >> based images.
>> >>
>> >
>> > Ping. Any comment about this patch?
>>
>> Something like this should be done in external-toolchain.inc
>
> There's no external-toolchain.inc in OE's org.openembedded.dev branch. So I
> assume that you refer to a user's local.conf require.
>
> I done that and it doesn't work: the distro/include/angstrom.inc evaluation
> happens later and overrides the TARGET_VENDOR variable, that why a ?= is
> needed.
>
> vmjl

It is toolchain-external.inc, not external-toolchain.inc

/home/frans/workspace/openembedded.git/conf/distro/include/toolchain-external.inc

Enjoy! Frans