Re: hidp_output_raw_report, HID_OUTPUT_REPORT and Sixaxis

["pascal@pabr.org" <pascal@pabr.org>]

Antonio Ospite wrote:
> +++ b/net/bluetooth/hidp/core.c
>  	case HID_OUTPUT_REPORT:
> -		report_type = HIDP_TRANS_DATA | HIDP_DATA_RTYPE_OUPUT;
> +		report_type = HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_OUPUT;

> Is it only the Sixaxis which needs the output report as a SET_REPORT
> operation, or the change above is an actual fix?

My understanding of the Bluetooth HID Profile specification [1],
section 7.4.9, is that on the control channel DATA is only for
responding to an incoming GET_REPORT.  Since Linux is the HID
Host, it will probably never need to reply to a GET_REPORT.
So your patch looks good.

Note that usbhid_output_raw_report() seems to send OUTPUT
reports as USB interrupt messages and FEATURE reports as
USB SET_REPORT control messages, which makes sense too.
It would be nice if hidraw behaved the same over USB and
over Bluetooth.  Unfortunately I don't think you can drive
the sixaxis leds with DATA on the Bluetooth interrupt channel.

Pascal

[1] http://www.bluetooth.com/Specification%20Documents/HID_SPEC_V10.pdf